[dreamwidth/dw-free] 37ca99: remove spellcheck from remaining non-legacy pages

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 37ca99a8bf4905678c2fc2d6e72505ff2b918069
https://github.com/dreamwidth/dw-free/commit/37ca99a8bf4905678c2fc2d6e72505ff2b918069
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/pages/entry/new.js
M views/entry/form.tt

Log Message:
-----------
remove spellcheck from remaining non-legacy pages

This pulls spellcheck elements off the beta Create Entry page and cleans up one remaining setup check from the rendering of journal/quickreply.tt.


Commit: 63f384150db84910cdda60f0a7625b551b82f4ac
https://github.com/dreamwidth/dw-free/commit/63f384150db84910cdda60f0a7625b551b82f4ac
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm

Log Message:
-----------
retidy


Commit: ebe0bcd8cb885b3e1ab47b10e7242770628117fc
https://github.com/dreamwidth/dw-free/commit/ebe0bcd8cb885b3e1ab47b10e7242770628117fc
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/js/pages/entry/new.js

Log Message:
-----------
don't call undefined hashpassword() function in entry/new.js

Just noticed this when testing spellcheck removal. Presumably this function was removed with the recent password code changes, but the function was only called if hasRemote() returned false.

(Who loads /entry/new while logged out? I didn't even know that was allowed.)


Commit: 039702ac666e8cf4c293e70dfa53536834bad980
https://github.com/dreamwidth/dw-free/commit/039702ac666e8cf4c293e70dfa53536834bad980
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/js/pages/entry/new.js

Log Message:
-----------
fix security dropdown state bug related to undefined minsecurity


Compare: https://github.com/dreamwidth/dw-free/compare/f3253382cee7...039702ac666e

[dreamwidth/dw-free] 317619: jQ expects absolute protocol links, page prints re...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 317619ee029f39ecd206cec484e0bfb7fa7c4ef1
https://github.com/dreamwidth/dw-free/commit/317619ee029f39ecd206cec484e0bfb7fa7c4ef1
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/talkscreen.bml

Log Message:
-----------
jQ expects absolute protocol links, page prints relative protocol links

At some point we told LJ::S2::Image_std to start printing relative protocol links, but the JSON generated by talkscreen.bml for use by jquery.commentmanage.js was still using links that included the protocol, which meant that `this.element.find('img[src="'+newData.oldimage+'"]')` would never get a match, and so whenever you clicked on an icon for freezing/unfreezing or screening/unscreening a comment, the icon link would be replaced by a text link instead of another icon link.

ANYWAY this is the fix.

[dreamwidth/dw-free] 2148e5: [#2350] fix the other community conversion path

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 2148e55a3e6e7ce992ab5aa42c9ab4a619cd8dd9
https://github.com/dreamwidth/dw-free/commit/2148e55a3e6e7ce992ab5aa42c9ab4a619cd8dd9
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Community.pm
M views/communities/convert.tt.text

Log Message:
-----------
[#2350] fix the other community conversion path

It was simpler to add the one line check than to try and make the paths converge. I also noticed and fixed some errors in the statement immediately preceding the added lines.

[dreamwidth/dw-free] c7aa25: fix uninitialized value warning in priv_package cr...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: c7aa2572f45d187a0a52960c4c4897e497fd3856
https://github.com/dreamwidth/dw-free/commit/c7aa2572f45d187a0a52960c4c4897e497fd3856
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Console/Command/PrivPackage.pm

Log Message:
-----------
fix uninitialized value warning in priv_package create

Use of uninitialized value $cpkg in concatenation (.) or string at cgi-bin/LJ/Console/Command/PrivPackage.pm line 65.

Only happens when creating a new priv package, because no matching values are found in the database. The $cpkg variable isn't even used in that case.


Commit: 934098e31132720b45b0e2eb04c7648dd7b1c36b
https://github.com/dreamwidth/dw-free/commit/934098e31132720b45b0e2eb04c7648dd7b1c36b
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Priv.pm
M views/admin/priv/viewuser.tt
M views/admin/priv/viewuser.tt.text

Log Message:
-----------
[#1841] include priv packages on /admin/priv page

When granting privileges to a particular user, in addition to the existing dropdown of privileges, I added a second dropdown list of defined priv packages. I decided I liked the look of it better, and it was easier to implement than if I'd smashed the two sets of options into one menu as I had originally proposed. (It was also easier to implement than if I'd tried to do this before encapsulating the logic for granting privileges in the controller.)

This is just for ease of use when granting packages. All other package operations, such as seeing which privileges are included in a package, still require use of the priv_package console command.


Compare: https://github.com/dreamwidth/dw-free/compare/2148e55a3e6e...934098e31132

[dreamwidth/dw-free] b57498: LJ::Talk - fix a method call interpolation in post...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: b5749818c5503ccbbcfde2a532f2cd0b6d4a6e9d
https://github.com/dreamwidth/dw-free/commit/b5749818c5503ccbbcfde2a532f2cd0b6d4a6e9d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
LJ::Talk - fix a method call interpolation in post_comment

When I switched that from being a raw hashref access to being a method call, I
forgot that interpolating method calls straight into a string can sometimes be
Bad.


Commit: d24d603a05ee5ad49061263024724b255b32827e
https://github.com/dreamwidth/dw-free/commit/d24d603a05ee5ad49061263024724b255b32827e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Document all reply form POST arguments evar

One of the more outlandishly long comments I've done, but seems justified.


Commit: 7f533b032a79704ca96a23b25c4e746eef83fa93
https://github.com/dreamwidth/dw-free/commit/7f533b032a79704ca96a23b25c4e746eef83fa93
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Remove vestigial hidden fields (basepath, dtid) from talkform

Nothing on the backend ever consumes these, and you can't do a "less options"
post from the talkform back to the quick-reply. (Relatedly: ReplyPage can stop
passing dtid to talkform.)


Commit: 5f8f74ca8e7ba91fb177295ac086a1334a5ac8c1
https://github.com/dreamwidth/dw-free/commit/5f8f74ca8e7ba91fb177295ac086a1334a5ac8c1
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Talkform: Carry over viewing_thread value, if included in POST

Quick-reply uses this field to return you to the exact thread sub-view you were
on when you started replying. And the old previewform used to also respect that
when previewing FROM the QR, due to its mutant practice of copying every
unhandled form field into a hidden input.

Well, that broke when I killed previewform, but this brings it back, and ALSO
brings return-to-thread-view to "more options" posts for the first time.

It doesn't do anything about edit links or no-JS/newtab reply links, yet.


Commit: 73d1a9c842c9b7690e5f6df9457b687175cdeb87
https://github.com/dreamwidth/dw-free/commit/73d1a9c842c9b7690e5f6df9457b687175cdeb87
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
If ReplyPage gets a thread as a GET arg, pass it to talkform

Giving the one from the post args priority, though I can't think of how to make
them conflict.


Commit: 4abded54679bb829c68c5116d13307afedf60b72
https://github.com/dreamwidth/dw-free/commit/4abded54679bb829c68c5116d13307afedf60b72
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/S2/EntryPage.pm

Log Message:
-----------
Add thread to reply/edit links, and ensure consistency when expanding

This lets us return you to the same thread view you were in after you finish
editing a comment (or replying, if you're a no-JS person; we already handle new
comments if you go through the quick-reply).

The deal with `destination_thread` and `js_expand_url` is this: the JS thread
expander works by requesting a _normal HTML page_ for the thread you're trying
to expand, and then finding the comment bodies in it and shimming them into
place in the current page. Without some extra bookkeeping, that results in some
reply/edit links that will redirect you to a foreign thread context if you use
them. So this commit tweaks the URL used by the JS thread expander to include a
note about where the comments will actually be landing, and then we respect that
request when building the edit and reply URLs.


Compare: https://github.com/dreamwidth/dw-free/compare/934098e31132...4abded54679b

[dreamwidth/dw-free] 3f1e44: convert /admin/userlog

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 3f1e440129df0a2c0a062345a7a92dfd7a12319d
https://github.com/dreamwidth/dw-free/commit/3f1e440129df0a2c0a062345a7a92dfd7a12319d
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/UserHistory.pm
R htdocs/admin/userlog.bml
A views/admin/userlog.tt
A views/admin/userlog.tt.text

Log Message:
-----------
convert /admin/userlog


Commit: 92c6a33f0bad0ac37614dae4f92bd65b8cfa93db
https://github.com/dreamwidth/dw-free/commit/92c6a33f0bad0ac37614dae4f92bd65b8cfa93db
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/UserHistory.pm
M views/admin/userlog.tt.text

Log Message:
-----------
add coverage for newer userlog actions

We never added display messages for screen_set, screen_unset, and siteadmin_email.


Commit: d24b6bc636b04ea44b1788228bc34e22002d994c
https://github.com/dreamwidth/dw-free/commit/d24b6bc636b04ea44b1788228bc34e22002d994c
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/scss/skins/_page-layout-hacks.scss

Log Message:
-----------
fix for illegible table header links

I guess putting links in table header cells on Foundation site pages isn't a common thing to do because no one had noticed they looked terrible? This was the easiest way I could figure out to fix it.


Commit: c08848c546a741e2203f6f750b12c09bc14538e4
https://github.com/dreamwidth/dw-free/commit/c08848c546a741e2203f6f750b12c09bc14538e4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/UserHistory.pm
R htdocs/admin/statushistory.bml
A views/admin/statushistory.tt
A views/admin/statushistory.tt.text

Log Message:
-----------
convert /admin/statushistory


Commit: 7ca5074da21867715c3ca4902661ee57df8c9cd4
https://github.com/dreamwidth/dw-free/commit/7ca5074da21867715c3ca4902661ee57df8c9cd4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
fix uninitialized value warning

Every time I tested with a bogus username, I logged this warning from get_userid:

Use of uninitialized value $userid in addition (+) at cgi-bin/LJ/User/Account.pm line 1324.

This fix reproduces the existing behavior without the warning.


Commit: 1d2c9fa6c20c6f7640388b35adcafd419474945d
https://github.com/dreamwidth/dw-free/commit/1d2c9fa6c20c6f7640388b35adcafd419474945d
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/statushistory and /admin/userlog from legacy index


Commit: 970896476e25be8fd5143adea32ccb06ec887eb3
https://github.com/dreamwidth/dw-free/commit/970896476e25be8fd5143adea32ccb06ec887eb3
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin.pm

Log Message:
-----------
retidy


Compare: https://github.com/dreamwidth/dw-free/compare/4abded54679b...970896476e25

[dreamwidth/dw-free] b466f0: Beta create entries page: Improve/update previews

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: b466f046d6e814ecbeb7cb1215b0d16569b7de7d
https://github.com/dreamwidth/dw-free/commit/b466f046d6e814ecbeb7cb1215b0d16569b7de7d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/Entry.pm
M views/entry/preview.tt

Log Message:
-----------
Beta create entries page: Improve/update previews

The preview feature of beta create entries was starting to rot, slightly:

- Wasn't loading CSS and JS that journal content expects to have available,
which made things like image shrinking act wrong. Fix: call the same function
that journal pages use to require resources, and use the same res_includes
behavior for the S2 view.
- Template for site skin entry pages was outdated (maybe predated the effort to
move site-skin comments into S2). Fix: update the template. Long-term, it would
be better to figure out how to invoke the siteviews layout from a non-journal
context and just use that (see also: comment previews). But that seemed like a
rabbit hole, and I just needed this out of my way.


Commit: 8855b29935861cebd3ce0a07904a9aecd7b469fa
https://github.com/dreamwidth/dw-free/commit/8855b29935861cebd3ce0a07904a9aecd7b469fa
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M cgi-bin/LJ/Event/NewUserpic.pm
M cgi-bin/LJ/Feed.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/S2/IconsPage.pm
M t/cleaner-event.t
M t/cleaner-markdown.t

Log Message:
-----------
LJ::CleanHTML (and callers) - Minor cleanups

- Stop adding `` tags to long words, this is *extremely* silly. Just use
word-wrap/overflow-wrap in CSS.
- Don't create a new hashref on every call to update_tag
- Remove unused 'linkify' option from some calls


Commit: 4845d9f19aa695b9757b768a7504ce50697fe980
https://github.com/dreamwidth/dw-free/commit/4845d9f19aa695b9757b768a7504ce50697fe980
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
A cgi-bin/DW/Formats.pm
A t/formats.t

Log Message:
-----------
DW::Formats - New helper package for markup formats

This new package isn't used by anything yet, but it sort of serves as a map for
the following commits.

The goal of the coming changes is to introduce *named markup formats* on DW.
We'll use these formats whenever we need to display user-entered body text,
and we'll preserve the format name alongside the source as a permanent record of
how the user expected their markup to be interpreted when they wrote it. This
will give us the freedom to update and change our formatting behaviors as
needed, without vandalizing millions of historical posts or requiring
world-ending database migrations to update old formatting.

STORAGE: Entries and comments both already include an `editor` prop, which will
store the format ID for a given post. Other kinds of body content might be
handled differently as we expand format support. (For example, user bios are
singletons, so their format might be stored as a userprop.) Additionally, we'll
save a user's preferred format for a given content type and use it as the
default in editing UIs.

VERSIONING: Formats are versioned, and any significant change to markup behavior
is now expected to result in a new format name. To keep things manageable,
editing UIs will only offer a limited number of "active" formats at any given
time. (Exception: when editing old content, its current format will be available
in the UI even if it's obsolete.)

USAGE: We'll be using named formats in two ways:

- DISPLAY: Formats will determine the behavior of the HTML cleaner when
preparing content for display. They can affect the behavior of things like line
breaks, special non-standard HTML tags, `mentions`, and more.
- UI: The currently selected format within an editing UI can potentially affect
its behavior and layout. (Whether to initialize or deinitialize the rich text
editor, whether plain-text editing buttons should emit HTML or Markdown, etc.)

The initial set of formats is a codification of the formats DW **already uses,**
which are currently selected by emergent interactions between the
`opt_preformatted` prop, the imported/syndicated status, Secret Glyphs
(`!markdown`), and the editor prop (currently only used in emailed comments).


Commit: b2721e27faca1a68b59b1f71305c336afdd1ba34
https://github.com/dreamwidth/dw-free/commit/b2721e27faca1a68b59b1f71305c336afdd1ba34
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
LJ::CleanHTML::clean - Add `nodwtags` option (for `html_extra_raw`)

This new option allows the cleaner to skip processing for all special-sauce
DW/LJ tags, like `[Unknown site tag]` and `( Read more... )