[dreamwidth/dw-free] b57498: LJ::Talk - fix a method call interpolation in post...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: b5749818c5503ccbbcfde2a532f2cd0b6d4a6e9d
https://github.com/dreamwidth/dw-free/commit/b5749818c5503ccbbcfde2a532f2cd0b6d4a6e9d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
LJ::Talk - fix a method call interpolation in post_comment

When I switched that from being a raw hashref access to being a method call, I
forgot that interpolating method calls straight into a string can sometimes be
Bad.


Commit: d24d603a05ee5ad49061263024724b255b32827e
https://github.com/dreamwidth/dw-free/commit/d24d603a05ee5ad49061263024724b255b32827e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Document all reply form POST arguments evar

One of the more outlandishly long comments I've done, but seems justified.


Commit: 7f533b032a79704ca96a23b25c4e746eef83fa93
https://github.com/dreamwidth/dw-free/commit/7f533b032a79704ca96a23b25c4e746eef83fa93
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Remove vestigial hidden fields (basepath, dtid) from talkform

Nothing on the backend ever consumes these, and you can't do a "less options"
post from the talkform back to the quick-reply. (Relatedly: ReplyPage can stop
passing dtid to talkform.)


Commit: 5f8f74ca8e7ba91fb177295ac086a1334a5ac8c1
https://github.com/dreamwidth/dw-free/commit/5f8f74ca8e7ba91fb177295ac086a1334a5ac8c1
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Talkform: Carry over viewing_thread value, if included in POST

Quick-reply uses this field to return you to the exact thread sub-view you were
on when you started replying. And the old previewform used to also respect that
when previewing FROM the QR, due to its mutant practice of copying every
unhandled form field into a hidden input.

Well, that broke when I killed previewform, but this brings it back, and ALSO
brings return-to-thread-view to "more options" posts for the first time.

It doesn't do anything about edit links or no-JS/newtab reply links, yet.


Commit: 73d1a9c842c9b7690e5f6df9457b687175cdeb87
https://github.com/dreamwidth/dw-free/commit/73d1a9c842c9b7690e5f6df9457b687175cdeb87
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
If ReplyPage gets a thread as a GET arg, pass it to talkform

Giving the one from the post args priority, though I can't think of how to make
them conflict.


Commit: 4abded54679bb829c68c5116d13307afedf60b72
https://github.com/dreamwidth/dw-free/commit/4abded54679bb829c68c5116d13307afedf60b72
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/S2/EntryPage.pm

Log Message:
-----------
Add thread to reply/edit links, and ensure consistency when expanding

This lets us return you to the same thread view you were in after you finish
editing a comment (or replying, if you're a no-JS person; we already handle new
comments if you go through the quick-reply).

The deal with `destination_thread` and `js_expand_url` is this: the JS thread
expander works by requesting a _normal HTML page_ for the thread you're trying
to expand, and then finding the comment bodies in it and shimming them into
place in the current page. Without some extra bookkeeping, that results in some
reply/edit links that will redirect you to a foreign thread context if you use
them. So this commit tweaks the URL used by the JS thread expander to include a
note about where the comments will actually be landing, and then we respect that
request when building the edit and reply URLs.


Compare: https://github.com/dreamwidth/dw-free/compare/934098e31132...4abded54679b