[dreamwidth/dw-free] c7aa25: fix uninitialized value warning in priv_package cr...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: c7aa2572f45d187a0a52960c4c4897e497fd3856
https://github.com/dreamwidth/dw-free/commit/c7aa2572f45d187a0a52960c4c4897e497fd3856
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Console/Command/PrivPackage.pm

Log Message:
-----------
fix uninitialized value warning in priv_package create

Use of uninitialized value $cpkg in concatenation (.) or string at cgi-bin/LJ/Console/Command/PrivPackage.pm line 65.

Only happens when creating a new priv package, because no matching values are found in the database. The $cpkg variable isn't even used in that case.


Commit: 934098e31132720b45b0e2eb04c7648dd7b1c36b
https://github.com/dreamwidth/dw-free/commit/934098e31132720b45b0e2eb04c7648dd7b1c36b
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Priv.pm
M views/admin/priv/viewuser.tt
M views/admin/priv/viewuser.tt.text

Log Message:
-----------
[#1841] include priv packages on /admin/priv page

When granting privileges to a particular user, in addition to the existing dropdown of privileges, I added a second dropdown list of defined priv packages. I decided I liked the look of it better, and it was easier to implement than if I'd smashed the two sets of options into one menu as I had originally proposed. (It was also easier to implement than if I'd tried to do this before encapsulating the logic for granting privileges in the controller.)

This is just for ease of use when granting packages. All other package operations, such as seeing which privileges are included in a package, still require use of the priv_package console command.


Compare: https://github.com/dreamwidth/dw-free/compare/2148e55a3e6e...934098e31132