![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
[dreamwidth/dw-free] 317619: jQ expects absolute protocol links, page prints re...
Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 317619ee029f39ecd206cec484e0bfb7fa7c4ef1
https://github.com/dreamwidth/dw-free/commit/317619ee029f39ecd206cec484e0bfb7fa7c4ef1
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)
Changed paths:
M htdocs/talkscreen.bml
Log Message:
-----------
jQ expects absolute protocol links, page prints relative protocol links
At some point we told LJ::S2::Image_std to start printing relative protocol links, but the JSON generated by talkscreen.bml for use by jquery.commentmanage.js was still using links that included the protocol, which meant that `this.element.find('img[src="'+newData.oldimage+'"]')` would never get a match, and so whenever you clicked on an icon for freezing/unfreezing or screening/unscreening a comment, the icon link would be replaced by a text link instead of another icon link.
ANYWAY this is the fix.
Home: https://github.com/dreamwidth/dw-free
Commit: 317619ee029f39ecd206cec484e0bfb7fa7c4ef1
https://github.com/dreamwidth/dw-free/commit/317619ee029f39ecd206cec484e0bfb7fa7c4ef1
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)
Changed paths:
M htdocs/talkscreen.bml
Log Message:
-----------
jQ expects absolute protocol links, page prints relative protocol links
At some point we told LJ::S2::Image_std to start printing relative protocol links, but the JSON generated by talkscreen.bml for use by jquery.commentmanage.js was still using links that included the protocol, which meant that `this.element.find('img[src="'+newData.oldimage+'"]')` would never get a match, and so whenever you clicked on an icon for freezing/unfreezing or screening/unscreening a comment, the icon link would be replaced by a text link instead of another icon link.
ANYWAY this is the fix.