[dreamwidth/dw-free] 48b160: [#1126] Tag nav overlay triggered by click

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 48b160aed12e75edc59a3e3b0927fc2ae6b457f8
https://github.com/dreamwidth/dw-free/commit/48b160aed12e75edc59a3e3b0927fc2ae6b457f8
Author: Afuna <fu@dreamwidth.org>
Date: 2015-02-10 (Tue, 10 Feb 2015)

Changed paths:
M cgi-bin/DW/Controller/Redirect.pm
M cgi-bin/LJ/S2.pm
A htdocs/img/silk/site/add.png
A htdocs/img/silk/site/delete.png
A htdocs/js/journals/jquery.tag-nav.js
M htdocs/stc/lj_base.css
M styles/core2.s2

Log Message:
-----------
[#1126] Tag nav overlay triggered by click

* to use: click the expand icon next to the "Tags:" label; select a tag;
click next/previous

* only allows one tag to be navigated at a time

* on next page load, shows the overlay with the tag selected again


Commit: e2b9fd61360a492c7dec6e866e617743ac85ea52
https://github.com/dreamwidth/dw-free/commit/e2b9fd61360a492c7dec6e866e617743ac85ea52
Author: Afuna <afuna@users.noreply.github.com>
Date: 2015-02-23 (Mon, 23 Feb 2015)

Changed paths:
M cgi-bin/DW/Controller/Redirect.pm
M cgi-bin/LJ/S2.pm
A htdocs/img/silk/site/add.png
A htdocs/img/silk/site/delete.png
A htdocs/js/journals/jquery.tag-nav.js
M htdocs/stc/lj_base.css
M styles/core2.s2

Log Message:
-----------
Merge pull request #1206 from afuna/tag-nav-bug-1126

[#1126] Tag nav overlay triggered by click


Compare: https://github.com/dreamwidth/dw-free/compare/f3d2e38bc4e9...e2b9fd61360a

Comments

[ninetydegrees]

Dunno if it's just me or if you're not done with this yet but the arrows sometimes appear in a strange place on tag-filtered custom-styled pages (like about 100 pixels or more on the left from where they should be). Tried it with different styles both in FF and Chrome. If I reload the page sometimes it's fine sometimes it's not.
Also I don't know if the style's stylesheet interferes or not but in some styles such as Crisped and For the Bold the plus button is surrounded by a border. I didn't check all styles so there might be more unexpected additional styling.

[ninetydegrees]

Oh interesting! I've just switched to Motion and the arrows moved from the left to the correct place when I clicked on +. Might help narrow down why it's inconsistent.

[fu]

Thanks for all the info!

I’ve put up a PR which I think covers both issues (I’m more sure about the border than the other one though).

PS I really appreciate your poking at this before it goes live <3

[fu]

Hey thanks for pointing this out! This is on my list to check out / figure out.

Feel free to let me know if you notice anything else, either here or as an issue on github or something <3