Jul. 21st, 2020

github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/code-tour
Home: https://github.com/dreamwidth/dw-free
Commit: c1fee2b02943bb9ce3f4884a61df3339bcd1a63d
https://github.com/dreamwidth/dw-free/commit/c1fee2b02943bb9ce3f4884a61df3339bcd1a63d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-21 (Sun, 21 Jun 2020)

Changed paths:
M htdocs/scss/skins/_nav.scss

Log Message:
-----------
Fix misaligned site logo

I commented out Foundation's default image CSS because it was inappropriate for
a world where we display entries and comments in the foundationized site skins.
But the site logo was relying on that default `vertical-align: middle` rule, and
floated up a centimeter or so once it was gone. Didn't break anything, but sure
looked gross.


Commit: 6576506f3089d7aa20b6006439e2511441ea8eb2
https://github.com/dreamwidth/dw-free/commit/6576506f3089d7aa20b6006439e2511441ea8eb2
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-26 (Fri, 26 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm

Log Message:
-----------
hush warnings in /support/faqbrowse

Some of these were due to the viewed FAQ having no category defined, but some were just debug warnings that escaped into the wild, and I had to go back to the original BML file to see what the value of $backfaqcat was supposed to be.

I replaced BML::get_language with the mostly-equivalent LJ::Lang::get_effective_lang, but I didn't see an LJ::Lang equivalent for BML::get_language_default.


Commit: 1e47f30393de5dde053eddb95414f7a2b25940ae
https://github.com/dreamwidth/dw-free/commit/1e47f30393de5dde053eddb95414f7a2b25940ae
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M views/support/faqsearch.tt

Log Message:
-----------
Remove extra .columns div in faqsearch

Since Foundation uses floats to fake up its row/column grid layout thing, it can
launch itself into the Minus World if you do anything mildly unexpected with the
nesting.

Said nesting is supposed to go `.row > (.columns) * N`, and then a columns
container can contain other rows if it wants. This page's nesting was going
`.row > .columns > (form) > .columns > .row`. Some browsers just make a pained
expression and render it fine, but Safari totally splodes.


Commit: 00a04ceeb324d359f6c33ef8a4d515abb68f109b
https://github.com/dreamwidth/dw-free/commit/00a04ceeb324d359f6c33ef8a4d515abb68f109b
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Customize/Advanced.pm

Log Message:
-----------
fix uninitialized value warning in layerbrowse_handler

Use of uninitialized value in string eq at cgi-bin/DW/Controller/Customize/Advanced.pm line 160.


Commit: 2e3310cfe37f818898cfd5a46867008768ae6614
https://github.com/dreamwidth/dw-free/commit/2e3310cfe37f818898cfd5a46867008768ae6614
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/UserViews.pm
R htdocs/admin/recent_comments.bml
R htdocs/admin/styleinfo.bml
A views/admin/recent_comments.tt
A views/admin/recent_comments.tt.text
A views/admin/styleinfo.tt
A views/admin/styleinfo.tt.text

Log Message:
-----------
convert /admin/recent_comments and /admin/styleinfo


Commit: 2b4b262c90aea6df88ceaa948f86217afc747d76
https://github.com/dreamwidth/dw-free/commit/2b4b262c90aea6df88ceaa948f86217afc747d76
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/LJ/DB.pm

Log Message:
-----------
fix uninitialized value warning in alloc_user_counter

Use of uninitialized value $newmax in numeric gt (>) at cgi-bin/LJ/DB.pm line 616.

Use of uninitialized value $res in numeric gt (>) at cgi-bin/LJ/DB.pm line 616.

When leaving a comment for the first time, we're comparing two undefined variables. I think this change will fix the warning without changing the behavior, by skipping the assignment of undef to a value that is already undef.


Commit: b83269dfc553f762ccff4e2f67356b6c1e818c71
https://github.com/dreamwidth/dw-free/commit/b83269dfc553f762ccff4e2f67356b6c1e818c71
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin/UserViews.pm
R htdocs/admin/impersonate.bml
R htdocs/admin/impersonate.bml.text
A views/admin/impersonate.tt
A views/admin/impersonate.tt.text

Log Message:
-----------
convert /admin/impersonate


Commit: 3f52efb64107c0c4db8e1f25468c91954490fd18
https://github.com/dreamwidth/dw-free/commit/3f52efb64107c0c4db8e1f25468c91954490fd18
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/recent_comments and /admin/styleinfo from legacy index


Commit: ac6985b4c08c1f0d6a0beb8b6596409080634516
https://github.com/dreamwidth/dw-free/commit/ac6985b4c08c1f0d6a0beb8b6596409080634516
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/faq from legacy index

Also removes strings for admin.dbschema which don't belong to anything currently in the code base.


Commit: 2d5851c7f9d23a3941428ad3ae503200576b3fcc
https://github.com/dreamwidth/dw-free/commit/2d5851c7f9d23a3941428ad3ae503200576b3fcc
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/FAQ.pm
R htdocs/admin/faq/index.bml
A views/admin/faq/index.tt
A views/admin/faq/index.tt.text

Log Message:
-----------
convert /admin/faq/index


Commit: b336f1d68d4d634d40e566b8461560d7993bc98c
https://github.com/dreamwidth/dw-free/commit/b336f1d68d4d634d40e566b8461560d7993bc98c
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm
M htdocs/admin/faq/faqedit.bml

Log Message:
-----------
remove unused FAQ transform hook calls


Commit: b95763bf6532043b4bd7699bb4c0d67b2e97812a
https://github.com/dreamwidth/dw-free/commit/b95763bf6532043b4bd7699bb4c0d67b2e97812a
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/FAQ.pm
M views/admin/faq/index.tt

Log Message:
-----------
define _page_setup helper sub


Commit: 043e76f7e77b5dab05eb5b2403eecc3a69b12304
https://github.com/dreamwidth/dw-free/commit/043e76f7e77b5dab05eb5b2403eecc3a69b12304
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/FAQ.pm
R htdocs/admin/faq/faqedit.bml
A views/admin/faq/faqedit.tt
A views/admin/faq/faqedit.tt.text

Log Message:
-----------
convert /admin/faq/faqedit


Commit: 77c2ae63605c7fc039622d09fe0f51f71836c991
https://github.com/dreamwidth/dw-free/commit/77c2ae63605c7fc039622d09fe0f51f71836c991
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R htdocs/admin/faq/faqcat.bml.text

Log Message:
-----------
remove htdocs/admin/faq/faqcat.bml.text


Commit: 8a6151eeaca68bbea71d16e1db59b05195809dd0
https://github.com/dreamwidth/dw-free/commit/8a6151eeaca68bbea71d16e1db59b05195809dd0
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/FAQ.pm
R htdocs/admin/faq/faqcat.bml
A views/admin/faq/editcat.tt
A views/admin/faq/editcat.tt.text
A views/admin/faq/faqcat.tt
A views/admin/faq/faqcat.tt.text

Log Message:
-----------
convert /admin/faq/faqcat


Commit: f47787f82ac7cb2d3e9792d47699d19b362abafc
https://github.com/dreamwidth/dw-free/commit/f47787f82ac7cb2d3e9792d47699d19b362abafc
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/FAQ.pm
R htdocs/admin/faq/readcat.bml
A views/admin/faq/readcat.tt
A views/admin/faq/readcat.tt.text

Log Message:
-----------
convert /admin/faq/readcat


Commit: bb6b50a23c5649e2aae32c18d9e269b0d9f35ac6
https://github.com/dreamwidth/dw-free/commit/bb6b50a23c5649e2aae32c18d9e269b0d9f35ac6
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Settings.pm
R htdocs/lostinfo.bml
R htdocs/lostinfo.bml.text
R htdocs/lostinfo_do.bml.text
A views/settings/lostinfo.tt
A views/settings/lostinfo.tt.text
A views/settings/lostpass.tt.text
A views/settings/lostuser.tt.text

Log Message:
-----------
convert /lostinfo


Commit: f2045fe5469c528ecf849ead23bb6ce852ad10b0
https://github.com/dreamwidth/dw-free/commit/f2045fe5469c528ecf849ead23bb6ce852ad10b0
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M htdocs/scss/skins/_form-elements.scss

Log Message:
-----------
Foundation: Reduce chaos by copying .button styles to .submit

Sass's `[personal profile] extend` directive works by adding that selector to EVERY place where
the extended selector is used. This includes places like `:not()`
pseudo-classes, and it can result in some very top-shelf chaos and dismay.

Foundation's separation of concerns is pretty poor, and .button leaks so many
places that it's a real bad candidate for `[personal profile] extend`ing. So even though copying
all of the actual .button rules into .submit looks absolutely disgusting, it
stops some weird rampages before they start.

This is another thing that might have good arguments against it if we were using
a living framework, but staying on an EOLed one is a lot like squatting in a
condemned house, so it's kind of like why NOT cut a hole in the floor and
install a makeshift dumbwaiter to work around the fact that the dishwasher is on
a different floor than the stove.


Commit: 7c7dfcddaa12764f428c8c07f0fc546c90f43423
https://github.com/dreamwidth/dw-free/commit/7c7dfcddaa12764f428c8c07f0fc546c90f43423
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M htdocs/scss/skins/_nav.scss

Log Message:
-----------
Foundation: Repurpose a main nav hack to make new Tropos match old Tropos

This was working around the .submit thing I changed in the previous commit,
which it doesn't need to do anymore.

But we do still need something to make the Foundation main nav behavior match
the old main nav behavior:

- Default Foundation top bar highlights the active top-level link AND the
currently hovered sub-nav link using the hover color.
- The old designs make the active top-level link match the sub-nav background,
and only the currently hovered link gets the hover color.

So we can use most of this rule to make the active top-level link use the menu
body background instead of the hover background.


Commit: 00271919437832c279b4658ae01880f26774f953
https://github.com/dreamwidth/dw-free/commit/00271919437832c279b4658ae01880f26774f953
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/redirect.dat
R htdocs/shop/index.bml

Log Message:
-----------
remove htdocs/shop/index.bml


Commit: 65bf98dbfb81b77defd74ea7a711183569d57190
https://github.com/dreamwidth/dw-free/commit/65bf98dbfb81b77defd74ea7a711183569d57190
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
A cgi-bin/DW/Controller/Shop/Legacy.pm
R htdocs/shop/creditcard.bml
R htdocs/shop/creditcard.bml.text
M htdocs/shop/creditcard_wait.bml.text
R htdocs/shop/gco_notify.bml
R htdocs/shop/pp_notify.bml
A views/shop/legacy/pp_button.tt
A views/shop/legacy/pp_button.tt.text

Log Message:
-----------
convert creditcard.bml, gco_notify.bml, pp_notify.bml

I used a different name for the template from creditcard.bml to make it more obvious what it actually did, which was not as important as the filename made it sound.

None of these are believed to be in active use on the site currently, and so haven't been tested apart from making sure the controller module compiled.


Commit: 7374fb9692a7bd1b3aaf28eb00d669ffae63e733
https://github.com/dreamwidth/dw-free/commit/7374fb9692a7bd1b3aaf28eb00d669ffae63e733
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
A cgi-bin/DW/Controller/Shop/CreditCard.pm
R htdocs/shop/creditcard_wait.bml
R htdocs/shop/creditcard_wait.bml.text
A views/shop/cc/creditcard_wait.tt
A views/shop/cc/creditcard_wait.tt.text

Log Message:
-----------
convert /shop/creditcard_wait


Commit: 9bb34775c565e6c86409cb97999306a4fc23d12e
https://github.com/dreamwidth/dw-free/commit/9bb34775c565e6c86409cb97999306a4fc23d12e
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Shop/CreditCard.pm
R htdocs/shop/entercc.bml
R htdocs/shop/entercc.bml.text
A views/shop/cc/entercc.tt
A views/shop/cc/entercc.tt.text

Log Message:
-----------
convert /shop/entercc


Commit: 662e24970841142d1374dee77830ba91b51a1171
https://github.com/dreamwidth/dw-free/commit/662e24970841142d1374dee77830ba91b51a1171
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/LJ/Customize.pm
M htdocs/moodlist.bml

Log Message:
-----------
remove references to undefined mood-related hooks

- modify_mood_theme_list
- mood_theme_is_active
- mood_theme_author


Commit: 7ca919b3ddb14107369de5b1ae340a366afb0556
https://github.com/dreamwidth/dw-free/commit/7ca919b3ddb14107369de5b1ae340a366afb0556
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
A cgi-bin/DW/Controller/MoodList.pm
R htdocs/moodlist.bml
R htdocs/moodlist.bml.text
A views/mood/index.tt
A views/mood/index.tt.text
A views/mood/table.tt
A views/mood/table.tt.text
A views/mood/tree.tt
A views/mood/tree.tt.text

Log Message:
-----------
convert moodlist.bml


Commit: 098ea0c888b4c92619d01d954d0842f812e834ca
https://github.com/dreamwidth/dw-free/commit/098ea0c888b4c92619d01d954d0842f812e834ca
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm

Log Message:
-----------
remove more debug warnings


Commit: 75b0f47c54358c9fbe8b0ae693edf3eb1eddbc56
https://github.com/dreamwidth/dw-free/commit/75b0f47c54358c9fbe8b0ae693edf3eb1eddbc56
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm

Log Message:
-----------
display_answer assigned wrong value

This fix is live in production.


Commit: a53b29a7c8ca77dbd51e0852c9b499bc68ce52da
https://github.com/dreamwidth/dw-free/commit/a53b29a7c8ca77dbd51e0852c9b499bc68ce52da
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm

Log Message:
-----------
remove uninitialized value warnings


Commit: 1301c7af13c1764d53f28ddb94a9a4e3ed739dc9
https://github.com/dreamwidth/dw-free/commit/1301c7af13c1764d53f28ddb94a9a4e3ed739dc9
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M views/stats/site.tt

Log Message:
-----------
fix for generated graphs not loading on /admin/stats

Using a scoped include for views/stats/site.tt doesn't scope the img src.


Commit: 6530763bdffafa1152d476710ffdc1f73da5be70
https://github.com/dreamwidth/dw-free/commit/6530763bdffafa1152d476710ffdc1f73da5be70
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
A cgi-bin/DW/Controller/Stats.pm
R htdocs/stats.bml
R htdocs/stats.bml.text
A views/stats/main.tt
A views/stats/main.tt.text

Log Message:
-----------
convert stats.bml


Commit: d69b8d4de94c8d907de0c5f261aaafd5d637d7a3
https://github.com/dreamwidth/dw-free/commit/d69b8d4de94c8d907de0c5f261aaafd5d637d7a3
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/redirect.dat
R htdocs/stats/index.bml

Log Message:
-----------
remove htdocs/stats/index.bml

There is still a placeholder in the htdocs/stats directory, since it is used for output from bin/maint/stats.pl.


Commit: 8d7da478d7f51cf31f76267b8785a0223f4df2bf
https://github.com/dreamwidth/dw-free/commit/8d7da478d7f51cf31f76267b8785a0223f4df2bf
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Misc.pm
R htdocs/site/index.bml
R htdocs/site/index.bml.text
A views/site/index.tt
A views/site/index.tt.text

Log Message:
-----------
convert /site/index


Commit: 6f10f3ec0e96a7b7ef922ec937e8112da39f7e58
https://github.com/dreamwidth/dw-free/commit/6f10f3ec0e96a7b7ef922ec937e8112da39f7e58
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M views/site/index.tt

Log Message:
-----------
Switch to multi-column, switch to foundation


Commit: d47d0d4384b27492946a8d3e9fbb3d09d14e07cb
https://github.com/dreamwidth/dw-free/commit/d47d0d4384b27492946a8d3e9fbb3d09d14e07cb
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M views/site/index.tt

Log Message:
-----------
Fix Safari margin-bottom spill-over


Commit: 382d0e9676c2d4a40ce9a1d9422836e26a900330
https://github.com/dreamwidth/dw-free/commit/382d0e9676c2d4a40ce9a1d9422836e26a900330
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/LJ/Web.pm
M htdocs/editjournal.bml

Log Message:
-----------
remove $LJ::COMMON_CODE{'autoradio_check'}

This isn't "common" - it's only used in one place, so just stuff it there.


Commit: 6b554657918274676e9be43730218ab376646d91
https://github.com/dreamwidth/dw-free/commit/6b554657918274676e9be43730218ab376646d91
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/lj-bml-blocks.pl

Log Message:
-----------
BML blocks CHALRESPJS and METACTYPE defined but not used anywhere


Commit: a8c3b91267a3ddb4f041c91d502cc535d02867f0
https://github.com/dreamwidth/dw-free/commit/a8c3b91267a3ddb4f041c91d502cc535d02867f0
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Web.pm
M htdocs/update.bml

Log Message:
-----------
remove $LJ::COMMON_CODE{'chalresp_js'}

This was a one-liner that was only still called in two places.


Commit: eac1b1441078a3d68a83ee3f6edf7043b19900a4
https://github.com/dreamwidth/dw-free/commit/eac1b1441078a3d68a83ee3f6edf7043b19900a4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/bml/scheme/global.look
M htdocs/editjournal.bml
M htdocs/update.bml

Log Message:
-----------
entryformcss? is functionally empty


Commit: db2bada6b8c27168e0cc29c99bdb0553e5b7adda
https://github.com/dreamwidth/dw-free/commit/db2bada6b8c27168e0cc29c99bdb0553e5b7adda
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/bml/scheme/global.look

Log Message:
-----------
more excision of unused BML blocks


Commit: 42ff506d722fad63b2e6e1caf4a1c19f013f8314
https://github.com/dreamwidth/dw-free/commit/42ff506d722fad63b2e6e1caf4a1c19f013f8314
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/DW/External/User.pm

Log Message:
-----------
Align external user icons the same way as site user icons

The function that builds DW site user links is over in LJ/User/Display.pm, and
it sets `vertical-align: text-bottom` in the inline style for the icon. For
consistency, external user links should do the same thing.


Commit: 09f6427379a195b9888ba30ec99c3af1ae36bc78
https://github.com/dreamwidth/dw-free/commit/09f6427379a195b9888ba30ec99c3af1ae36bc78
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M cgi-bin/LJ/Web.pm
M htdocs/admin/priv/index.bml

Log Message:
-----------
remove unused function LJ::Web::no_access_error

Intended to be a lazy developer helper by providing the ability to grant the missing privilege to the user with one click in a dev environment. We don't need this.


Commit: 94ffc403af3158558d25ce6c70e58bc5e01003bf
https://github.com/dreamwidth/dw-free/commit/94ffc403af3158558d25ce6c70e58bc5e01003bf
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M views/components/errors.tt

Log Message:
-----------
add support for style classes other than 'alert' in errors.tt

Still 'alert' by default, but you can pass in a different class name as an argument to the template if you want.


Commit: e80fe2d1c146b14f17a618c8f2dd51d458db95a2
https://github.com/dreamwidth/dw-free/commit/e80fe2d1c146b14f17a618c8f2dd51d458db95a2
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/Priv.pm
R htdocs/admin/priv/index.bml
A views/admin/priv/index.tt
A views/admin/priv/index.tt.text
A views/admin/priv/viewpriv.tt
A views/admin/priv/viewpriv.tt.text
A views/admin/priv/viewuser.tt
A views/admin/priv/viewuser.tt.text

Log Message:
-----------
convert /admin/priv


Commit: f3253382cee72143edba4b3a2d6dd3a733ee7aa4
https://github.com/dreamwidth/dw-free/commit/f3253382cee72143edba4b3a2d6dd3a733ee7aa4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-27 (Sat, 27 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/priv from legacy index


Commit: 37ca99a8bf4905678c2fc2d6e72505ff2b918069
https://github.com/dreamwidth/dw-free/commit/37ca99a8bf4905678c2fc2d6e72505ff2b918069
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/pages/entry/new.js
M views/entry/form.tt

Log Message:
-----------
remove spellcheck from remaining non-legacy pages

This pulls spellcheck elements off the beta Create Entry page and cleans up one remaining setup check from the rendering of journal/quickreply.tt.


Commit: 63f384150db84910cdda60f0a7625b551b82f4ac
https://github.com/dreamwidth/dw-free/commit/63f384150db84910cdda60f0a7625b551b82f4ac
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm

Log Message:
-----------
retidy


Commit: ebe0bcd8cb885b3e1ab47b10e7242770628117fc
https://github.com/dreamwidth/dw-free/commit/ebe0bcd8cb885b3e1ab47b10e7242770628117fc
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/js/pages/entry/new.js

Log Message:
-----------
don't call undefined hashpassword() function in entry/new.js

Just noticed this when testing spellcheck removal. Presumably this function was removed with the recent password code changes, but the function was only called if hasRemote() returned false.

(Who loads /entry/new while logged out? I didn't even know that was allowed.)


Commit: 039702ac666e8cf4c293e70dfa53536834bad980
https://github.com/dreamwidth/dw-free/commit/039702ac666e8cf4c293e70dfa53536834bad980
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/js/pages/entry/new.js

Log Message:
-----------
fix security dropdown state bug related to undefined minsecurity


Commit: 317619ee029f39ecd206cec484e0bfb7fa7c4ef1
https://github.com/dreamwidth/dw-free/commit/317619ee029f39ecd206cec484e0bfb7fa7c4ef1
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/talkscreen.bml

Log Message:
-----------
jQ expects absolute protocol links, page prints relative protocol links

At some point we told LJ::S2::Image_std to start printing relative protocol links, but the JSON generated by talkscreen.bml for use by jquery.commentmanage.js was still using links that included the protocol, which meant that `this.element.find('img[src="'+newData.oldimage+'"]')` would never get a match, and so whenever you clicked on an icon for freezing/unfreezing or screening/unscreening a comment, the icon link would be replaced by a text link instead of another icon link.

ANYWAY this is the fix.


Commit: 2148e55a3e6e7ce992ab5aa42c9ab4a619cd8dd9
https://github.com/dreamwidth/dw-free/commit/2148e55a3e6e7ce992ab5aa42c9ab4a619cd8dd9
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Community.pm
M views/communities/convert.tt.text

Log Message:
-----------
[#2350] fix the other community conversion path

It was simpler to add the one line check than to try and make the paths converge. I also noticed and fixed some errors in the statement immediately preceding the added lines.


Commit: c7aa2572f45d187a0a52960c4c4897e497fd3856
https://github.com/dreamwidth/dw-free/commit/c7aa2572f45d187a0a52960c4c4897e497fd3856
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Console/Command/PrivPackage.pm

Log Message:
-----------
fix uninitialized value warning in priv_package create

Use of uninitialized value $cpkg in concatenation (.) or string at cgi-bin/LJ/Console/Command/PrivPackage.pm line 65.

Only happens when creating a new priv package, because no matching values are found in the database. The $cpkg variable isn't even used in that case.


Commit: 934098e31132720b45b0e2eb04c7648dd7b1c36b
https://github.com/dreamwidth/dw-free/commit/934098e31132720b45b0e2eb04c7648dd7b1c36b
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Priv.pm
M views/admin/priv/viewuser.tt
M views/admin/priv/viewuser.tt.text

Log Message:
-----------
[#1841] include priv packages on /admin/priv page

When granting privileges to a particular user, in addition to the existing dropdown of privileges, I added a second dropdown list of defined priv packages. I decided I liked the look of it better, and it was easier to implement than if I'd smashed the two sets of options into one menu as I had originally proposed. (It was also easier to implement than if I'd tried to do this before encapsulating the logic for granting privileges in the controller.)

This is just for ease of use when granting packages. All other package operations, such as seeing which privileges are included in a package, still require use of the priv_package console command.


Commit: b5749818c5503ccbbcfde2a532f2cd0b6d4a6e9d
https://github.com/dreamwidth/dw-free/commit/b5749818c5503ccbbcfde2a532f2cd0b6d4a6e9d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
LJ::Talk - fix a method call interpolation in post_comment

When I switched that from being a raw hashref access to being a method call, I
forgot that interpolating method calls straight into a string can sometimes be
Bad.


Commit: d24d603a05ee5ad49061263024724b255b32827e
https://github.com/dreamwidth/dw-free/commit/d24d603a05ee5ad49061263024724b255b32827e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Document all reply form POST arguments evar

One of the more outlandishly long comments I've done, but seems justified.


Commit: 7f533b032a79704ca96a23b25c4e746eef83fa93
https://github.com/dreamwidth/dw-free/commit/7f533b032a79704ca96a23b25c4e746eef83fa93
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Remove vestigial hidden fields (basepath, dtid) from talkform

Nothing on the backend ever consumes these, and you can't do a "less options"
post from the talkform back to the quick-reply. (Relatedly: ReplyPage can stop
passing dtid to talkform.)


Commit: 5f8f74ca8e7ba91fb177295ac086a1334a5ac8c1
https://github.com/dreamwidth/dw-free/commit/5f8f74ca8e7ba91fb177295ac086a1334a5ac8c1
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Talkform: Carry over viewing_thread value, if included in POST

Quick-reply uses this field to return you to the exact thread sub-view you were
on when you started replying. And the old previewform used to also respect that
when previewing FROM the QR, due to its mutant practice of copying every
unhandled form field into a hidden input.

Well, that broke when I killed previewform, but this brings it back, and ALSO
brings return-to-thread-view to "more options" posts for the first time.

It doesn't do anything about edit links or no-JS/newtab reply links, yet.


Commit: 73d1a9c842c9b7690e5f6df9457b687175cdeb87
https://github.com/dreamwidth/dw-free/commit/73d1a9c842c9b7690e5f6df9457b687175cdeb87
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
If ReplyPage gets a thread as a GET arg, pass it to talkform

Giving the one from the post args priority, though I can't think of how to make
them conflict.


Commit: 4abded54679bb829c68c5116d13307afedf60b72
https://github.com/dreamwidth/dw-free/commit/4abded54679bb829c68c5116d13307afedf60b72
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/S2/EntryPage.pm

Log Message:
-----------
Add thread to reply/edit links, and ensure consistency when expanding

This lets us return you to the same thread view you were in after you finish
editing a comment (or replying, if you're a no-JS person; we already handle new
comments if you go through the quick-reply).

The deal with `destination_thread` and `js_expand_url` is this: the JS thread
expander works by requesting a _normal HTML page_ for the thread you're trying
to expand, and then finding the comment bodies in it and shimming them into
place in the current page. Without some extra bookkeeping, that results in some
reply/edit links that will redirect you to a foreign thread context if you use
them. So this commit tweaks the URL used by the JS thread expander to include a
note about where the comments will actually be landing, and then we respect that
request when building the edit and reply URLs.


Commit: 3f1e440129df0a2c0a062345a7a92dfd7a12319d
https://github.com/dreamwidth/dw-free/commit/3f1e440129df0a2c0a062345a7a92dfd7a12319d
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/UserHistory.pm
R htdocs/admin/userlog.bml
A views/admin/userlog.tt
A views/admin/userlog.tt.text

Log Message:
-----------
convert /admin/userlog


Commit: 92c6a33f0bad0ac37614dae4f92bd65b8cfa93db
https://github.com/dreamwidth/dw-free/commit/92c6a33f0bad0ac37614dae4f92bd65b8cfa93db
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/UserHistory.pm
M views/admin/userlog.tt.text

Log Message:
-----------
add coverage for newer userlog actions

We never added display messages for screen_set, screen_unset, and siteadmin_email.


Commit: d24b6bc636b04ea44b1788228bc34e22002d994c
https://github.com/dreamwidth/dw-free/commit/d24b6bc636b04ea44b1788228bc34e22002d994c
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M htdocs/scss/skins/_page-layout-hacks.scss

Log Message:
-----------
fix for illegible table header links

I guess putting links in table header cells on Foundation site pages isn't a common thing to do because no one had noticed they looked terrible? This was the easiest way I could figure out to fix it.


Commit: c08848c546a741e2203f6f750b12c09bc14538e4
https://github.com/dreamwidth/dw-free/commit/c08848c546a741e2203f6f750b12c09bc14538e4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/UserHistory.pm
R htdocs/admin/statushistory.bml
A views/admin/statushistory.tt
A views/admin/statushistory.tt.text

Log Message:
-----------
convert /admin/statushistory


Commit: 7ca5074da21867715c3ca4902661ee57df8c9cd4
https://github.com/dreamwidth/dw-free/commit/7ca5074da21867715c3ca4902661ee57df8c9cd4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
fix uninitialized value warning

Every time I tested with a bogus username, I logged this warning from get_userid:

Use of uninitialized value $userid in addition (+) at cgi-bin/LJ/User/Account.pm line 1324.

This fix reproduces the existing behavior without the warning.


Commit: 1d2c9fa6c20c6f7640388b35adcafd419474945d
https://github.com/dreamwidth/dw-free/commit/1d2c9fa6c20c6f7640388b35adcafd419474945d
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/statushistory and /admin/userlog from legacy index


Commit: 970896476e25be8fd5143adea32ccb06ec887eb3
https://github.com/dreamwidth/dw-free/commit/970896476e25be8fd5143adea32ccb06ec887eb3
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin.pm

Log Message:
-----------
retidy


Commit: b466f046d6e814ecbeb7cb1215b0d16569b7de7d
https://github.com/dreamwidth/dw-free/commit/b466f046d6e814ecbeb7cb1215b0d16569b7de7d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/Entry.pm
M views/entry/preview.tt

Log Message:
-----------
Beta create entries page: Improve/update previews

The preview feature of beta create entries was starting to rot, slightly:

- Wasn't loading CSS and JS that journal content expects to have available,
which made things like image shrinking act wrong. Fix: call the same function
that journal pages use to require resources, and use the same res_includes
behavior for the S2 view.
- Template for site skin entry pages was outdated (maybe predated the effort to
move site-skin comments into S2). Fix: update the template. Long-term, it would
be better to figure out how to invoke the siteviews layout from a non-journal
context and just use that (see also: comment previews). But that seemed like a
rabbit hole, and I just needed this out of my way.


Commit: 8855b29935861cebd3ce0a07904a9aecd7b469fa
https://github.com/dreamwidth/dw-free/commit/8855b29935861cebd3ce0a07904a9aecd7b469fa
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M cgi-bin/LJ/Event/NewUserpic.pm
M cgi-bin/LJ/Feed.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/S2/IconsPage.pm
M t/cleaner-event.t
M t/cleaner-markdown.t

Log Message:
-----------
LJ::CleanHTML (and callers) - Minor cleanups

- Stop adding `` tags to long words, this is *extremely* silly. Just use
word-wrap/overflow-wrap in CSS.
- Don't create a new hashref on every call to update_tag
- Remove unused 'linkify' option from some calls


Commit: 4845d9f19aa695b9757b768a7504ce50697fe980
https://github.com/dreamwidth/dw-free/commit/4845d9f19aa695b9757b768a7504ce50697fe980
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
A cgi-bin/DW/Formats.pm
A t/formats.t

Log Message:
-----------
DW::Formats - New helper package for markup formats

This new package isn't used by anything yet, but it sort of serves as a map for
the following commits.

The goal of the coming changes is to introduce *named markup formats* on DW.
We'll use these formats whenever we need to display user-entered body text,
and we'll preserve the format name alongside the source as a permanent record of
how the user expected their markup to be interpreted when they wrote it. This
will give us the freedom to update and change our formatting behaviors as
needed, without vandalizing millions of historical posts or requiring
world-ending database migrations to update old formatting.

STORAGE: Entries and comments both already include an `editor` prop, which will
store the format ID for a given post. Other kinds of body content might be
handled differently as we expand format support. (For example, user bios are
singletons, so their format might be stored as a userprop.) Additionally, we'll
save a user's preferred format for a given content type and use it as the
default in editing UIs.

VERSIONING: Formats are versioned, and any significant change to markup behavior
is now expected to result in a new format name. To keep things manageable,
editing UIs will only offer a limited number of "active" formats at any given
time. (Exception: when editing old content, its current format will be available
in the UI even if it's obsolete.)

USAGE: We'll be using named formats in two ways:

- DISPLAY: Formats will determine the behavior of the HTML cleaner when
preparing content for display. They can affect the behavior of things like line
breaks, special non-standard HTML tags, `[personal profile] mentions`, and more.
- UI: The currently selected format within an editing UI can potentially affect
its behavior and layout. (Whether to initialize or deinitialize the rich text
editor, whether plain-text editing buttons should emit HTML or Markdown, etc.)

The initial set of formats is a codification of the formats DW **already uses,**
which are currently selected by emergent interactions between the
`opt_preformatted` prop, the imported/syndicated status, Secret Glyphs
(`!markdown`), and the editor prop (currently only used in emailed comments).


Commit: b2721e27faca1a68b59b1f71305c336afdd1ba34
https://github.com/dreamwidth/dw-free/commit/b2721e27faca1a68b59b1f71305c336afdd1ba34
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-29 (Mon, 29 Jun 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
LJ::CleanHTML::clean - Add `nodwtags` option (for `html_extra_raw`)

This new option allows the cleaner to skip processing for all special-sauce
DW/LJ tags, like `[Unknown site tag]` and `ExpandRead more... )
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: a195cccfd508f34972e83016ca6e4ba80193c8cb
https://github.com/dreamwidth/dw-free/commit/a195cccfd508f34972e83016ca6e4ba80193c8cb
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-22 (Wed, 22 Jul 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
CleanHTML: rely on DW::Formats for defaults/aliases

This was sort of an artifact of the order I built these in, but anyway: since
Formats has utilities for resolving aliases and such, the HTML cleaner only
really needs to care about the "real" format IDs.

This has no real effect on normal behavior today, but it makes things easier to
maintain, and it makes things behave more predictably in tests. (Notably, fixes
a test failure I recently introduced in t/cleaner-markdown.t by trying to pass
the cleaner an alias that was only defined in Formats.)


Commit: 49baf2dc256e02359ba96bd672646b752b7e4623
https://github.com/dreamwidth/dw-free/commit/49baf2dc256e02359ba96bd672646b752b7e4623
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-22 (Wed, 22 Jul 2020)

Changed paths:
M doc/dependencies-cpanm

Log Message:
-----------
Add Test::MockObject to dependencies-cpanm

Dependency was introduced in #2709.


Compare: https://github.com/dreamwidth/dw-free/compare/a3fd4ad7bf02...49baf2dc256e
Page generated Jul. 9th, 2025 02:11 am
Powered by Dreamwidth Studios