[dreamwidth/dw-free] ae8eb9: Remove ancient JS function that always returns bef...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: ae8eb9ccb8aa5ba7d5b6b4c5693022625d4bdc81
https://github.com/dreamwidth/dw-free/commit/ae8eb9ccb8aa5ba7d5b6b4c5693022625d4bdc81
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-24 (Fri, 24 Jul 2020)

Changed paths:
M htdocs/js/livejournal.js

Log Message:
-----------
Remove ancient JS function that always returns before doing anything

This main body of this function has been dead code since before Mark's 2008
initial import commit. Recently, Firefox started giving "unreachable code after
return statement" warnings for it.

Could just ignore it until the 6alib stuff is all gone for good, but hey,
figured we could all use a good laugh.

[dreamwidth/dw-free] 74374e: Site skins: Tidy up nav bar search form

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 74374ee495a2c5e6f7dc8933fc834da097e2923f
https://github.com/dreamwidth/dw-free/commit/74374ee495a2c5e6f7dc8933fc834da097e2923f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-24 (Fri, 24 Jul 2020)

Changed paths:
M htdocs/scss/skins/_nav.scss

Log Message:
-----------
Site skins: Tidy up nav bar search form

- The height: auto thing seems like a workaround for something that went away
in some Foundation upgrade. Removing it makes the control heights match.
- Inline selects in Foundation need extra side padding to leave room for the
artificial dropdown triangle.


Commit: 85a283ade898b5ac571db4bbcb3e3f5f5107b477
https://github.com/dreamwidth/dw-free/commit/85a283ade898b5ac571db4bbcb3e3f5f5107b477
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-24 (Fri, 24 Jul 2020)

Changed paths:
M htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
Site skins: Revise form control hacks for replies and multiform

A few recent additions that need adjustment, and a few things I never got quite
right on the previous passes.

- I previously styled the "multiform" (multi-comment actions) submit button like
a submit (big and red on Tropo), but on further thought, it's of secondary
importance and doesn't need a big flashing 🚨. Demote it to normal button.
- The multiform button had a frustrating little vertical misalignment with its
associated dropdown. Make the heights match, and line them up nice.
- The new markup controls were a little too fluffy on site skins due to
Foundation's massive button/dropdown styles, so shrink them to the same height
as the icon controls. (This also fixes the quote button not quite matching the
dropdown's height.)
- Make these hacked button styles look a little more consistent with most of the
site skin buttons. (I'd previously missed the little shiny edge at the top.)
- Add some extra side padding to the hacked "inline" dropdowns (icon select,
markup select, multi-comment actions) so that Foundation's fake dropdown
triangle doesn't overlap the text when the longest item is selected.


Commit: 6c030c382e5bfecb29bca36d1120d5b36066b0a6
https://github.com/dreamwidth/dw-free/commit/6c030c382e5bfecb29bca36d1120d5b36066b0a6
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-24 (Fri, 24 Jul 2020)

Changed paths:
M htdocs/scss/skins/_nav.scss
M htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
Use lopsided padding for selects so they don't LOOK lopsided

...since that dropdown arrow isn't properly part of the text zone.


Commit: 95cec0339cbc3eb4705da39d897bd9fe4d473454
https://github.com/dreamwidth/dw-free/commit/95cec0339cbc3eb4705da39d897bd9fe4d473454
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-24 (Fri, 24 Jul 2020)

Changed paths:
M htdocs/scss/skins/_nav.scss
M htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
Set select padding to 24px to match the size of the fake arrow svg


Compare: https://github.com/dreamwidth/dw-free/compare/ae8eb9ccb8aa...95cec0339cbc