[dreamwidth/dw-free] fcdd42: Catch some remaining MD5 gunk

[github]

Branch: refs/heads/code-tour
Home: https://github.com/dreamwidth/dw-free
Commit: fcdd4268784cb44615177929668f2f88eb159f25
https://github.com/dreamwidth/dw-free/commit/fcdd4268784cb44615177929668f2f88eb159f25
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-21 (Tue, 21 Apr 2020)

Changed paths:
M cgi-bin/LJ/S2.pm
M htdocs/update.bml
M schemes/common.tt

Log Message:
-----------
Catch some remaining MD5 gunk

- One attempt to require a missing JS file (breaks journal pages due to 404)
- Stop requiring MD5 library in places that don't use it
- Guarantee MD5 library is available for the two places that actually still call
the `MD5()` function (xpost.js and jquery.crosspost.js)


Commit: f2ad720c85e2cf2507b569a6a9c7d466a29eb587
https://github.com/dreamwidth/dw-free/commit/f2ad720c85e2cf2507b569a6a9c7d466a29eb587
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-24 (Fri, 24 Apr 2020)

Changed paths:
M bin/upgrading/d10-passwords.pl
M bin/upgrading/update-db-general.pl
A cgi-bin/DW/Auth/Password.pm
M cgi-bin/LJ/Global/Defaults.pm
M cgi-bin/LJ/User/Login.pm
M doc/dependencies-cpanm

Log Message:
-----------
Add password 'peppering'

After discussion with a security engineering friend of mine, this is
take two at the secure password storage approach. Now, we are applying a
'pepper' on the web server, before we write to the database.

The advantage of this is that a database exfiltration does not result in
useful data (when it comes to passwords). In order to get useful data,
you need to get data off of the webserver memory/filesystem AND from the
database, which raises the bar.

The chosen peppering solution is symmetric encryption, which enables us
to do pepper rotation if we ever believe that our pepper key was
compromised somehow.

This also re-introduces momijizukamori's schema/revision/version
column, so we can change how passwords are stored in the future.
Additionally this pulls most of the functionality out into
DW::Auth::Password which will let us isolate things better and ensure
that it's easy to audit credential management code.


Commit: 3923237f135f5604127402bc2653cacddc531518
https://github.com/dreamwidth/dw-free/commit/3923237f135f5604127402bc2653cacddc531518
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-24 (Fri, 24 Apr 2020)

Changed paths:
M cgi-bin/DW/Auth/Password.pm
M cgi-bin/LJ/User/Login.pm

Log Message:
-----------
Tidy, sigh


Commit: a72e2bb2d37ccf695cf5c96aadaa7185c63628b3
https://github.com/dreamwidth/dw-free/commit/a72e2bb2d37ccf695cf5c96aadaa7185c63628b3
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-24 (Fri, 24 Apr 2020)

Changed paths:
M cgi-bin/DW/Auth/Password.pm
M cgi-bin/LJ/Global/Constants.pm
A t/auth-password.t

Log Message:
-----------
Refactor slightly, add tests


Commit: fafd92d0747eb65b892c1106a3955eb928322394
https://github.com/dreamwidth/dw-free/commit/fafd92d0747eb65b892c1106a3955eb928322394
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-24 (Fri, 24 Apr 2020)

Changed paths:
M t/auth-password.t

Log Message:
-----------
Fix test count


Commit: c61bd094f36f46c89b75c0c109c39c5a32481bf9
https://github.com/dreamwidth/dw-free/commit/c61bd094f36f46c89b75c0c109c39c5a32481bf9
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-24 (Fri, 24 Apr 2020)

Changed paths:
M bin/upgrading/update-db-general.pl
A cgi-bin/DW/Auth/Helpers.pm
M cgi-bin/DW/Auth/Password.pm
A cgi-bin/DW/Auth/TOTP.pm
M cgi-bin/DW/Controller/Settings.pm
A cgi-bin/DW/Setting/Display/Manage2FA.pm
M cgi-bin/DW/TaskQueue/SQS.pm
M cgi-bin/LJ/User/Login.pm
M doc/dependencies-cpanm
M htdocs/manage/settings/index.bml
A t/auth-helpers.t
M t/auth-password.t
A t/auth-totp.t
M views/beta.tt.text
M views/settings/changepassword.tt
A views/settings/manage2fa/disable.tt
A views/settings/manage2fa/index-disabled.tt
A views/settings/manage2fa/index-enabled.tt
A views/settings/manage2fa/setup.tt

Log Message:
-----------
Initial pass at TOTP (2fa) (#2624)

* Initial pass at TOTP (2fa)

This implements support for configuring 2fa using TOTP codes. At the
moment, this is not actually used in our authentication flows, but it at
least is the plumbing to do so.

TODO:
* recover account with recovery codes
* admin tools for manipulating 2fa
* support tools for showing 2fa status
* actual authentication integration for login
* think about all the other flows we use passwords?
* ???
* profit!

* Update to new DW::Auth::TOTP format

* Put 2FA behind beta feature

* wtb precommit tidy


Commit: df4f4e10ed473133c51deb6e75152627d48088c6
https://github.com/dreamwidth/dw-free/commit/df4f4e10ed473133c51deb6e75152627d48088c6
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-25 (Sat, 25 Apr 2020)

Changed paths:
A cgi-bin/DW/Auth/Challenge.pm
M cgi-bin/DW/Auth/Password.pm
M cgi-bin/DW/Captcha/textCAPTCHA.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/Journal/Protected.pm
M cgi-bin/DW/Template/Plugin/SiteScheme.pm
M cgi-bin/LJ/Auth.pm
M cgi-bin/LJ/CreatePage.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/User/Login.pm
M cgi-bin/LJ/Web.pm
M cgi-bin/ljlib.pl
M htdocs/admin/impersonate.bml
M htdocs/login.bml
M htdocs/mobile/login.bml
A t/auth-challenge.t
M t/auth-password.t
M t/post.t

Log Message:
-----------
Move challenge to DW::Auth::Challenge

As part of cleaning up authentication flows to live in one place, I've
moved challenge generation/checking into a submodule of DW::Auth. Also
wrote some crappy unit tests.


Commit: 18d53d5fc1310ea8e6ca3cba1b36395414eb67aa
https://github.com/dreamwidth/dw-free/commit/18d53d5fc1310ea8e6ca3cba1b36395414eb67aa
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-25 (Sat, 25 Apr 2020)

Changed paths:
M bin/upgrading/d10-passwords.pl
M cgi-bin/DW/API/Key.pm
M cgi-bin/DW/Auth/Challenge.pm
M cgi-bin/DW/Auth/Password.pm
M cgi-bin/LJ/Auth.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/User/Login.pm
M t/auth-password.t

Log Message:
-----------
Support API keys for protocol auth

This provides a path forward for clients like Semagic that haven't been
updated in years, but we should still support them.

Given that we're moving to using better practice password storage, we
can't continue to use passwords. Instead of building 'app password'
functionality like some services have, we're going to be using our API
keys for now.

To use Semagic after we switch to the new password system, you will need
to generate an API key and use that as your password.


Commit: f842119666404a47978d5ee0aa3671d29bf6b7b2
https://github.com/dreamwidth/dw-free/commit/f842119666404a47978d5ee0aa3671d29bf6b7b2
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-26 (Sun, 26 Apr 2020)

Changed paths:
M bin/upgrading/update-db-general.pl
M htdocs/manage/circle/invite.bml

Log Message:
-----------
Fix missing comma, commit from prod

Remove the send-email functionality of invite, which was being used to
spam. We should just remove this feature entirely -- if you want to
invite people, you should contact them out of band manually. I don't
want Dreamwidth spamming people.


Commit: 91a562386e3d0089c728f1d451196d52b1382ca1
https://github.com/dreamwidth/dw-free/commit/91a562386e3d0089c728f1d451196d52b1382ca1
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-26 (Sun, 26 Apr 2020)

Changed paths:
M cgi-bin/DW/TaskQueue.pm

Log Message:
-----------
Fix undef dereference

When I made local dev possible, I broke receive in the empty case.
Fixes.


Commit: 88a35d5e6c0ef3c9f498aed5e1748f3a16e92331
https://github.com/dreamwidth/dw-free/commit/88a35d5e6c0ef3c9f498aed5e1748f3a16e92331
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-26 (Sun, 26 Apr 2020)

Changed paths:
M bin/worker/metrics-emitter

Log Message:
-----------
Fix metrics emitter


Commit: 84cfef03ac315a8a32c4dd4d1d96a94d233b2375
https://github.com/dreamwidth/dw-free/commit/84cfef03ac315a8a32c4dd4d1d96a94d233b2375
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-26 (Sun, 26 Apr 2020)

Changed paths:
M cgi-bin/DW/API/Key.pm
M cgi-bin/DW/Auth.pm
M cgi-bin/DW/Controller/Auth.pm
M cgi-bin/LJ/CleanHTML.pm
M cgi-bin/LJ/Protocol.pm
M doc/dependencies-cpanm

Log Message:
-----------
Hotfixes


Commit: a8e7b5632219969ef343ee02ca2732d7e7f19388
https://github.com/dreamwidth/dw-free/commit/a8e7b5632219969ef343ee02ca2732d7e7f19388
Author: Mark Smith <mark@qq.is>
Date: 2020-04-27 (Mon, 27 Apr 2020)

Changed paths:
R etc/kubernetes/workers/generated/xpost.yaml
M etc/kubernetes/workers/regen-workers.pl

Log Message:
-----------
Remove xpost from k8s


Commit: d904c4d3352e1816472766eb0ddd6f173b100c56
https://github.com/dreamwidth/dw-free/commit/d904c4d3352e1816472766eb0ddd6f173b100c56
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)

Changed paths:
M htdocs/js/jquery.talkform.js

Log Message:
-----------
(#2629) Fix error when commenting anonymous with browser-saved password (#2635)


Commit: f36d002c0afdcae1d941e512225311f6e5e4a080
https://github.com/dreamwidth/dw-free/commit/f36d002c0afdcae1d941e512225311f6e5e4a080
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)

Changed paths:
M htdocs/scss/skins/_entry-styles.scss

Log Message:
-----------
s2foundation: Fix duplicate "Thread" link in comment footer (#2636)


Commit: 763ee970c2e20a78693dfd2ffc3671dd1369bb36
https://github.com/dreamwidth/dw-free/commit/763ee970c2e20a78693dfd2ffc3671dd1369bb36
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)

Changed paths:
M cgi-bin/LJ/User/Display.pm

Log Message:
-----------
(#2632) Stop mutating opts hashrefs in `ljuser` and `ljuser_display`

This was causing every user to look deleted within a given post after at least
one deleted user was mentioned.


Commit: 0fa09a8b7859bd94b50395468de635edbec3001a
https://github.com/dreamwidth/dw-free/commit/0fa09a8b7859bd94b50395468de635edbec3001a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
DW::External::User::ljuser_display takes an opts hash, not an opts hashref

This actually might have been working fine, depending on your version of perl
(direct key access on a hashref, which iirc they were considering at some point
and implemented as experimental), but it's definitely deviant and wrong.


Commit: c29f257926fc8819bedd47638d306953b55e1b03
https://github.com/dreamwidth/dw-free/commit/c29f257926fc8819bedd47638d306953b55e1b03
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-04-28 (Tue, 28 Apr 2020)

Changed paths:
M cgi-bin/DW/API/Key.pm

Log Message:
-----------
Tidy


Commit: 1f1d9e54a78476f797951a016663a7b4ccae076d
https://github.com/dreamwidth/dw-free/commit/1f1d9e54a78476f797951a016663a7b4ccae076d
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-03 (Sun, 03 May 2020)

Changed paths:
M bin/checkconfig.pl

Log Message:
-----------
improvements to bin/checkconfig.pl

This takes an existing stub of an idea -- making sure that etc/config-local.pl exists -- and expands it to include config.pl and config-private.pl, as well as the configs in t/ for testing. If the files exist, they are also evaluated to make sure they compile properly (no missing punctuation).

Having this would have saved me approximately two hours of pain yesterday.


Commit: 1f15f63db6b3c3f1e6398cc8405c3dbf7aba4ede
https://github.com/dreamwidth/dw-free/commit/1f15f63db6b3c3f1e6398cc8405c3dbf7aba4ede
Author: Jen <kareila@dreamwidth.org>
Date: 2020-05-03 (Sun, 03 May 2020)

Changed paths:
M cgi-bin/DW/Auth/TOTP.pm
M cgi-bin/LJ/Console/Command/ChangeJournalType.pm
M t/atom-post.t
M t/auth-password.t
M t/auth-totp.t
M t/console-changecommunityadmin.t
M t/console-changejournaltype.t
M t/console-reset.t
M t/proto-post-edit-roundtrip.t
M t/rename.t

Log Message:
-----------
[#2639] fix or disable broken tests and related functionality (#2642)

* fix syntax errors

* remove unneeded calls to old password method

t/console-changecommunityadmin.t: There was a test to make sure the password of a community was blank after transferring ownership, but communities haven't been allowed to have passwords in a very long time.

t/proto-post-edit-roundtrip.t: Use string variables and the check_password method instead.

t/console-reset.t: Use a known password and the check_password method instead.

* disable broken functionality for now

The change_journal_type console command won't work until we decide how to update the expected behavior, which has been to assign the password of the community's owner to the affected journal when changing it from a community to a personal journal. For now, the console command is disabled and all the relevant tests are skipped.

As for the t/atom-post.t file, it seems linked to AtomAPI authentication, which is a rarely used feature of the site. Skipping these tests for now but not sure if updating or removing is the best path forward.

* remove password-matching test from t/rename.t

Since it is no longer possible for us to test that two users have the same password, we no longer enforce this as a constraint when deciding if a rename is allowed. Now we only make sure that the authenticated email addresses on the two accounts match.

* tidy


Commit: 4fa9048155e5d89724d0ed1075431110b340eaba
https://github.com/dreamwidth/dw-free/commit/4fa9048155e5d89724d0ed1075431110b340eaba
Author: Jen <kareila@dreamwidth.org>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M etc/config.pl.example

Log Message:
-----------
change default journal style on new installations (#2645)

I couldn't find an issue open for this but I know we've talked about it on Discord: the default journal style for over a decade has been 'negatives/black', which isn't TR-based and doesn't support the newer features present in most other journal styles.

This changes the default style defined in config.pl.example to 'ciel/indil' which I picked because it wasn't nonfree and seemed pleasantly neutral. I also didn't want to pick the same default style that we have been using in production ('practicality/neutralgood') because I thought that might be too much of the same thing across different sites.

This will only affect future installations that don't have an existing config.pl file.


Commit: 6c6dee344b458e9f2c02c4b615daeabeb1d73310
https://github.com/dreamwidth/dw-free/commit/6c6dee344b458e9f2c02c4b615daeabeb1d73310
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm
M htdocs/talkpost.bml.text
M views/journal/quickreply.tt
M views/journal/talkform.tt

Log Message:
-----------
Keyboard: remove invisible tabbable link in reply forms

Inserting an invisible control with destructive effects into a form's tab order:
not even once™.


Commit: 34e13fd62872de2e087184139db588230c2d1a59
https://github.com/dreamwidth/dw-free/commit/34e13fd62872de2e087184139db588230c2d1a59
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/scss/components/icon-browser.scss

Log Message:
-----------
Jank: stop animating thickness changes in icon browser

An interesting idea, but it always looked gross. My bad!


Commit: b9e8a41e9d5bb545beeac1716803c249bafd6885
https://github.com/dreamwidth/dw-free/commit/b9e8a41e9d5bb545beeac1716803c249bafd6885
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/scss/components/icon-browser.scss
M views/components/icon-browser.tt

Log Message:
-----------
Keyboard: Improve icon browser top controls

- Shift the logical order around so that you can tab directly from "search" to
the icon chooser controls, without having to tab through the display controls
first. (Although at the moment, tabbing into the icons doesn't work.) The
display controls are used more rarely than the icons themselves, so they
shouldn't act as a roadblock for keyboard likers.

Keeps current visual layout on modern browsers, but shifts things around a bit
on obsolete ones.
- Mark display controls as buttons (for accessibility), style them like the
icon keywords (for coherency), tighten up their labels (for concision).


Commit: adda4a817e3c3f7d7199beaee7cd8bb1bf5e1561
https://github.com/dreamwidth/dw-free/commit/adda4a817e3c3f7d7199beaee7cd8bb1bf5e1561
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js

Log Message:
-----------
Remove something weird in icon browser JS

This looks like it was detritus from a wild debugging spree. I'll stipulate that
that issue might still be relevant (who knows), but the hack isn't necessary in
this spot, and it interferes with some other stuff that needs doing.


Commit: 7bb6f2d2db6b43c2768145b49e938156f2ed8939
https://github.com/dreamwidth/dw-free/commit/7bb6f2d2db6b43c2768145b49e938156f2ed8939
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js

Log Message:
-----------
Keyboard: Restore reply form tab position when icon browser exits

The icon browser's div lives at the bottom of the body element, so when its
controls lose focus, the tab position lands miles away from the reply form
you're trying to type in. This puts it back somewhere useful -- specifically,
on the icon menu, which is the control right after the browse button you just
finished using.


Commit: 502b64a46b73cdbf7092887fd19ba5169a8a86a9
https://github.com/dreamwidth/dw-free/commit/502b64a46b73cdbf7092887fd19ba5169a8a86a9
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js

Log Message:
-----------
Keyboard: Mark icon browser controls as buttons

This enables tab-navigating through the icons and keywords, and provides useful
semantic information to assistive tools. Mind, you can't yet DO anything
interesting once you've tabbed to an icon, since enter-to-select is busted.


Commit: d6037cea22bae82f406e01507c3eb12b8d79ab17
https://github.com/dreamwidth/dw-free/commit/d6037cea22bae82f406e01507c3eb12b8d79ab17
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js

Log Message:
-----------
Simplify and improve icon browser's filter function

Previous implementation stashed a backup of the main element and then sprayed
duplicated objects all over the place. That did weird shit with the selected
icon state, which was untenable if any other part of the component cared about
said state. Anyway:

- Keep the set of elements stable; just hide and reveal stuff.
- De-select the selected item if it becomes excluded from the current search.
(Otherwise the browser could have an invisible item selected. 👻)
- Stop spamming the console with forgotten debug info on every keystroke.


Commit: bd3e6795d62568fbdb1464534964ca51183c8804
https://github.com/dreamwidth/dw-free/commit/bd3e6795d62568fbdb1464534964ca51183c8804
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js

Log Message:
-----------
Keyboard: Reliably focus search field when summoning icon browser

It looks like this was the intended behavior, but it was only being invoked the
first time the browser was summoned, not subsequent times. (And sometimes not
even then, because the `open` handler maybe has some kind of race condition for
focus.)


Commit: 5d73bd7b2222fe95874804c18023b9658d127b1a
https://github.com/dreamwidth/dw-free/commit/5d73bd7b2222fe95874804c18023b9658d127b1a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js

Log Message:
-----------
Keyboard: Fix icon browser's enter-to-select

This was somewhat broken, for several reasons. Now you can keyboard navigate the
whole browser.

- When tabbed to an icon or keyword, enter clicks it.
- In the search field, enter confirms the currently selected icon, for going
fastfast when you know the exact string that will filter to one icon.
- Add slash-to-search for all u PoWeR uSeRs out there. 🛹
- Guts: ignore deprecated KeyboardEvent.keyCode prop if you're not retrocomputing. 💾


Commit: 446a459f664a166a2aee5144c98095e055b40f24
https://github.com/dreamwidth/dw-free/commit/446a459f664a166a2aee5144c98095e055b40f24
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M htdocs/js/components/jquery.icon-browser.js
M htdocs/scss/components/icon-browser.scss
M views/components/icon-browser.tt

Log Message:
-----------
Clean up icon browser top controls, clarify interactions

A moderate redesign for the beta icon browser.

- Spawn the "select" button right next to the active icon, so "tap twice" isn't
crucial anymore. (No select button when nothing's selected.)
- On modern browsers (grid = yes), lose that clunky keywords menu in the
top controls. Instead:
- If meta text = yes, use that.
- If meta text = no, spawn a keywords menu right below the selected icon.
Sort of a just-in-time version of the meta text = yes experience, but
eating less vertical space thx to grid. Since the context is clear, the
menu doesn't need explanatory text.

Obsolete browsers get the new confirm button, but keep current keyword behavior.


Commit: f7a066091f76e43356ad498bf7868aaf9a0ee249
https://github.com/dreamwidth/dw-free/commit/f7a066091f76e43356ad498bf7868aaf9a0ee249
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)

Changed paths:
M views/journal/quickreply.tt
M views/journal/talkform.tt

Log Message:
-----------
Fix embarrassing `ml` mistake

I meant to remove the extra arguments to the `ml` filter, but just removed the
whole thing.


Commit: 122368ee4a72e5011107c6aeaeccd8f7d0e59b0c
https://github.com/dreamwidth/dw-free/commit/122368ee4a72e5011107c6aeaeccd8f7d0e59b0c
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R htdocs/export.bml.text
M views/export/index.tt
A views/export/index.tt.text

Log Message:
-----------
[#2464] htdocs/export.bml.text -> views/export/index.tt.text


Commit: 35e2acda932234f674387c1830d3463696979893
https://github.com/dreamwidth/dw-free/commit/35e2acda932234f674387c1830d3463696979893
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Redirect.pm
R htdocs/go.bml.text

Log Message:
-----------
[#2464] move go.bml.text strings into en.dat


Commit: 99b837c15f731b29ad881c1ccf81987e97e7d493
https://github.com/dreamwidth/dw-free/commit/99b837c15f731b29ad881c1ccf81987e97e7d493
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/Apache/LiveJournal.pm
R htdocs/logout.bml.text

Log Message:
-----------
[#2464] remove htdocs/logout.bml.text

Looks like when logout.bml was replaced by views/auth/logout.tt, the new template didn't bother with English stripping, so these strings all fell by the wayside.

While looking for occurrences of logout.bml in the code, I noticed a link in Apache/LiveJournal.pm and changed it to drop the bml suffix from the page.


Commit: 5ea1ea6919f5a4d268f5ba81be2c4d8d8d3dc3b8
https://github.com/dreamwidth/dw-free/commit/5ea1ea6919f5a4d268f5ba81be2c4d8d8d3dc3b8
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M htdocs/talkpost.bml.text
M htdocs/update.bml.text

Log Message:
-----------
[#2464] use global string entryform.opt.defpic instead of local versions


Commit: 7edd956148f6b41ffe5ee16a16450105cce0512e
https://github.com/dreamwidth/dw-free/commit/7edd956148f6b41ffe5ee16a16450105cce0512e
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/LJ/Talk.pm
M htdocs/talkpost.bml.text
M views/journal/quickreply.tt
M views/journal/talkform.tt
A views/journal/talkform.tt.text

Log Message:
-----------
[#2464] move active talkpost.bml.text strings into talkform.tt.text


Commit: 65953c7b9d7425b5e3ba185e40a12471ab970907
https://github.com/dreamwidth/dw-free/commit/65953c7b9d7425b5e3ba185e40a12471ab970907
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M htdocs/talkpost.bml.text

Log Message:
-----------
[#2464] remove unused strings from talkpost.bml.text

This retains four strings currently used in talkpost_do.bml, which
is in the process of being converted away from BML, so I'm leaving
those alone until that process is finished.


Commit: 57fae7d66903c4d0d4d59c2da825334b880bde14
https://github.com/dreamwidth/dw-free/commit/57fae7d66903c4d0d4d59c2da825334b880bde14
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Comments.pm
M cgi-bin/LJ/Talk.pm
M htdocs/talkread.bml.text
M views/journal/quickreply.tt
A views/journal/quickreply.tt.text
M views/journal/talkform.tt.text

Log Message:
-----------
[#2464] move active talkread.bml.text strings into quickreply.tt.text

Also moves a generic talkread string into en.dat, even though it's in a comment.


Commit: 8c6acc00fa54a5645308f82f5e6e8ae23bfa8723
https://github.com/dreamwidth/dw-free/commit/8c6acc00fa54a5645308f82f5e6e8ae23bfa8723
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R htdocs/talkread.bml.text

Log Message:
-----------
[#2464] remove unused strings from talkread.bml.text


Commit: 52047e29843b976c79b12b02f5c98701aced3c96
https://github.com/dreamwidth/dw-free/commit/52047e29843b976c79b12b02f5c98701aced3c96
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/RPC/MiscLegacy.pm
R htdocs/community/join.bml.text

Log Message:
-----------
[#2464] remove community/join.bml.text


Commit: 71a949b2d79ab93a52b5e028b5fb9a781bb02d9f
https://github.com/dreamwidth/dw-free/commit/71a949b2d79ab93a52b5e028b5fb9a781bb02d9f
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/LJ/Community.pm
R htdocs/community/manage.bml.text

Log Message:
-----------
[#2464] remove community/manage.bml.text

Some strings used in cgi-bin/LJ/Community.pm were moved into en.dat.


Commit: 5e4ac0150155ebae0220ecbc75642ef238399e01
https://github.com/dreamwidth/dw-free/commit/5e4ac0150155ebae0220ecbc75642ef238399e01
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R htdocs/community/member.bml.text
M htdocs/manage/banusers.bml
M htdocs/manage/banusers.bml.text

Log Message:
-----------
[#2464] remove community/member.bml.text

Fun fact, the old page was community/members [plural], so this text file didn't even match the page name.


Commit: bf84f3eecfa13bafaf8f90ef34747b0da551ae2c
https://github.com/dreamwidth/dw-free/commit/bf84f3eecfa13bafaf8f90ef34747b0da551ae2c
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R htdocs/community/transfer.bml.text

Log Message:
-----------
[#2464] remove community/transfer.bml.text


Commit: b2b936a22f117ce22e5621bdf20f450ad3b3663c
https://github.com/dreamwidth/dw-free/commit/b2b936a22f117ce22e5621bdf20f450ad3b3663c
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/js/pages/entry/new.js

Log Message:
-----------
Fix date/time picker buttons in beta create entries page


Commit: 988070d1794a831497504559eb91747426816c3a
https://github.com/dreamwidth/dw-free/commit/988070d1794a831497504559eb91747426816c3a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/components/foundation-custom/_panels.scss
M htdocs/scss/skins/_entry-styles.scss
M htdocs/scss/skins/_skin-colors.scss

Log Message:
-----------
s2foundation: Use a variable for screened comment color

This still defaults to the callout panel background color, but can be
set independently now.


Commit: f72fcf44ec75baa0583711c339191120ff767303
https://github.com/dreamwidth/dw-free/commit/f72fcf44ec75baa0583711c339191120ff767303
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_entry-styles.scss

Log Message:
-----------
s2foundation: Comments should clear the previous comment's floats


Commit: e062e8d4faffe0dba55c150ff09d723fa2b2670e
https://github.com/dreamwidth/dw-free/commit/e062e8d4faffe0dba55c150ff09d723fa2b2670e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_compatibility-styles.scss

Log Message:
-----------
s2foundation: Add bottom margin for action box, let border color survive 'unset'


Commit: 4222075c260613b67ac2b2f3b0c22b46eca2a13e
https://github.com/dreamwidth/dw-free/commit/4222075c260613b67ac2b2f3b0c22b46eca2a13e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_entry-styles.scss
M htdocs/scss/skins/_global-styles.scss
A htdocs/scss/skins/_journal-typography.scss

Log Message:
-----------
s2foundation: Split journal typography out from other entry styles


Commit: c53da44f35b0c270823245a2d546a434ed0dfc66
https://github.com/dreamwidth/dw-free/commit/c53da44f35b0c270823245a2d546a434ed0dfc66
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_entry-styles.scss
M htdocs/scss/skins/_global-styles.scss
A htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
s2foundation: Split reply form styles out from other entry styles


Commit: 065dd934dc3edf2fedd760e03ee626326a2ece4e
https://github.com/dreamwidth/dw-free/commit/065dd934dc3edf2fedd760e03ee626326a2ece4e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_icons-page.scss
M htdocs/scss/skins/_journal-typography.scss

Log Message:
-----------
s2foundation: Make base font size for journal content configurable


Commit: 8735ad8115df1cc948d07159232ae21595518c36
https://github.com/dreamwidth/dw-free/commit/8735ad8115df1cc948d07159232ae21595518c36
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_journal-typography.scss

Log Message:
-----------
s2foundation: Fix code block display


Commit: 9b5ec5a5c757203d5e5240e50eb8998da8ee4664
https://github.com/dreamwidth/dw-free/commit/9b5ec5a5c757203d5e5240e50eb8998da8ee4664
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
s2foundation: Fix unresizable textarea in reply form


Commit: b0fe3987156b6bbc9c85e6b007385bccb64154c3
https://github.com/dreamwidth/dw-free/commit/b0fe3987156b6bbc9c85e6b007385bccb64154c3
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
s2foundation: Fix tiny ljuser span in quick-reply


Commit: 7a64e3e356f9552099730ac61146a3a38b890950
https://github.com/dreamwidth/dw-free/commit/7a64e3e356f9552099730ac61146a3a38b890950
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_entry-styles.scss

Log Message:
-----------
Lynx-proof the styles for journal content

- Explicitly include some properties we rely on from foundation defaults.
- Split some color props so they allow `unset`.


Commit: 94a1b1528f70c112a207f572b787ff219f9c1bac
https://github.com/dreamwidth/dw-free/commit/94a1b1528f70c112a207f572b787ff219f9c1bac
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/components/collapse.scss
M htdocs/scss/components/fancy-select.scss
M htdocs/scss/pages/entry/new.scss
M views/entry/module-age_restriction.tt

Log Message:
-----------
Lynx-proof the beta create entries page

- Explicitly include some Foundation default styles it relies on.
- Hide unnecessary styles from Lynx by tying them to the `#canvas` wrapper div
that Lynx omits.
- Shrink a rowdy over-long text input.
- Teach the fancy-select component how to de-evolve. Are we not men????


Commit: 5b688d5719ee6c683320a99571169ded9a61334d
https://github.com/dreamwidth/dw-free/commit/5b688d5719ee6c683320a99571169ded9a61334d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/lynx.scss

Log Message:
-----------
Rehabilitate the Foundation version of Lynx skin

- Switch to foundation_minimal, which is also used by journal styles.
- Don't import the global styles wrapper SCSS; only import what's absolutely
necessary.
- Occasionally use special `unset` CSS value to defer to browser defaults.


Commit: f7efc3e8f7c370c87534a339b1fcb0fee1934280
https://github.com/dreamwidth/dw-free/commit/f7efc3e8f7c370c87534a339b1fcb0fee1934280
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M views/components/icon-button-decorative.tt
M views/components/icon-button.tt

Log Message:
-----------
Icon button components: default to type="button"

``s default to type="submit", so without this, clicking the date picker
buttons in the beta create entries page with JS disabled will post your WIP
entry immediately.


Commit: 78e434b60eab24855a55ca63dd3e27694dac6471
https://github.com/dreamwidth/dw-free/commit/78e434b60eab24855a55ca63dd3e27694dac6471
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/pages/entry/new.scss

Log Message:
-----------
Beta create entries: fix toolbar item spacing

Without JS there's no icons, so it runs together into "create poll settings."
Also, include the assumed text-align: right for lynx.


Commit: 15f2e892c943239e5a5c5d0a0fb21b44373d8b4f
https://github.com/dreamwidth/dw-free/commit/15f2e892c943239e5a5c5d0a0fb21b44373d8b4f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M cgi-bin/LJ/S2.pm

Log Message:
-----------
Add an ID to the multiform submit button

Otherwise there's no good way to target it for styling.


Commit: 5be21d2bae42d1f5bcafbcc944ad92ae0d9afd12
https://github.com/dreamwidth/dw-free/commit/5be21d2bae42d1f5bcafbcc944ad92ae0d9afd12
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/scss/skins/_reply-form-styles.scss

Log Message:
-----------
s2foundation: style hack for multiform submit button


Commit: 49db4ddea8fdec049f5c6424b15444156b18961f
https://github.com/dreamwidth/dw-free/commit/49db4ddea8fdec049f5c6424b15444156b18961f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/js/jquery.cuttag-ajax.js

Log Message:
-----------
Keep cuttag toggle images from getting tiny on some styles

In foundation site skins or in journal styles that set box-sizing: border-box,
the cuttag triangles are too itty-bitty, since the .2em padding on each side gets
subtracted from the 1em base size. This makes the sizing expectations
explicit instead of just expecting we're always landing in a content-box world.


Commit: 434516473f84ccd38e32b7330d45a6f0aa28700b
https://github.com/dreamwidth/dw-free/commit/434516473f84ccd38e32b7330d45a6f0aa28700b
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M htdocs/js/jquery.cuttag-ajax.js

Log Message:
-----------
Set vertical-align: text-bottom for cuttag triangles

In many styles, these float away to an awkward position. Text-bottom seems correct,
since these triangles are directly associated with a line of text and are sized
to match the font.


Commit: 6b0fae4ce39b2dcb9f74fa718835fff6071f7993
https://github.com/dreamwidth/dw-free/commit/6b0fae4ce39b2dcb9f74fa718835fff6071f7993
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M schemes/lynx.tt

Log Message:
-----------
Lynx: add meta content-type tag to fix mojibake

Unicode is busted on Lynx skin without this.


Commit: 12bf9ab1e9377898a57220e116e35fa66bc9476d
https://github.com/dreamwidth/dw-free/commit/12bf9ab1e9377898a57220e116e35fa66bc9476d
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M doc/dependencies-cpanm

Log Message:
-----------
require minimum version 0.015 of Params::Classify


Commit: 97b5722150ea3a830d57d2989f5e0ad9d5b9334a
https://github.com/dreamwidth/dw-free/commit/97b5722150ea3a830d57d2989f5e0ad9d5b9334a
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Misc.pm
R htdocs/site/opensource.bml
R htdocs/site/opensource.bml.text
A views/site/opensource.tt
A views/site/opensource.tt.text

Log Message:
-----------
convert site/opensource


Commit: f58d422c9e28685cd0cb5398f5180d6839821299
https://github.com/dreamwidth/dw-free/commit/f58d422c9e28685cd0cb5398f5180d6839821299
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Misc.pm
M cgi-bin/LJ/Web.pm
R htdocs/doc/s2/index.bml
R htdocs/doc/s2/index.bml.text
A views/doc/s2/index.tt
A views/doc/s2/index.tt.text

Log Message:
-----------
convert doc/s2


Commit: bc7ac6532e8c16ae9b4f7b39bbefc7f09cc8d477
https://github.com/dreamwidth/dw-free/commit/bc7ac6532e8c16ae9b4f7b39bbefc7f09cc8d477
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
A cgi-bin/DW/Controller/Tools.pm
R htdocs/tools/comment_crosslinks.bml
A views/tools/comment_crosslinks.tt

Log Message:
-----------
convert tools/comment_crosslinks


Commit: d6984e89e5345a4da3a07f8342ec078e59593503
https://github.com/dreamwidth/dw-free/commit/d6984e89e5345a4da3a07f8342ec078e59593503
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Importer.pm
M cgi-bin/DW/Controller/Misc.pm
M cgi-bin/DW/Controller/Tools.pm
R cgi-bin/LJ/Widget/ImportChooseData.pm
R cgi-bin/LJ/Widget/ImportChooseSource.pm
R cgi-bin/LJ/Widget/ImportConfirm.pm
R cgi-bin/LJ/Widget/ImportQueueStatus.pm
R cgi-bin/LJ/Widget/ImportStatus.pm
M htdocs/stc/importer.css
R htdocs/tools/importer.bml
R htdocs/tools/importer.bml.text
A views/tools/importer/choose_data.tt
A views/tools/importer/choose_source.tt
A views/tools/importer/confirm.tt
A views/tools/importer/index.tt
A views/tools/importer/index.tt.text
A views/tools/importer/status.tt

Log Message:
-----------
Finish importer conversion and tidying


Commit: 220878fcddead35358538fa8908a2c8e4a40ef6c
https://github.com/dreamwidth/dw-free/commit/220878fcddead35358538fa8908a2c8e4a40ef6c
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-05-27 (Wed, 27 May 2020)

Changed paths:
M bin/upgrading/d10-passwords.pl
M cgi-bin/DW/Auth/Password.pm
M cgi-bin/DW/TaskQueue.pm
M cgi-bin/DW/Worker/XPostWorker.pm
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
Commit hot patches


Commit: 685d1d71714d9fb8a3552dfebe44c74d88305557
https://github.com/dreamwidth/dw-free/commit/685d1d71714d9fb8a3552dfebe44c74d88305557
Author: Mark Smith <mark@dreamwidth.org>
Date: 2020-05-27 (Wed, 27 May 2020)

Changed paths:
M cgi-bin/DW/Task/SendEmail.pm

Log Message:
-----------
Commit sins to stop duplicating email

I'm pretty sure the real problem here is that we're hitting the
visibility timeout on SQS and reprocessing messages, so this hack uses
memcache to make sure we don't send duplicate messages until I can
figure out the root issue with TaskQueue/SQS.


Commit: c713f7c1ae0ae646131ca8790bfa92723213ffe5
https://github.com/dreamwidth/dw-free/commit/c713f7c1ae0ae646131ca8790bfa92723213ffe5
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M styles/drifting/layout.s2

Log Message:
-----------
Fix drifting talkform in Drifting

In the s2foundation beta, where the talkform adopts some of the quick-reply's
styling, the form on the reply page gets pushed down below the sidebar. This
fixes that.

This layout is a great example of why everyone hates float-based layouts these
days. The fix is a kind of 😒 hack, but the alternative is basically open-heart
surgery on this thing so... *shrug*


Commit: a8360f07da6511ae91f16577b0b685ef68ea82d1
https://github.com/dreamwidth/dw-free/commit/a8360f07da6511ae91f16577b0b685ef68ea82d1
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
Prevent infinite loop in htmlcleaner

If the user's raw text has more closing ``s than it had opening `( Read more... )

`s until the end of time.


Commit: 8e211e5b4fbd75a379d4b7a5eb1d63ebd839d031
https://github.com/dreamwidth/dw-free/commit/8e211e5b4fbd75a379d4b7a5eb1d63ebd839d031
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
A cgi-bin/DW/Controller/Admin/Invites.pm
R htdocs/admin/invites/index.bml
R htdocs/admin/invites/index.bml.text
M views/admin/index.tt.text
A views/admin/invites/index.tt
A views/admin/invites/index.tt.text

Log Message:
-----------
convert /admin/invites/index


Commit: 73571eb6097fbc4174ef60cd605e663eca7696de
https://github.com/dreamwidth/dw-free/commit/73571eb6097fbc4174ef60cd605e663eca7696de
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Invites.pm
R htdocs/admin/invites/codetrace.bml
A views/admin/invites/codetrace.tt
A views/admin/invites/codetrace.tt.text

Log Message:
-----------
convert /admin/invites/codetrace


Commit: ba219b33176026affc7cdd78e8d967216d4ff9b4
https://github.com/dreamwidth/dw-free/commit/ba219b33176026affc7cdd78e8d967216d4ff9b4
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Invites.pm
R htdocs/admin/invites/distribute.bml
R htdocs/admin/invites/distribute.bml.text
A views/admin/invites/distribute.tt
A views/admin/invites/distribute.tt.text

Log Message:
-----------
convert /admin/invites/distribute


Commit: 6db0f1baa2f898b6ff5c18ce32754a3adc794ffa
https://github.com/dreamwidth/dw-free/commit/6db0f1baa2f898b6ff5c18ce32754a3adc794ffa
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M htdocs/scss/skins/_form-elements.scss
M views/admin/invites/distribute.tt

Log Message:
-----------
add inline styles for Foundation form elements

Momiji encouraged me to take the relevant part of her changes from #2603 and apply it here so I could more easily control the width of form fields.


Commit: 44632a64ecf41a9a7c09acdc6834b1acce4bd0c9
https://github.com/dreamwidth/dw-free/commit/44632a64ecf41a9a7c09acdc6834b1acce4bd0c9
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Invites.pm
R htdocs/admin/invites/requests.bml
A views/admin/invites/requests.tt
A views/admin/invites/requests.tt.text

Log Message:
-----------
convert /admin/invites/requests


Commit: 3df71f2bfdb243a61e469b3929fcc3bcdfd2da3f
https://github.com/dreamwidth/dw-free/commit/3df71f2bfdb243a61e469b3929fcc3bcdfd2da3f
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Invites.pm
R htdocs/admin/invites/review.bml
A views/admin/invites/review.tt
A views/admin/invites/review.tt.text

Log Message:
-----------
convert /admin/invites/review


Commit: ba60a0eae03b944150bac03c0b61045fdd7d21bb
https://github.com/dreamwidth/dw-free/commit/ba60a0eae03b944150bac03c0b61045fdd7d21bb
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-26 (Tue, 26 May 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin/Invites.pm
R htdocs/admin/invites/promo.bml
R htdocs/admin/invites/promo.bml.text
A views/admin/invites/promo-edit.tt
A views/admin/invites/promo-edit.tt.text
A views/admin/invites/promo.tt
A views/admin/invites/promo.tt.text

Log Message:
-----------
convert /admin/invites/promo


Commit: d7ae3dde09083e34725e9dec618e9efcda790353
https://github.com/dreamwidth/dw-free/commit/d7ae3dde09083e34725e9dec618e9efcda790353
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-05-27 (Wed, 27 May 2020)

Changed paths:
M cgi-bin/DW/Task/SendEmail.pm
M cgi-bin/DW/TaskQueue.pm

Log Message:
-----------
fix tidy failures


Commit: 49206e46dab60346e481e32d5a05612c584ea395
https://github.com/dreamwidth/dw-free/commit/49206e46dab60346e481e32d5a05612c584ea395
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M cgi-bin/DW/Hooks/PrivList.pm
R htdocs/admin/memcache.bml
R htdocs/admin/memcache_view.bml
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/memcache and /admin/memcache_view


Commit: 9e0014595ceff22e9ad94cf18dae17bc32290805
https://github.com/dreamwidth/dw-free/commit/9e0014595ceff22e9ad94cf18dae17bc32290805
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R cgi-bin/DW/Controller/Admin/StatusCheckLegacy.pm
M cgi-bin/DW/Hooks/PrivList.pm
R views/admin/clusterstatus.tt
R views/admin/clusterstatus.tt.text
R views/admin/mysql_status.tt
R views/admin/mysql_status.tt.text

Log Message:
-----------
remove /admin/clusterstatus and /admin/mysql_status


Commit: b6cb8639517108e9575285234bbe201c029902ac
https://github.com/dreamwidth/dw-free/commit/b6cb8639517108e9575285234bbe201c029902ac
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Props.pm

Log Message:
-----------
don't throw Perl error when feeding admin/propedit a nonexistent user

I went to add error checking for a nonexistent user and found that it was already there, but the scope needed to be expanded to avoid the problem. Then testing revealed that the error message wasn't passed to the page for printing, so I fixed that as well.

Fixes #2530.


Commit: 061ff79f76173e8525d2c0ac432f0cd7e918c9f2
https://github.com/dreamwidth/dw-free/commit/061ff79f76173e8525d2c0ac432f0cd7e918c9f2
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Request/Base.pm
M cgi-bin/DW/Template.pm
M htdocs/scss/components/foundation-custom/_alert-boxes.scss
M htdocs/scss/skins/lynx.scss
M htdocs/stc/base-colors-dark.css
M htdocs/stc/celerity/celerity.css
M htdocs/stc/gradation/gradation.css
M htdocs/stc/lj_base.css
M htdocs/stc/lynx/lynx.css
M schemes/celerity.tt
M schemes/common.tt
M schemes/global.tt
M schemes/lynx.tt

Log Message:
-----------
Add inline session messages


Commit: 7fc1ebdd0254047bfb2343500b669cad7de60e07
https://github.com/dreamwidth/dw-free/commit/7fc1ebdd0254047bfb2343500b669cad7de60e07
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M htdocs/js/jquery.imageshrink.js
M htdocs/scss/components/imageshrink.scss

Log Message:
-----------
[2650] Improved image shrinking, part three

We currently constrain the size of images in entry and comment content. But the
REASON we do this is so that people can casually post medium-sized images
and not stress about annoying their friends and readers; the beginning and end
of it is to make it easier to post on DW.

There's another set of user behaviors that's basically the OPPOSITE of casually
posting a medium image, where people express themselves by doing weird intricate
HTML shit no modern site would allow. It's part of DW's fandom-centric culture,
so we'd rather not interfere with it or make it harder.

This commit uses some extra javascript to try and guess which images are part of
a complex hunk of decorative / narrative markup, and changes the CSS to leave
said images alone (under the assumption that the author knows what they're
trying to accomplish and doesn't need any "help").

And while I'm at it, it also removes the "zoom in" cursor from images that are
already actual size and thus don't need to zoom. (That part uses an ultra-modern
API with stringent browser requirements, because 1. it's kind of just a vanity
thing, and 2. it has to update on window resize, but any tangible performance
cost is unacceptable, so if we can't do it for nearly-free then we shouldn't do
it at all. Native ResizeObserver is nearly-free, polyfills ain't.)


Commit: 128aa48726a78a3b3c1264869e4c5948df8c1164
https://github.com/dreamwidth/dw-free/commit/128aa48726a78a3b3c1264869e4c5948df8c1164
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M htdocs/scss/foundation/components/_global.scss

Log Message:
-----------
Comment out default global Foundation rules for images

These rules make too many assumptions to be compatible with this site, and in
particular they interfere badly with user-provided content. As far as I can
tell, none of the current pages rely on these CSS rules.

If we were using a viable living framework here, hacking the core files like
this would be a bad plan. But Foundation 5 is extremely end-of-life, AKA we
bought it so we might as well break it. We're already carrying patches to fix
upstream bugs that will never be addressed, so hey, what's one more.


Commit: dbc8417a3363e8cee79318f13abb00081f1bc4ba
https://github.com/dreamwidth/dw-free/commit/dbc8417a3363e8cee79318f13abb00081f1bc4ba
Author: Mark Smith <mark@qq.is>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M htdocs/js/jquery.imageshrink.js

Log Message:
-----------
Update htdocs/js/jquery.imageshrink.js

WHERE WILL THIS COMMIT END UP NOBODY KNOWS

Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>


Commit: db8ac80a4d42343cbddc5b2bf4b9e7d713454116
https://github.com/dreamwidth/dw-free/commit/db8ac80a4d42343cbddc5b2bf4b9e7d713454116
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm
M htdocs/scss/skins/_compatibility-styles.scss
M htdocs/stc/faq.css
R htdocs/support/faqbrowse.bml
R htdocs/support/faqbrowse.bml.text
R htdocs/support/faqsearch.bml
R htdocs/support/faqsearch.bml.text
A views/support/faqbrowse.tt
A views/support/faqbrowse.tt.text
A views/support/faqsearch.tt
A views/support/faqsearch.tt.text

Log Message:
-----------
Convert faqsearch and faqbrowse to Foundation/TT


Commit: 444792e41e38477f9eac3cb7986d9f267f8826ac
https://github.com/dreamwidth/dw-free/commit/444792e41e38477f9eac3cb7986d9f267f8826ac
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Support/Faq.pm

Log Message:
-----------
tidyall on Faq.pm


Commit: 430ee3ee27cf672f52c78179dd23929d3946da10
https://github.com/dreamwidth/dw-free/commit/430ee3ee27cf672f52c78179dd23929d3946da10
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/LJ/Console/Command/ChangeJournalType.pm
M cgi-bin/LJ/User/Message.pm
M t/console-changejournaltype.t

Log Message:
-----------
Fix change_journal_type console command to assign a new password

This command had been temporarily disabled because when changing a community journal to a personal journal, the old behavior was to copy both the email and password of the named community admin over to the converted journal. But the previously used method for accessing that password was recently removed in favor of better password practices, so we needed a different solution for that aspect of the change.

The modifications here are copied in part from the reset_password console command, which uses LJ::rand_chars to generate a random string and assigns that as the value of the new password, then communicates it directly to the user via email with the expectation that it will immediately be changed.

The actions taken by the change_journal_type console command are executed by the reset_email user method, which sends a message asking the user to confirm the new email address for the journal. For the case where we are also changing the password, the message sent now asks the user to both confirm the email and change the password. In the case of converting to a community, the password is silently reset to the empty string.


Commit: 9d7153bcba1d5cebf9fa6042583593a177e8e12a
https://github.com/dreamwidth/dw-free/commit/9d7153bcba1d5cebf9fa6042583593a177e8e12a
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M t/console-changejournaltype.t

Log Message:
-----------
Update test suite for change_journal_type command

- We haven't had a 'shared' journal type since before we forked.

- Check for blank password after converting to community, although this test will be a no-op once all accounts are on dversion 10.


Commit: 0e501afe9f950614065e90ae1a259e728f4bf414
https://github.com/dreamwidth/dw-free/commit/0e501afe9f950614065e90ae1a259e728f4bf414
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Console/Command/ChangeJournalType.pm
M t/console-changejournaltype.t

Log Message:
-----------
Fix #2350

Prevent a personal account from being converted to a community if it still administers other communities.


Commit: 514ba9ca7befd4d92c16ef23d4fd4304edeb6ee5
https://github.com/dreamwidth/dw-free/commit/514ba9ca7befd4d92c16ef23d4fd4304edeb6ee5
Author: Mark Smith <mark@qq.is>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/en.dat

Log Message:
-----------
Add / after siteroot

There seem to be mixed uses here but I'm pretty sure production uses siteroot as 'https://www.dreamwidth.org' with no trailing slash?


Commit: 3f087ff1a4712ff5b9dd9fa8a452a21502c71356
https://github.com/dreamwidth/dw-free/commit/3f087ff1a4712ff5b9dd9fa8a452a21502c71356
Author: Mark Smith <mark@qq.is>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/en.dat

Log Message:
-----------
Back out my siteroot change.


Commit: b8f64a033c78959f6a005ada2c27876f3e64e03d
https://github.com/dreamwidth/dw-free/commit/b8f64a033c78959f6a005ada2c27876f3e64e03d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M views/error.tt

Log Message:
-----------
Use foundation resource group in error template, because why not


Commit: 8794f4c76c3294fcb0b4cbace69a1f8072f43150
https://github.com/dreamwidth/dw-free/commit/8794f4c76c3294fcb0b4cbace69a1f8072f43150
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M htdocs/mobile/login.bml
M htdocs/mobile/login.bml.text

Log Message:
-----------
Remove some antique garbage from mobile login screen


Commit: 65fc1bfa25e536066525cd20351b4a9c2a45d54c
https://github.com/dreamwidth/dw-free/commit/65fc1bfa25e536066525cd20351b4a9c2a45d54c
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Talk.pm
R htdocs/talkpost_do.bml
A views/talkpost_do.tt
A views/talkpost_do.tt.text

Log Message:
-----------
Convert talkpost_do to controller/TT


Commit: 362bb33740fa3ad493aedec93b807f650ed50e19
https://github.com/dreamwidth/dw-free/commit/362bb33740fa3ad493aedec93b807f650ed50e19
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm

Log Message:
-----------
Minor proofreading in Talk controller

hash dereferences, one .bml path name, print debugs


Commit: 6a548d2564d698f6a9f2bfc77965ab1d1e9eb552
https://github.com/dreamwidth/dw-free/commit/6a548d2564d698f6a9f2bfc77965ab1d1e9eb552
Author: Ruth <momijizukamori@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Fixed OpenID comment posting


Commit: 22c80c7ccdaca0e132d5348f12e995360864b25a
https://github.com/dreamwidth/dw-free/commit/22c80c7ccdaca0e132d5348f12e995360864b25a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm

Log Message:
-----------
Talk controller: Fix void context warnings in comparisons

These looked sketchy as heck. The warnings went away after cleaning them up.


Commit: b1fb7d23f8d5da2a0cc26a100f9448e53f344229
https://github.com/dreamwidth/dw-free/commit/b1fb7d23f8d5da2a0cc26a100f9448e53f344229
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm

Log Message:
-----------
Talk controller: Render template for preview

Preview wasn't outputting at all without this.


Commit: e34e10d6b89b5397a7054b202980e87f076cb2b8
https://github.com/dreamwidth/dw-free/commit/e34e10d6b89b5397a7054b202980e87f076cb2b8
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm

Log Message:
-----------
Talk controller: set active resource group to jquery early to fix captcha

Remember the long comment I wrote about need_res, specifically the bit about how
it's kind of sketchy to check $LJ::ACTIVE_RES_GROUP before the whole page is
finished because we don't make any guarantees about its state at any given
point? The textCAPTCHA implementation checks $LJ::ACTIVE_RES_GROUP instead of
just calling need_res, so by the time the template calls
set_active_resource_group, it's too late and we have an unusable version of the
captcha JS (legacy, not jquery or foundation).


Commit: 93cce228509da603be9c417f26489535fa6a9dcf
https://github.com/dreamwidth/dw-free/commit/93cce228509da603be9c417f26489535fa6a9dcf
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M views/talkpost_do.tt

Log Message:
-----------
talkpost_do.tt cleanups

- Fix the "double success" / "successful error" headers
- Remove chalresp_js (it's dead, dude)


Commit: 30f576cc0327fea28821f703356516c41f9e23cc
https://github.com/dreamwidth/dw-free/commit/30f576cc0327fea28821f703356516c41f9e23cc
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Scour inline BML from make_preview (finish 1-1 talkpost_do conversion)

Hardcoding 'hotcolor', since spellcheck's on borrowed time anyhow. Otherwise
this didn't seem to be doing anything interesting.

As of this commit, everything seems to work, and the Talk controller acts as a
1-1 conversion of the old talkpost_do.bml. There's no tests for any of this
behavior, naturally, but I ran a fairly hellish manual testing matrix before
and after the conversion:

- Currently (logged out, site login, openid login)
- Posting as (self, anon, user (one-off), user (login), openid (one-off), openid (login))
- Performing (post, preview, preview-then-post, whiff-captcha-and-fix)

For the most part, it preserved any existing bugs and didn't add any new ones.
One exception:

- Fixes #2572?! 🙌🏼


Commit: e70d371c0e70a368c0e931905b49dab79ab94556
https://github.com/dreamwidth/dw-free/commit/e70d371c0e70a368c0e931905b49dab79ab94556
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
talkform: Stop pointlessly copying "editid" to "edit"

I think this was because the old talkform function was too frightening to touch.


Commit: c3585cd8cde8374912b3d75ffdc364cb427e0d63
https://github.com/dreamwidth/dw-free/commit/c3585cd8cde8374912b3d75ffdc364cb427e0d63
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/User/Journal.pm
M cgi-bin/LJ/Web.pm

Log Message:
-----------
User/Journal.pm: Refactor the "can't comment?" methods

These weren't what they could be, mostly to work around some slightly incoherent
behavior in S2 for conditionally printing quickreply links. So this shuffles
some things around and adds an umbrella method that checks everything (usually
what you want) and understands undef as anon.


Commit: d2fa8fc399e48c75607bdad8d42017935fc57119
https://github.com/dreamwidth/dw-free/commit/d2fa8fc399e48c75607bdad8d42017935fc57119
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
LJ::Talk::Post::init - initial refactoring

I'm just setting the explosive charges, here.

- LJ::Talk::init looks like ancient detritus from some kind of behavior
transition that ended eons ago. Inline it.
- Delete a ton of stuff that never gets used.
- Return an LJ::Entry in 'item' instead of a one-off hashref. We were creating
like three Entry objects anyway, so let's do it ONCE and just hold onto it.
- Fix a minor spam/security hole -- we were trying to prevent unvalidated
OpenIDs from commenting in places where anons aren't allowed, but the check
was in a branch that OpenID users couldn't end up in. No one ever noticed
this, because the comment forms WERE properly blocking anon-like OIDs, but if
you edited the form in your browser's web inspector, you could get in.


Commit: 993ebbeb52dd05d88110ad220cf399a2ea69f786
https://github.com/dreamwidth/dw-free/commit/993ebbeb52dd05d88110ad220cf399a2ea69f786
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Talk.pm
R htdocs/talkpost.bml.text
M views/talkpost_do.tt.text

Log Message:
-----------
LJ::T::P::i - refactor checks/munging into prepare_and_validate_comment

This moves all of LJ::Talk::Post::init's permissions / coherency / formatting
rules into a separate function, which is still long as hell but which at least
has a reasonable scope of responsibilities. It also grabs some rules that
belonged with these but had ended up in the callers instead of init, presumably
because nobody wanted to edit init.

While we're at it: Move ml strings to the new talkpost_do.tt.text. Bin the old
file and the dead strings.


Commit: cafe5c841027e4ac25d61013d93413518759269b
https://github.com/dreamwidth/dw-free/commit/cafe5c841027e4ac25d61013d93413518759269b
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Comment.pm

Log Message:
-----------
LJ::Comment->create - use prepare_and_validate_comment instead of init

It doesn't need any of the user authentication stuff since it's receiving an
already-authenticated user from its caller (Protocol), so it can skip all that.

LJ::Talk::Post::init now has only a single caller.


Commit: 62659ce8002c7ae224e431b688ba4767299795cd
https://github.com/dreamwidth/dw-free/commit/62659ce8002c7ae224e431b688ba4767299795cd
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
LJ::T::P::i - Refactor user lookup into authenticate_user_and_mutate_form

The form mutation was always one of the most haunted-ass pieces of init. We're
still doing a little bit of it, but mostly just so talkform can tell you've
logged in.

All of the downstream things that need the old behavior are already getting
what they need from prepare_and_validate_comment, which fakes it reliably.

LJ::Talk::Post::init now does about as little as possible.


Commit: 6c07fe7cf372a12e00dc42bdd7172565cbc40cec
https://github.com/dreamwidth/dw-free/commit/6c07fe7cf372a12e00dc42bdd7172565cbc40cec
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Talk: Refactor chrp validation into a function


Commit: 7faf3d52794ae1d5d51be8af58ea2f463f942366
https://github.com/dreamwidth/dw-free/commit/7faf3d52794ae1d5d51be8af58ea2f463f942366
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Completely destroy LJ::Talk::Post::init

Sleep tight, you hunk of garbage. 💀

This moves all of the integration and stuff that's specific to receiving
comments from a web form into the Talk controller, which is where it seems to
properly belong. That includes authenticate_user_and_mutate_form, since it's
really just an implementation detail of those forms.


Commit: 0486399941ff86fae4207ca988cc2ce8908c8c1f
https://github.com/dreamwidth/dw-free/commit/0486399941ff86fae4207ca988cc2ce8908c8c1f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Refactor LJ::Talk::Post::edit_comment


Commit: 9151cd86f6dcf1e46fe30bbdd90ed9e5fb0b191c
https://github.com/dreamwidth/dw-free/commit/9151cd86f6dcf1e46fe30bbdd90ed9e5fb0b191c
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Test.pm

Log Message:
-----------
Refactor LJ::Talk::Post::post_comment


Commit: 60d9324cf5f5ccc2ab2109ad8fe67f3e65b1144d
https://github.com/dreamwidth/dw-free/commit/60d9324cf5f5ccc2ab2109ad8fe67f3e65b1144d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
prepare_and_validate_comment: Stop setting usertype

Purging some lingering taint of LJ::Talk::Post::init. Downstream functions now
check for this information in a less demented way.


Commit: de8ce76a3b48338c1dac528f99da5a1032a3bc9f
https://github.com/dreamwidth/dw-free/commit/de8ce76a3b48338c1dac528f99da5a1032a3bc9f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M views/talkpost_do.tt.text

Log Message:
-----------
Re-refactor authenticate_user_and_mutate_form, clean up controller

- Make the return signature of the auth function easier to wrangle with.
- Don't need to do that delayed form_auth check since we're not in BML anymore;
the controller handles it for us, and it should be perfectly fine with the
timing of things like the openID check.
- Fix some ml strings.


Commit: 788385fb6f55e96a3cf057c4bccd3ca796fd6e73
https://github.com/dreamwidth/dw-free/commit/788385fb6f55e96a3cf057c4bccd3ca796fd6e73
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm

Log Message:
-----------
Bring talkpost_do into the s2foundation beta

Just switching the resource group based on whether a user is in the beta.

I'm doing this now even though it's conceptually last, because it lets me rip
some hacks out of the comment forms while I'm doing some unrelated cleanups in
them. I'm assuming this would make the preview form into an unbelievable mess,
but I never actually tried that because by this point I was Super Done with
make_preview's intractable bugginess.


Commit: c002675e6ab4ffe10a913b97255b89609370e14d
https://github.com/dreamwidth/dw-free/commit/c002675e6ab4ffe10a913b97255b89609370e14d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M views/journal/talkform.tt

Log Message:
-----------
Some maintenance work on the reply forms

A fair bit going on in here, but it's all miscellaneous.

- Removing spellcheck from the talkform, since I'm about to rebuild preview.

- If the form was submitted with a username and password and we need to display
the same form again, we now pre-fill the password so you don't need to re-type
it. This makes the new preview behavior feel much more humane. It felt a little
squirrelly at first, but it's going over HTTPS anyway, and the "someone goes to
your computer as soon as you stand up" threat model has bigger fish to fry.

If you submitted a WRONG password, we don't pre-fill that. That's handled by
authenticate_user_and_mutate_form.

- Now that talkpost_do isn't perma-locked to the jquery resource group, we can
display the new talkform on it. That means we don't have to sniff around at
$LJ::ACTIVE_RES_GROUP anymore! (The only reason we were doing that was because
the new talkform looked wack on talkpost_do.) Knocking that out of the QR too,
while I'm at it.

- Leaving some breadcrumbs behind for the next person, with the stuff I learned
recently about the various ID formats.

- Rearranging some stuff for legibility.

- Make talkform call LJ::get_remote instead of having $remote passed in. The
behavior of the "from" options interacts directly with the global login state,
so you'll never want to override $remote with something fake.

- Heyyyy, we don't need to deal with LJ::Talk::Post::init vandalizing the
usertype field anymore!!! (The new auth function does still munge usertype, but
it does it to accurately reflect how the login state has changed since the form
was submitted. Init would just straight-up lie to me.)


Commit: 0c5500cb32e5df3ffadcbc24b877294281e29e94
https://github.com/dreamwidth/dw-free/commit/0c5500cb32e5df3ffadcbc24b877294281e29e94
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
Update one comment in LJ/User/Account.pm


Commit: cc2318d3bfa252fda3753d7ca4996a9aeb43ed78
https://github.com/dreamwidth/dw-free/commit/cc2318d3bfa252fda3753d7ca4996a9aeb43ed78
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
A t/talkpost-authenticate-user.t

Log Message:
-----------
Tests: authenticate_user_and_mutate_form

I would have liked to have more of these, but unsurprisingly, those global
application state mutations are really unreliable in a test environment.


Commit: 9623842c36016741c53276cf29ec71690a8bf286
https://github.com/dreamwidth/dw-free/commit/9623842c36016741c53276cf29ec71690a8bf286
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
A t/talkpost-validate-comment.t

Log Message:
-----------
Tests: LJ::Talk::Post::prepare_and_validate_comment

It looks like this function is fairly testable! The only real barrier
to expanding this is tedium.


Commit: bd5042685cded6294d79f54cedd7c0c45721c83e
https://github.com/dreamwidth/dw-free/commit/bd5042685cded6294d79f54cedd7c0c45721c83e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Talk.pm
R htdocs/js/jquery.commentpreview.js
M views/talkpost_do.tt
A views/talkpost_do/preview_comment.tt
A views/talkpost_do/preview_parent.tt

Log Message:
-----------
Reimplement comment preview from scratch

LJ::Talk::Post::make_preview is unfixable. But the desired behavior isn't
complicated, so let's just huck it and replace it with a dumb template.

Ground rules:

- No new CSS.
- No loading components that aren't in LJ::Talk::init_s2journal_js.

Kinda wanted to fake up the inputs and call directly into the siteviews S2 code,
but nah. That siteviews markup structure is EXTREMELY STABLE, so we're better
off just mimicking enough of it for the off-the-shelf CSS to take effect.

This DOES change one notable behavior: Old preview deferred captcha and auth
by carrying it over as hidden inputs in its mutant reply form. New preview
validates the comment first, which consumes the captcha response. So if a
captcha is required, you need to do it when you submit for real, instead of
relying on one you previously did.

That mildly sucks, but only mildly:

- Preview's chill with errors, so you can ignore the captcha at first and only
fill it once you're done. (A little less intuitive, tho.)
- reCAPTCHAs expire in like two minutes anyway, right? You were totally getting
double-checked before anyway.

And hey, look what the new preview buys us:

- It reports errors, which you can fix WHILE you edit your comment text. Old
preview would act like things were fine, then Nope you on submit.
- The preview LOOKS like it's from the correct user, including userpic. (Old
preview said "anonymous" if it got confused, which was often.)
- If you picked an alt and chose "log in," you're fully logged in when the
preview loads. You can even pick one of your alt's icons during edits!
- (Beta) Not a hot mess on mobile.


Commit: 3310a44f6b2316ed7185f23bbba66cc76231529e
https://github.com/dreamwidth/dw-free/commit/3310a44f6b2316ed7185f23bbba66cc76231529e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
A t/ban-observer-effect.t

Log Message:
-----------
Add test testing our ability to test relationship changes

This workaround is used in some existing tests, like vgift-trans.t, but I
couldn't find an explanation, so it seems reasonable to leave behind a test
whose name will likely draw the attention of whoever hits this next.


Commit: bc39f6d04ac8b570315d315276e2e68df42fe510
https://github.com/dreamwidth/dw-free/commit/bc39f6d04ac8b570315d315276e2e68df42fe510
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Update some comments about icon browser


Commit: ec7c9e9c749db979a8d9d918e61628a9c30bb88d
https://github.com/dreamwidth/dw-free/commit/ec7c9e9c749db979a8d9d918e61628a9c30bb88d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
R htdocs/talkpost_do.bml.text

Log Message:
-----------
Remove talkpost_do.bml.text, add to deadphrases


Commit: 2ae0baf793ec2693a408a41767d010d0e5ac0783
https://github.com/dreamwidth/dw-free/commit/2ae0baf793ec2693a408a41767d010d0e5ac0783
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/S2/ReplyPage.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Test.pm
M t/talkpost-authenticate-user.t
M t/talkpost-validate-comment.t

Log Message:
-----------
Tidy the universe


Commit: 12d615ed1e5e246cc6b4ca1755cfa854c55a73ca
https://github.com/dreamwidth/dw-free/commit/12d615ed1e5e246cc6b4ca1755cfa854c55a73ca
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/S2/DayPage.pm
M cgi-bin/LJ/S2/EntryPage.pm
M cgi-bin/LJ/S2/FriendsPage.pm
M cgi-bin/LJ/S2/RecentPage.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
init_s2journal_js: check the remote for iconbrowser permissions

Everything that ever calls this function passes the exact same
`$remote && $remote->can_use_userpic_select` value for $opts{iconbrowser}, and I
don't think there's any use case for checking against a user OTHER than the
currently logged-in one. So we might as well just change that argument to mean
"the iconbrowser is usable here," and move the permissions check into the
convenience function.

(The call in the Talk controller was currently using stale info. I was about to
change it to check $real_remote, but on further thought why not just make the
function better.)


Commit: 18fb2384aa4e49916ef874f15ae85fb1b2fbf0d8
https://github.com/dreamwidth/dw-free/commit/18fb2384aa4e49916ef874f15ae85fb1b2fbf0d8
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm

Log Message:
-----------
"I'm OpenID" + "here's a username" is incoherent

Hey hey, one of the first payoffs for making that function stupider and more
obvious! The old implementation didn't check for this either, but no one ever
spotted it.


Commit: 8af150321c87533ff84482921c4c35a32369757d
https://github.com/dreamwidth/dw-free/commit/8af150321c87533ff84482921c4c35a32369757d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Move some journal content CSS/JS into init_s2journal_js

S2.pm was globally need_ressing a few JS/CSS files that aren't relevant for some
S2 pages (tags/icons/month/year), but ARE relevant for most pages that display
entry or comment content (including the new preview). Every page that displays
journal content calls init_s2journal_js (or at least they SHOULD), so that seems
like the natural place for these.


Commit: 262ab03fa41ffa3cc0941644ce373c12ecff1e41
https://github.com/dreamwidth/dw-free/commit/262ab03fa41ffa3cc0941644ce373c12ecff1e41
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-02 (Tue, 02 Jun 2020)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
Fix a comment


Commit: b9dc55a064a28282db3e00dbdb8b9525cbd7955a
https://github.com/dreamwidth/dw-free/commit/b9dc55a064a28282db3e00dbdb8b9525cbd7955a
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-04 (Thu, 04 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/Pay.pm
M cgi-bin/LJ/Widget/ShopCart.pm
R htdocs/admin/pay/import.bml
R htdocs/admin/pay/index.bml
R htdocs/admin/pay/view.bml
A views/admin/pay/index.tt
A views/admin/pay/index.tt.text
A views/admin/pay/striptime.tt
A views/admin/pay/striptime.tt.text
A views/admin/pay/vieworder.tt
A views/admin/pay/vieworder.tt.text
A views/admin/pay/viewuser.tt
A views/admin/pay/viewuser.tt.text

Log Message:
-----------
convert admin/pay pages to TT

Some reorganization here:

- pay/index is split into two views, index.tt and viewuser.tt

- the striptimefrom path in pay/view is now its own page, pay/striptime

The pay/import page was a forgotten relic of bygone days and we shall never speak of it again.


Commit: a5b7811159f461e3be75c36cb309c351289bc8fe
https://github.com/dreamwidth/dw-free/commit/a5b7811159f461e3be75c36cb309c351289bc8fe
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-04 (Thu, 04 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/pay from legacy index


Commit: 4b3387d3b214779977903b10fdd08da6bd764935
https://github.com/dreamwidth/dw-free/commit/4b3387d3b214779977903b10fdd08da6bd764935
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-04 (Thu, 04 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin.pm

Log Message:
-----------
tidy


Commit: e64bc6f267e3d3d13be42f412e5e8ceb61f10718
https://github.com/dreamwidth/dw-free/commit/e64bc6f267e3d3d13be42f412e5e8ceb61f10718
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)

Changed paths:
M t/talkpost-validate-comment.t

Log Message:
-----------
Fix copypasta glitch in test header

whoops


Commit: 06238c2a4b665388032d34719faebedbfca4be93
https://github.com/dreamwidth/dw-free/commit/06238c2a4b665388032d34719faebedbfca4be93
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)

Changed paths:
M views/talkpost_do/preview_comment.tt
M views/talkpost_do/preview_parent.tt

Log Message:
-----------
Melt unintentional hardtabs in comment preview templates

whoops


Commit: 5f2a874af92491b2c8b59fae8a1c26a0dacbd845
https://github.com/dreamwidth/dw-free/commit/5f2a874af92491b2c8b59fae8a1c26a0dacbd845
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-05 (Fri, 05 Jun 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
Tweak `mention` scanning regexps to fix end-of-sentence bug

Prior to this patch, `mentions` went Bad if they occurred before a
sentence-ending period -- mentions that used a shortcut site name (like `.ao3`)
just exploded, and other mentions would work but swallowed the sentence-ending
period.

This tweaks the regexps a bit:

- Cleanup: `\w` implies both `\d` and `_`, so they're not needed.
- Cleanup: `-` has special meaning depending on where it occurs within the
character class square brackets, so it's better to always escape it.
- Cleanup: hostnames can have hyphens.
- Bug fix: Final character of the matched mention must not be a period.


Commit: ddf76072221b068024f02e05af19e31980c9e95f
https://github.com/dreamwidth/dw-free/commit/ddf76072221b068024f02e05af19e31980c9e95f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-05 (Fri, 05 Jun 2020)

Changed paths:
M t/cleaner-markdown.t

Log Message:
-----------
Add tests for usertags at ends of sentences


Commit: 2476f0207d1f069b4803ab9d4dfa8f13f33996f1
https://github.com/dreamwidth/dw-free/commit/2476f0207d1f069b4803ab9d4dfa8f13f33996f1
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-05 (Fri, 05 Jun 2020)

Changed paths:
M t/cleaner-markdown.t

Log Message:
-----------
Add a TODO for a case we can't really test yet


Commit: 6e82fedde483857d20523ee031af18dec9a90765
https://github.com/dreamwidth/dw-free/commit/6e82fedde483857d20523ee031af18dec9a90765
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Protocol.pm
M t/comment-create.t

Log Message:
-----------
Fix failing comment-create.t

- First problem: Legit!! I forgot to add an early exit to LJ::Comment::create
when it's called without a ditemid. Previously, this would blow up slightly
later during LJ::Talk::Post::init and then create would return a generic error,
but because LJ::Entry::new explodes without it, we need to handle it earlier.
Could result in uninformative errors in both LJ::Comment::create and the Talk
controller.

- Second problem: Annoying. The test is looking for specific error codes, which
means if you give it input that's illegal in MULTIPLE ways, you're really
testing the ORDER in which it checks things, which I struggle to believe anyone
actually cares about. Well, oh well.


Commit: 77763f87ac63c9003568f2ffc468246f79709e80
https://github.com/dreamwidth/dw-free/commit/77763f87ac63c9003568f2ffc468246f79709e80
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/LJ/User/Icons.pm

Log Message:
-----------
[#2681] Don't break mapid -> pic lookups just because keyword is empty

This misplaced "next" statement was bailing out before mapid housekeeping
finished, making it so userpics without keywords were never shown in comments.
(Although their keywords would appear in hovertext on the default icon. Since we
finished SOME of the mapid housekeeping before being interrupted,
get_keyword_from_mapid worked fine, even though get_picid_from_mapid didn't.)


Commit: a717aeee16d6a6295957a9cdeef0abcbc7582967
https://github.com/dreamwidth/dw-free/commit/a717aeee16d6a6295957a9cdeef0abcbc7582967
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/LJ/HTMLControls.pm

Log Message:
-----------
Escape data attributes in _html_option

Looks like this was just forgotten when the feature was added. Only got noticed
when we started setting data attributes in the userpic menu to wrangle the icon
preview in reply forms.

I'm using the same $ehtml argument that sets escaping for values and text, since
I can't conceive of a situation where we'd want the one escaped but not the
other.


Commit: 26eced8e21d0aaa2755f57e1f54a8c00b7d13771
https://github.com/dreamwidth/dw-free/commit/26eced8e21d0aaa2755f57e1f54a8c00b7d13771
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/Sysban.pm
R htdocs/admin/sysban.bml
A views/admin/sysban/addnew.tt
A views/admin/sysban/addnew.tt.text
A views/admin/sysban/index.tt
A views/admin/sysban/index.tt.text
A views/admin/sysban/query.tt
A views/admin/sysban/query.tt.text

Log Message:
-----------
convert /admin/sysban


Commit: 5edcdaed258698cdcf5cd55948b1d8332c40732b
https://github.com/dreamwidth/dw-free/commit/5edcdaed258698cdcf5cd55948b1d8332c40732b
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Sysban.pm
M views/admin/sysban/addnew.tt.text
M views/admin/sysban/index.tt.text
M views/admin/sysban/query.tt.text

Log Message:
-----------
use render_success instead of success_ml

I didn't realize (or had forgotten) that there were two different versions of the success page defined. Use the newer one with Foundation styling.


Commit: b0ca0a85533592068ea2daaaa6fbd4abce894e50
https://github.com/dreamwidth/dw-free/commit/b0ca0a85533592068ea2daaaa6fbd4abce894e50
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/sysban from legacy index


Commit: 34a89c7b89a8f2bf3f918fbffdc4254e5525f3f8
https://github.com/dreamwidth/dw-free/commit/34a89c7b89a8f2bf3f918fbffdc4254e5525f3f8
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/OpenID.pm
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/User/Account.pm
R htdocs/openid/login.bml
R htdocs/openid/login.bml.text
A views/openid/login.tt.text

Log Message:
-----------
convert openid/login.bml to TT


Commit: f7ed3b0a0538b244eb5a2d160ff5101a47c9d5dd
https://github.com/dreamwidth/dw-free/commit/f7ed3b0a0538b244eb5a2d160ff5101a47c9d5dd
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/OpenID.pm
R htdocs/openid/approve.bml
R htdocs/openid/approve.bml.text
A views/openid/approve.tt
A views/openid/approve.tt.text

Log Message:
-----------
convert openid/approve.bml to TT


Commit: de7f495bfd36f5ed9ddea72b84270ee56ea8dab3
https://github.com/dreamwidth/dw-free/commit/de7f495bfd36f5ed9ddea72b84270ee56ea8dab3
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-09 (Tue, 09 Jun 2020)

Changed paths:
M doc/dependencies-cpanm

Log Message:
-----------
pin JSON::Validator@3.25

The 4.00 release deprecates the validate_json() function we are using.


Commit: d6960f72e919c3a5263b22c356cf1c11b85ddbea
https://github.com/dreamwidth/dw-free/commit/d6960f72e919c3a5263b22c356cf1c11b85ddbea
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-13 (Sat, 13 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Misc.pm

Log Message:
-----------
Always display beta features in a consistent order

The list of available features on /beta gets ordered at random on every visit,
which is disorienting. Whenever there's 2+ betas, it's real hard not to notice.

That's not the intended behavior, but the controller was only sorting betas by
their "start time", which we don't appear to actually use. So let's fall back to
sorting by the beta's ID when the start times are identical (i.e. first
comparison returns 0); arbitrary, but at least it won't jump around like that.


Compare: https://github.com/dreamwidth/dw-free/compare/639b63bd5115...d6960f72e919