[dreamwidth/dw-free] eb9640: fix undefined warning in DW/Controller/Feeds.pm

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: eb9640e01dd422685ec586c2cef703c0474d49c5
https://github.com/dreamwidth/dw-free/commit/eb9640e01dd422685ec586c2cef703c0474d49c5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Feeds.pm

Log Message:
-----------
fix undefined warning in DW/Controller/Feeds.pm

Use of uninitialized value in pattern match (m//) at /home/dw/production/cgi-bin/DW/Controller/Feeds.pm line 72.


Commit: 29afdd466c3857ecf573dbbbed8d9226a56682f6
https://github.com/dreamwidth/dw-free/commit/29afdd466c3857ecf573dbbbed8d9226a56682f6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix undefined warning in DW/Controller/EditIcons.pm

Use of uninitialized value in string eq .. cgi-bin/DW/Controller/EditIcons.pm line 163.


Commit: 60d05bad8ddbd27c656865e8db30679289757d13
https://github.com/dreamwidth/dw-free/commit/60d05bad8ddbd27c656865e8db30679289757d13
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
fix undefined warning in LJ/Userpic.pm

Use of uninitialized value $w in numeric ge (>=) .. cgi-bin/LJ/Userpic.pm line 682.


Commit: b2ab126f4681dd98e213752dfaa2f105154a9b64
https://github.com/dreamwidth/dw-free/commit/b2ab126f4681dd98e213752dfaa2f105154a9b64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Poll.pm

Log Message:
-----------
avoid die statement in LJ/Poll.pm

Error loading poll id: 1903855: Invalid journalid at /home/dw/production/cgi-bin/LJ/Poll.pm line 558.

This seemed the best course of action, since we're also
returning undef if the subsequent row lookup fails.


Commit: 1b9abedbfbaf852114844964841b8d6209026698
https://github.com/dreamwidth/dw-free/commit/1b9abedbfbaf852114844964841b8d6209026698
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
avoid calling method on undefined object in DW/Routing.pm

Can't call method "journal_base" on an undefined value at /home/dw/production/cgi-bin/DW/Routing.pm line 209

Tweak the conditional logic so that $renamed_u must be
valid if we want to redirect to it.


Commit: ae9ef2cf874669c36829ad8b13129a0b4770ba8e
https://github.com/dreamwidth/dw-free/commit/ae9ef2cf874669c36829ad8b13129a0b4770ba8e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/ChangeEmail.pm

Log Message:
-----------
fix undefined warning in DW/Controller/ChangeEmail.pm

Use of uninitialized value in string ne at /home/dw/production/cgi-bin/DW/Controller/ChangeEmail.pm line 84.

First, we don't need to check is_identity when assigning $password,
because we check for it in the conditional.

Second, we should actually use $password if we assign it.

Third, put the short-circuit check ($remote->is_identity)
first, to avoid unnecessarily checking a string that will
be undefined in that particular case.

Fourth, OK to error if $password is undef, since that can never be
the correct password. Identity accounts can have undefined pws
but we've already accounted for that.


Commit: 850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
https://github.com/dreamwidth/dw-free/commit/850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
fix undefined warning in DW/Controller/API/Media.pm

Use of uninitialized value $type in numeric eq (==) at /home/dw/production/cgi-bin/DW/Controller/API/Media.pm line 74.


Commit: 1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
https://github.com/dreamwidth/dw-free/commit/1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
remove unused variable from DW::Routing


Commit: b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
https://github.com/dreamwidth/dw-free/commit/b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Feeds.pm
M cgi-bin/DW/Routing.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Merge pull request #1991 from kareila/cleanup-2017q1

Post-push log cleanup


Compare: https://github.com/dreamwidth/dw-free/compare/fd10742691d7...b49f98c67974

[dreamwidth/dw-free] 1ded4d: use correct user object when deleting existing slu...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
https://github.com/dreamwidth/dw-free/commit/1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use correct user object when deleting existing slugs

Fixes #1992.


Commit: e94a1a9b5351bdbc75ba2acb971cc0770237a584
https://github.com/dreamwidth/dw-free/commit/e94a1a9b5351bdbc75ba2acb971cc0770237a584
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
Merge pull request #1993 from kareila/1992-edit-slugs

use correct user object when deleting existing slugs


Compare: https://github.com/dreamwidth/dw-free/compare/b49f98c67974...e94a1a9b5351

[dreamwidth/dw-free] 4b4f74: [#1983] fix one more occurrence of reference misma...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 4b4f745e77f45cb387c65819c5d7a15618c231ea
https://github.com/dreamwidth/dw-free/commit/4b4f745e77f45cb387c65819c5d7a15618c231ea
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.


Commit: 04b51784361961dfcbbd70112b08b0cf49b901d0
https://github.com/dreamwidth/dw-free/commit/04b51784361961dfcbbd70112b08b0cf49b901d0
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
Merge pull request #2001 from kareila/1983-autoscale

[#1983] fix one more occurrence of reference mismatch errors


Compare: https://github.com/dreamwidth/dw-free/compare/e94a1a9b5351...04b517843619

[dreamwidth/dw-free] c172a1: [#1855] improve handling of media load errors on /...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: c172a10daa9e7f9c6aea4a66f92581555d5f612f
https://github.com/dreamwidth/dw-free/commit/c172a10daa9e7f9c6aea4a66f92581555d5f612f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.


Commit: ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
https://github.com/dreamwidth/dw-free/commit/ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
Merge pull request #2002 from kareila/1855-null-mediaid

[#1855] improve handling of media load errors on /file/edit


Compare: https://github.com/dreamwidth/dw-free/compare/04b517843619...ea34b74fd0ae

[dreamwidth/dw-free] e69b60: [#1988] remove LJ/EventLogRecord.pm and submodules

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: e69b60fbd008183682bf8f910f54cc61c6e11ecd
https://github.com/dreamwidth/dw-free/commit/e69b60fbd008183682bf8f910f54cc61c6e11ecd
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf

Log Message:
-----------
[#1988] remove LJ/EventLogRecord.pm and submodules

Fixes #1988.


Commit: fd912965db3686b34ff5e93dd57551504e3d9280
https://github.com/dreamwidth/dw-free/commit/fd912965db3686b34ff5e93dd57551504e3d9280
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M t/post.t

Log Message:
-----------
removal of EventLogRecord from postevent causes test failures

Failed test 'Public security'
at t/post.t line 394.
got: undef
expected: 'public'

Failed test 'Public security'
at t/post.t line 403.
got: undef
expected: 'public'

Failed test 'Locked security'
at t/post.t line 415.
got: undef
expected: 'usemask'

In all three cases, changing $entry->{security} to $entry->security
fixed the problem, because that causes the object's hash data to be
populated. Previously, the data was populated within the context of
the EventLogRecord job in postevent.


Commit: 4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
https://github.com/dreamwidth/dw-free/commit/4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use another method to repopulate the entry object data

At first I thought I would need to audit the code for
uses of $entry->{security} instead of $entry->security,
and while I did find and change a few of those, I quickly
realized a less scattershot approach would be to drop in
another method call in place of the removed one that had
the same side effect of populating the data in the cached
entry object.

With that done, the failing test once again passes
(although I'm still committing the fixed version).


Commit: ecba2a889335572f0ff0125eee0d9ca1b9eda166
https://github.com/dreamwidth/dw-free/commit/ecba2a889335572f0ff0125eee0d9ca1b9eda166
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf
M t/post.t

Log Message:
-----------
Merge pull request #1994 from kareila/1988-EventLogRecord

[#1988] remove LJ/EventLogRecord.pm and submodules


Compare: https://github.com/dreamwidth/dw-free/compare/ea34b74fd0ae...ecba2a889335

[dreamwidth/dw-free] 7400b9: additional headers for media file requests

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 7400b91371eecaf4e604b2085d35a05c72dfc5a5
https://github.com/dreamwidth/dw-free/commit/7400b91371eecaf4e604b2085d35a05c72dfc5a5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.


Commit: 8410894ea119c8fe13b0ccb88db949c9ece082f9
https://github.com/dreamwidth/dw-free/commit/8410894ea119c8fe13b0ccb88db949c9ece082f9
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
Merge pull request #2003 from kareila/media-headers

additional headers for media file requests


Compare: https://github.com/dreamwidth/dw-free/compare/ecba2a889335...8410894ea119

[dreamwidth/dw-free] 941441: [#1983] fix one more occurrence of reference misma...

[github]

Branch: refs/heads/release-1.32
Home: https://github.com/dreamwidth/dw-free
Commit: 941441147bd95f6b345d38c69eee4f6ddb958190
https://github.com/dreamwidth/dw-free/commit/941441147bd95f6b345d38c69eee4f6ddb958190
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.


Commit: 8f7953dd1501b11c3db6f4a04f506e75b9916c18
https://github.com/dreamwidth/dw-free/commit/8f7953dd1501b11c3db6f4a04f506e75b9916c18
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.


Commit: 861a018829ee0ae2c67b2a490413c44550976e08
https://github.com/dreamwidth/dw-free/commit/861a018829ee0ae2c67b2a490413c44550976e08
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.


Compare: https://github.com/dreamwidth/dw-free/compare/e05fe1281a79...861a018829ee