[dreamwidth/dw-free] e69b60: [#1988] remove LJ/EventLogRecord.pm and submodules

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: e69b60fbd008183682bf8f910f54cc61c6e11ecd
https://github.com/dreamwidth/dw-free/commit/e69b60fbd008183682bf8f910f54cc61c6e11ecd
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf

Log Message:
-----------
[#1988] remove LJ/EventLogRecord.pm and submodules

Fixes #1988.


Commit: fd912965db3686b34ff5e93dd57551504e3d9280
https://github.com/dreamwidth/dw-free/commit/fd912965db3686b34ff5e93dd57551504e3d9280
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M t/post.t

Log Message:
-----------
removal of EventLogRecord from postevent causes test failures

Failed test 'Public security'
at t/post.t line 394.
got: undef
expected: 'public'

Failed test 'Public security'
at t/post.t line 403.
got: undef
expected: 'public'

Failed test 'Locked security'
at t/post.t line 415.
got: undef
expected: 'usemask'

In all three cases, changing $entry->{security} to $entry->security
fixed the problem, because that causes the object's hash data to be
populated. Previously, the data was populated within the context of
the EventLogRecord job in postevent.


Commit: 4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
https://github.com/dreamwidth/dw-free/commit/4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use another method to repopulate the entry object data

At first I thought I would need to audit the code for
uses of $entry->{security} instead of $entry->security,
and while I did find and change a few of those, I quickly
realized a less scattershot approach would be to drop in
another method call in place of the removed one that had
the same side effect of populating the data in the cached
entry object.

With that done, the failing test once again passes
(although I'm still committing the fixed version).


Commit: ecba2a889335572f0ff0125eee0d9ca1b9eda166
https://github.com/dreamwidth/dw-free/commit/ecba2a889335572f0ff0125eee0d9ca1b9eda166
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf
M t/post.t

Log Message:
-----------
Merge pull request #1994 from kareila/1988-EventLogRecord

[#1988] remove LJ/EventLogRecord.pm and submodules


Compare: https://github.com/dreamwidth/dw-free/compare/ea34b74fd0ae...ecba2a889335