[dreamwidth/dw-free] eb9640: fix undefined warning in DW/Controller/Feeds.pm

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: eb9640e01dd422685ec586c2cef703c0474d49c5
https://github.com/dreamwidth/dw-free/commit/eb9640e01dd422685ec586c2cef703c0474d49c5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Feeds.pm

Log Message:
-----------
fix undefined warning in DW/Controller/Feeds.pm

Use of uninitialized value in pattern match (m//) at /home/dw/production/cgi-bin/DW/Controller/Feeds.pm line 72.


Commit: 29afdd466c3857ecf573dbbbed8d9226a56682f6
https://github.com/dreamwidth/dw-free/commit/29afdd466c3857ecf573dbbbed8d9226a56682f6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix undefined warning in DW/Controller/EditIcons.pm

Use of uninitialized value in string eq .. cgi-bin/DW/Controller/EditIcons.pm line 163.


Commit: 60d05bad8ddbd27c656865e8db30679289757d13
https://github.com/dreamwidth/dw-free/commit/60d05bad8ddbd27c656865e8db30679289757d13
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
fix undefined warning in LJ/Userpic.pm

Use of uninitialized value $w in numeric ge (>=) .. cgi-bin/LJ/Userpic.pm line 682.


Commit: b2ab126f4681dd98e213752dfaa2f105154a9b64
https://github.com/dreamwidth/dw-free/commit/b2ab126f4681dd98e213752dfaa2f105154a9b64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Poll.pm

Log Message:
-----------
avoid die statement in LJ/Poll.pm

Error loading poll id: 1903855: Invalid journalid at /home/dw/production/cgi-bin/LJ/Poll.pm line 558.

This seemed the best course of action, since we're also
returning undef if the subsequent row lookup fails.


Commit: 1b9abedbfbaf852114844964841b8d6209026698
https://github.com/dreamwidth/dw-free/commit/1b9abedbfbaf852114844964841b8d6209026698
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
avoid calling method on undefined object in DW/Routing.pm

Can't call method "journal_base" on an undefined value at /home/dw/production/cgi-bin/DW/Routing.pm line 209

Tweak the conditional logic so that $renamed_u must be
valid if we want to redirect to it.


Commit: ae9ef2cf874669c36829ad8b13129a0b4770ba8e
https://github.com/dreamwidth/dw-free/commit/ae9ef2cf874669c36829ad8b13129a0b4770ba8e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/ChangeEmail.pm

Log Message:
-----------
fix undefined warning in DW/Controller/ChangeEmail.pm

Use of uninitialized value in string ne at /home/dw/production/cgi-bin/DW/Controller/ChangeEmail.pm line 84.

First, we don't need to check is_identity when assigning $password,
because we check for it in the conditional.

Second, we should actually use $password if we assign it.

Third, put the short-circuit check ($remote->is_identity)
first, to avoid unnecessarily checking a string that will
be undefined in that particular case.

Fourth, OK to error if $password is undef, since that can never be
the correct password. Identity accounts can have undefined pws
but we've already accounted for that.


Commit: 850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
https://github.com/dreamwidth/dw-free/commit/850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
fix undefined warning in DW/Controller/API/Media.pm

Use of uninitialized value $type in numeric eq (==) at /home/dw/production/cgi-bin/DW/Controller/API/Media.pm line 74.


Commit: 1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
https://github.com/dreamwidth/dw-free/commit/1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
remove unused variable from DW::Routing


Commit: b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
https://github.com/dreamwidth/dw-free/commit/b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Feeds.pm
M cgi-bin/DW/Routing.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Merge pull request #1991 from kareila/cleanup-2017q1

Post-push log cleanup


Compare: https://github.com/dreamwidth/dw-free/compare/fd10742691d7...b49f98c67974