changelog | Feb. 5th, 2021

Feb. 5th, 2021

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 9194ad991efa2af2f0fe461aefebe1c14adbdde9 https://github.com/dreamwidth/dw-free/commit/9194ad991efa2af2f0fe461aefebe1c14adbdde9 Author: Kareila kareila@dreamwidth.org Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M bin/upgrading/update-db-general.pl M bin/upgrading/update-db.pl M cgi-bin/LJ/NotificationMethod/Email.pm

Log Message:

run tidyall on master

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 22e8bf59a48950666ec93540b3b4242bbe822cd1 https://github.com/dreamwidth/dw-free/commit/22e8bf59a48950666ec93540b3b4242bbe822cd1 Author: Kareila kareila@dreamwidth.org Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M cgi-bin/DW/Controller/Edges.pm

Log Message:

Have /data/edges return an error if accessed without first logging in

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 2b83bc55f6870ef895694caa261e8abd922d262f https://github.com/dreamwidth/dw-free/commit/2b83bc55f6870ef895694caa261e8abd922d262f Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/scss/skins/_entry-styles.scss M styles/core2base/layout.s2

Log Message:

Keep gap after entry/comment content consistent

Mentioned in #2812. Restricting this to the last DIRECT child of the content div should do the right thing 90%+ of the time without risking unintended consequences.

This only fixes this for site skin comment pages and Tabula Rasa-based journal styles; other journal styles still do whatever they do.

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: b4be9b0f666ac266c2b8c1ed8589d6bded8ec88f https://github.com/dreamwidth/dw-free/commit/b4be9b0f666ac266c2b8c1ed8589d6bded8ec88f Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js

Log Message:

Remove unused click handler

Now that it's a one-click interaction, the select button is gone.

Commit: 210d5dc9b4708ec2d717a801696170fc8d926240 https://github.com/dreamwidth/dw-free/commit/210d5dc9b4708ec2d717a801696170fc8d926240 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js

Log Message:

Remove redundant click trigger on enter key

This was an accessibility workaround for when we were misusing <a> elements instead of using proper <button>s. Now that we get the default accessible button behavior, this is cruft.

Commit: cdb5842f57f1bf547bd888144abfce3fb4e2e9cb https://github.com/dreamwidth/dw-free/commit/cdb5842f57f1bf547bd888144abfce3fb4e2e9cb Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js M htdocs/scss/components/icon-browser.scss M views/components/icon-browser.tt

Log Message:

Add show/hide button for icon browser options on mobile

The display options take up way too much space on mobile, and presumably you like what you like and aren't changing them every time!

So at small viewport sizes, this commit hides the options behind a toggle button.

It goes right above+before the search field. If you summon the browser without an icon already selected, the search field is the first thing focused, so you don't have to tab through the options toggle before reaching the icons if you're keyboard-navvin.
For sighted users: The button is styled to look like a cut tag or a <details> element (with the little open/close disclosure triangle), which DW users should be intimately familiar with. Its text includes a summary of the currently selected options.
For screen readers: I'm using an aria-label instead of the current options summary, because they won't have the visual cue of the disclosure triangle.

Commit: ca17b1420222b10563ca82367a955a0ccff89f9f https://github.com/dreamwidth/dw-free/commit/ca17b1420222b10563ca82367a955a0ccff89f9f Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js M htdocs/js/components/jquery.icon-select.js M views/components/icon-select-dropdown.tt M views/components/icon-select-icon.tt M views/journal/quickreply.tt M views/journal/talkform.tt

Log Message:

Restore missing behavior: focus comment body on dismissal

This went missing after #2840.

Commit: de017f8fb389a476ab309d957cd7c4a7c8dc25bd https://github.com/dreamwidth/dw-free/commit/de017f8fb389a476ab309d957cd7c4a7c8dc25bd Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M views/components/icon-browser.tt

Log Message:

Use same inline styles for disclosure triangle that we use in cut tags

Compare: https://github.com/dreamwidth/dw-free/compare/2b83bc55f687...de017f8fb389

github

Branch: refs/heads/code-tour Home: https://github.com/dreamwidth/dw-free Commit: 32d3d6eb9ee37016e0e38643613daf1f08f13c54 https://github.com/dreamwidth/dw-free/commit/32d3d6eb9ee37016e0e38643613daf1f08f13c54 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-31 (Mon, 31 Aug 2020)

Changed paths: M htdocs/scss/components/icon-browser.scss M htdocs/scss/foundation/components/_reveal.scss M htdocs/scss/pages/entry/new.scss M views/components/icon-browser.tt M views/entry/module-access.tt

Log Message:

Fix icon browser on create entries page (#2836)

Un-break the icon browser in beta create entries page

Somehow I missed this bug in my last icon browser PR.

Visible symptoms: "order by keyword" doesn't work when used on the create entries page, and some of the styling/alignment is a little wrong there too.

Underlying problem:

The whole create entries page is wrapped in one bigass <form> element.
It's illegal to nest a form inside a form.
I used forms as container elements for the re-jiggered icon browser options toggles.
The icon browser modal markup gets spawned inside the icons module, which is still inside the bigass top-level form element.
Kaboom.

I assume this also broke some other stuff on that page, but who cares because let's just not do that; those nested form elements aren't needed anyway. (I used them initially because I thought I'd be using HTMLFormElement.elements to get the inputs, but I didn't end up doing that.)

Create entries: Use normal fieldset/legend relationship in custom access modal

This was making the top-border on Foundation's fieldset styling look wrong.

Create entries: Don't mess with fieldset borders in modals

This was causing the icon browser to look inconsistent between create entries and site-skin comment pages. After following it back, it looks like this was just to accommodate the weird markup in the custom access groups modal.

Foundation modals: clear some space around the close button

In the last big foundation update, something changed with how things are spaced in reveal modals, which made it possible for the edges of elements (like the top border of a fieldset) to sometimes scoot underneath the close button. That looks a little confusing, so let's make the close button obscure the couple of pixels behind it by grabbing the same background color as the modal itself.

Create entries: Fix button alignment when using custom access groups

The fancy selects squirted a few pixels out of alignment whenever the "edit" button appeared; this stops that.

Commit: f90e633e7d814817aa692edebab8d4d8b9d3e874 https://github.com/dreamwidth/dw-free/commit/f90e633e7d814817aa692edebab8d4d8b9d3e874 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-31 (Mon, 31 Aug 2020)

Changed paths: M htdocs/js/jquery.quickreply.js M htdocs/scss/components/quick-reply.scss M htdocs/scss/skins/_journal-typography.scss

Log Message:

Two minor reply form tweaks (#2831)

Comment preview: use same reply form font as other site skin pages

The rules that affect entries and comments weren't affecting the parent wrapper for the preview page. That was mostly fine, because the preview itself and the parent post both use fake wrappers to make sure they get the right styles. But the talkform appears outside those, as its own element, so it was missing the rules. Thus, the textarea was at the mercy of whatever default or inherited styles applied, probably browser-dependent.

Reply form: Allow a little more max-width on desktop

On site-skin comment pages, the 16px font for textareas just makes the max starting width feel too cramped.

Commit: 686db9c24ebc81f4a260e6c4d0d2d36d36ca62ef https://github.com/dreamwidth/dw-free/commit/686db9c24ebc81f4a260e6c4d0d2d36d36ca62ef Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-31 (Mon, 31 Aug 2020)

Changed paths: A htdocs/scss/components/foundation-custom/print.scss M htdocs/scss/foundation/settings.scss M htdocs/scss/foundation/foundation.scss M htdocs/scss/skins/_nav.scss

Log Message:

Fix printing on Foundation site skins (#2828)

Printing an entry+comments page on the new site skins pretty much just EXPLODES. Shoutout to anaraine and AlexSeanchai in the Discord for raising the issue.

First set of problems is in Foundation's print styles, which "helpfully" add the URL after every link (including tiny chiclet icon links that carry no meaning in print). So let's turn those off and add our own reduced set, because flipping font to black and expanding abbreviations is still a pretty good idea.

Second set of problems involves the positioning of account links and the user's icon in the header, but those are straightforward fixes too.

Third set of problems is specific to Tropo, which cuts off everything after the first page. 😱 Addressed in dreamwidth/dw-nonfree#142.

After that we get into the innate problems that already existed on the old skins -- showing threading through indentation alone makes a truly impossible mess when printing deep threads, and that can't be fixed without a total rethink of the threading styles. But at least this commit (plus nonfree 142) gets us back to status quo ante.

Commit: 0bb132e2a3a6749a6aa497870c36dbe83f099e5d https://github.com/dreamwidth/dw-free/commit/0bb132e2a3a6749a6aa497870c36dbe83f099e5d Author: rshatch ruth.s.hatch@gmail.com Date: 2020-09-01 (Tue, 01 Sep 2020)

Changed paths: M cgi-bin/DW/Request/Base.pm

Log Message:

Add a shortcut for session msg + redirect pattern (#2835)

Add a shortcut for session msg + redirect pattern
Tidying

Co-authored-by: Ruth momijizukamori@gmail.com

Commit: 9be41d342503d87f0ba0c513e0eca1b12121fc18 https://github.com/dreamwidth/dw-free/commit/9be41d342503d87f0ba0c513e0eca1b12121fc18 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-09-01 (Tue, 01 Sep 2020)

Changed paths: M htdocs/scss/skins/nav.scss M htdocs/scss/skins/gradation/gradation-base.scss

Log Message:

Fix content centering in Gradation Horizontal

The gradation skins both slam the #content div over to the left, but that's only appropriate on the vertical nav one; the horizontal one should act like the tropos do and center it.

Commit: b023c12a04e72a0ab4f81d47d704a9ae2d95b629 https://github.com/dreamwidth/dw-free/commit/b023c12a04e72a0ab4f81d47d704a9ae2d95b629 Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests/commentmanage.js

Log Message:

Fix location of commentmanage.js in views/dev/tests

Commit: 99195720b441df24c3d5da55a4750cd1c06ff1db https://github.com/dreamwidth/dw-free/commit/99195720b441df24c3d5da55a4750cd1c06ff1db Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests.tt

Log Message:

Don't include sinon-ie.js in dev/tests.tt

This breaks the test suite by overriding the built-in Date() object.

"If you don't require fake timers to work in IE, don't include this file."

Commit: 3cbe433e8196a30c12603c44908f6279cbcb711f https://github.com/dreamwidth/dw-free/commit/3cbe433e8196a30c12603c44908f6279cbcb711f Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests-all.tt

Log Message:

Don't include sample.js in dev/tests-all.tt

It's an example file, not a real test.

Commit: 3e855fc52d47ca37e2cd15cd092d20cd28843419 https://github.com/dreamwidth/dw-free/commit/3e855fc52d47ca37e2cd15cd092d20cd28843419 Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests/commentmanage.js

Log Message:

Fix timing issues in delcomment tests

Through trial and error, I proved that the delcomment tests were failing in a non-deterministic way due to timing issues between the comment visibility being changed and being observed. If I removed all the stop calls or changed their arguments, all the visibility tests failed consistently.

I eventually discovered that if I commented out the stop calls for the elements whose visibility was unchanged, the tests passed consistently.

Commit: 357c95d2cbfe9dec36cfb3068b38250665fddb48 https://github.com/dreamwidth/dw-free/commit/357c95d2cbfe9dec36cfb3068b38250665fddb48 Author: rshatch ruth.s.hatch@gmail.com Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M htdocs/scss/skins/entry-styles.scss M htdocs/scss/skins/celerity.scss M htdocs/scss/skins/gradation/gradation-base.scss M htdocs/scss/skins/lynx.scss M styles/siteviews/layout.s2 M views/components/pagination.tt

Log Message:

Make site-schemed comment page links nicer (#2801)

Make site-schemed comment page links nicer
Linting
Update htdocs/scss/skins/_entry-styles.scss

Co-authored-by: Nick Fagerlund nick@hashicorp.com

Update htdocs/scss/skins/_entry-styles.scss

Co-authored-by: Nick Fagerlund nick@hashicorp.com

Make arrow styling match TT pagination
Fix TT pagination component
Make disabled pagination arrows more clearly noninteractive

Co-authored-by: Ruth momijizukamori@gmail.com Co-authored-by: Nick Fagerlund nick@hashicorp.com

Commit: 429ead8638d2f8f9819be8fe54e96700d8a87cf2 https://github.com/dreamwidth/dw-free/commit/429ead8638d2f8f9819be8fe54e96700d8a87cf2 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M t/cleaner-event.t

Log Message:

New cleaner test: don't add bogus </br> tags when closing a paragraph

This test currently fails.

Commit: 13e222c36a7fb8f77b3e89bfd4e935e86c580d75 https://github.com/dreamwidth/dw-free/commit/13e222c36a7fb8f77b3e89bfd4e935e86c580d75 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M cgi-bin/LJ/CleanHTML.pm

Log Message:

Cleaner: exclude empty tags from per-tag closer

I think a more correct approach is to not add empty tags to the tag stack in the first place! But the more parsimonious approach is to just do the same thing in both the end-of-document closer and the end-of-tag closer.

Commit: aa8f6cc1dc8e4b8fac189573d80d5f8fe892fd12 https://github.com/dreamwidth/dw-free/commit/aa8f6cc1dc8e4b8fac189573d80d5f8fe892fd12 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M cgi-bin/LJ/CleanHTML.pm

Log Message:

Cleaner: Add HTML5 source and track tags to list of empty tags

Commit: c8e8ae70f324c67b7794439f3706e8a7500740c4 https://github.com/dreamwidth/dw-free/commit/c8e8ae70f324c67b7794439f3706e8a7500740c4 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

[#2841] Properly record anon comment IPs in the temp table for spam

This is another instance of #2738 -- edit_comment and enter_comment used to mutate their $comment argument by adding a talkid key with the jtalkid, and I missed a few things referenced that value via the mutated hashref rather than one of their other handles to the jtalkid. In this case, it was preventing anonymous comment spam reports by not properly writing the IP address of new anon comments to the tempanonips table.

This time I hunted real hard for anything in the code that might access any hashref key called talkid. As a result, this commit also:

Fixes one more instance of That Thing (re-screening when editing).
Just deletes the final remaining instance (an unused hook).
Yanks a similar "mutate the $comment argument" behavior in enter_imported_comment -- nothing ever references that hashref argument again before it goes out of scope.

All the remaining hashrefs with talkid members seem to be either s2 comment objects or the parent element of one of prepare_and_validate_comment's comment hashrefs.

Commit: 81b7ddeb3ae53cb22a91edf77e1a959f3f266f03 https://github.com/dreamwidth/dw-free/commit/81b7ddeb3ae53cb22a91edf77e1a959f3f266f03 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-11-30 (Mon, 30 Nov 2020)

Changed paths: M cgi-bin/LJ/CleanHTML.pm

Log Message:

[#2842] Stop closing <poll-45123> placeholder tags

The HTML cleaner closes dangling tags (both at document end, and when closing tags mid-way), but exempts the HTML5 list of "empty" tags from that.

Once an entry with a poll is saved, the markup that was used to build the poll gets replaced with a <poll-nnn> placeholder, so the poll can't be subsequently modified. These placeholder tags are effectively empty tags, but the cleaner doesn't really treat them as special because it's not in charge of rendering them; LJ::Poll->expand_entry does that, and we call it after clean_event when we're rendering an entry.

Anyway, the cleaner was helpfully "closing" these placeholders, so, let's don't.

Commit: 1a8c3744bdd087a544b79c53580bd5d987404e01 https://github.com/dreamwidth/dw-free/commit/1a8c3744bdd087a544b79c53580bd5d987404e01 Author: Ruth momijizukamori@gmail.com Date: 2020-12-01 (Tue, 01 Dec 2020)

Changed paths: M views/entry/form.tt M views/journal/quickreply.tt M views/journal/talkform.tt

Log Message:

Force markup FAQ link to open in new tab/window

Commit: caf70f3ff5fcaa3a665ff4e1f1cea509d4628c16 https://github.com/dreamwidth/dw-free/commit/caf70f3ff5fcaa3a665ff4e1f1cea509d4628c16 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-01 (Tue, 01 Dec 2020)

Changed paths: M htdocs/js/jquery.imageshrink.js M htdocs/scss/components/imageshrink.scss

Log Message:

The Squish, Part Four

The quest to perfect this image-shrinking behavior continues. This time:

Distinguish between "normal" and "tall" (height > 2x width) casual images, and let tall images scroll instead of fitting the viewport. Nicer un-zoomed state for vertical comic strips.
Any image with a style="..." attribute is exempt from the squish. Same logic as the decorative code exemption: inline styles means you're spending effort to make things Just So, and the only point of the squish is to save your time when you don't want to spend effort. (Sidenote: we can't use the width/height attributes as this kind of signal, because casual "share" copypasta often has large w/h values.)
Use img width/height attributes as the maximum size for the zoomed-in state. Nicer zoom behavior when using an over-resolution image to look good on retina screens.

Commit: f41dcc472c352a3509dc7c2cf4aa033687139e6c https://github.com/dreamwidth/dw-free/commit/f41dcc472c352a3509dc7c2cf4aa033687139e6c Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/mobile/post.bml

Log Message:

[#2833] fix postevent error in mobile/post

This follows the structure of do_request as used elsewhere on the site, bypassing the obsolete password lookup by telling the protocol layer that the user's authentication was already checked earlier on the page.

Commit: 052fd74074f3198333280c678b85eb7cb48ed6f3 https://github.com/dreamwidth/dw-free/commit/052fd74074f3198333280c678b85eb7cb48ed6f3 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/mobile/index.bml M htdocs/mobile/login.bml

Log Message:

other minor mobile page fixes

If the user is logged in, the index link to /mobile/login says "log out" but clicking it did not actually log the user out. Now it does.
Fixes a missing space in the "logged in as [username]" text.

Commit: 13febca73dee4aaa872994ac7efab708720f2418 https://github.com/dreamwidth/dw-free/commit/13febca73dee4aaa872994ac7efab708720f2418 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

[#2832] Don't drop edit reason when previewing a comment edit

This is a relative of #2724 -- old preview would propagate unrecognized fields as hidden values, so while the preview form wouldn't show you the edit reason, it would retain it. The new preview actually includes an edit reason field, but blanks out whatever value you entered before previewing (or resets it to the saved edit reason, if this is the second+ edit).

Easy enough fix; it's just the talkform wasn't expecting to receive that field in a partial form submission.

Commit: 759c0a7e7774575c05fa02118c10887f1b23f79a https://github.com/dreamwidth/dw-free/commit/759c0a7e7774575c05fa02118c10887f1b23f79a Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

Honor a blank edit reason on preview

...instead of bringing back the previously saved edit reason if you preview with an empty one.

Commit: 5cfbbb0b0d8b4fac33cb65285cc7f3aa5ca73f22 https://github.com/dreamwidth/dw-free/commit/5cfbbb0b0d8b4fac33cb65285cc7f3aa5ca73f22 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

tidy

Commit: 45da65a77ae2df1682170b6901fd59148fcbca45 https://github.com/dreamwidth/dw-free/commit/45da65a77ae2df1682170b6901fd59148fcbca45 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Global/Defaults.pm

Log Message:

Remove unused config variable %LJ::VALID_PAGE_NOTICES

No idea what this ever did.

Commit: d257d72bcc370fcba689c6944405b1b3e7cae279 https://github.com/dreamwidth/dw-free/commit/d257d72bcc370fcba689c6944405b1b3e7cae279 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M views/dev/style-guide.tt

Log Message:

Fix uninitialized value warnings in dev/style-guide.tt

Each missing id value generated the following warning:

Use of uninitialized value in concatenation (.) or string at cgi-bin/DW/Template/Plugin/FormHTML.pm line 438.

Each missing name value generated a different warning:

Use of uninitialized value $key in string eq at /usr/share/perl5/Hash/MultiValue.pm line 80.

Commit: 6a7b4067108c7adf28f3278df2fd1457eb0a81f4 https://github.com/dreamwidth/dw-free/commit/6a7b4067108c7adf28f3278df2fd1457eb0a81f4 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M etc/config.pl.example M etc/kubernetes/web/secrets/config.pl

Log Message:

Remove unused config variables $MSG_DB_UNAVAILABLE and $MSG_NO_COMMENT

One was commented out, but neither was ever used anywhere in any case.

Commit: 938682cf0e70b5ef70023d38b3582917d9b777c3 https://github.com/dreamwidth/dw-free/commit/938682cf0e70b5ef70023d38b3582917d9b777c3 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Request.pm M cgi-bin/DW/Request/Apache2.pm M cgi-bin/DW/Request/Standard.pm

Log Message:

Remove call_bml method from DW::Request modules

We never used this anywhere and I don't think we're about to start.

Commit: 3da4059f41b91c93259dfdb3e8df4c08dd41cf47 https://github.com/dreamwidth/dw-free/commit/3da4059f41b91c93259dfdb3e8df4c08dd41cf47 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Admin/Props.pm

Log Message:

Fix two small glitches in /admin/entryprops

I discovered that if the pasted URL had trailing whitespace, the form would silently fail. So two fixes:

Use LJ::trim to remove any trailing whitespace from the input.
Pass errors back to the template to show what went wrong.

Commit: 6332020bb5061e4ae6b53598dbef13aaafcc96f7 https://github.com/dreamwidth/dw-free/commit/6332020bb5061e4ae6b53598dbef13aaafcc96f7 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:

cleanup spamreports & userlog

These two tables already had widened the ip column, but needed cleanup in the declarations. The spamreports table was still being created with the smaller column size, and the userlog table was calling do_alter with the wrong table name in the first argument of the function call.

Commit: 06db0e4ff9e74f6decfbfc1d2c4776ececf670cd https://github.com/dreamwidth/dw-free/commit/06db0e4ff9e74f6decfbfc1d2c4776ececf670cd Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:

widen ip column for tempanonips

Same as for spamreports and userlog, except for the additional NOT NULL value constraint on the column.

Commit: c156e856e062d64090137491fa00c21954c236f8 https://github.com/dreamwidth/dw-free/commit/c156e856e062d64090137491fa00c21954c236f8 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:

widen ip column for loginlog

Commit: cc56dbf6837e910538ea7d727f762b0074ca2454 https://github.com/dreamwidth/dw-free/commit/cc56dbf6837e910538ea7d727f762b0074ca2454 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm A cgi-bin/DW/Controller/Inbox.pm M cgi-bin/LJ/User/Icons.pm M cgi-bin/LJ/Web.pm M htdocs/js/components/jquery.icon-browser.js A htdocs/js/components/jquery.icon-select.js M htdocs/js/foundation/foundation/foundation.reveal.js A htdocs/js/jquery.inbox.js A htdocs/scss/components/icon-select.scss A views/components/icon-select-dropdown.tt A views/components/icon-select-icon.tt A views/inbox/compose.tt

Log Message:

Initial refactor of icon components

Commit: 3f9227e800824be59db67413874ab7f7003f4327 https://github.com/dreamwidth/dw-free/commit/3f9227e800824be59db67413874ab7f7003f4327 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm R cgi-bin/DW/Controller/Inbox.pm M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/User/Icons.pm M cgi-bin/LJ/Web.pm M htdocs/js/pages/entry/new.js M t/userpic-keyword-select.t M views/components/icon-select-icon.tt M views/entry/form.tt M views/entry/module-icons.tt R views/inbox/compose.tt

Log Message:

Cleanup for icon components

Commit: 0ce41f835cbab0e0ec404f85af19ad0ccf3539df https://github.com/dreamwidth/dw-free/commit/0ce41f835cbab0e0ec404f85af19ad0ccf3539df Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/js/components/jquery.icon-select.js M htdocs/js/foundation/foundation/foundation.reveal.js R htdocs/js/jquery.inbox.js

Log Message:

remove debug prints

Commit: b14b08b86766d23e3b0156a0c905a6528b492196 https://github.com/dreamwidth/dw-free/commit/b14b08b86766d23e3b0156a0c905a6528b492196 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/Web.pm M htdocs/js/components/jquery.icon-browser.js M htdocs/js/jquery.replyforms.js M htdocs/scss/components/icon-select.scss M htdocs/scss/components/quick-reply.scss M htdocs/scss/pages/entry/new.scss M views/components/icon-select-icon.tt M views/entry/module-icons.tt M views/journal/quickreply.tt M views/journal/talkform.tt

Log Message:

working icon components everywhere but replypage

Commit: 99c856a51013ef32ea0ef7985d2cb38c595cdccf https://github.com/dreamwidth/dw-free/commit/99c856a51013ef32ea0ef7985d2cb38c595cdccf Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/Web.pm M views/journal/talkform.tt

Log Message:

Fix replypage, run tidy

Commit: 2878e9a2172af8627d41c70cf2d2f3b95c8cd29f https://github.com/dreamwidth/dw-free/commit/2878e9a2172af8627d41c70cf2d2f3b95c8cd29f Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/js/components/jquery.icon-select.js M htdocs/js/pages/entry/new.js M htdocs/scss/components/icon-select.scss M htdocs/scss/pages/entry/new.scss M views/components/icon-browser.tt M views/components/icon-select-icon.tt M views/entry/module-icons.tt M views/journal/talkform.tt

Log Message:

clean up non-foundation icon views

Commit: 1b08cdd180ca28abc76f413b21cb1333baa9d5bc https://github.com/dreamwidth/dw-free/commit/1b08cdd180ca28abc76f413b21cb1333baa9d5bc Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M views/entry/module-icons.tt

Log Message:

Don't show dropdown when there are no icons

Commit: 1789476dd496135306d4177cef0b120aa37256f3 https://github.com/dreamwidth/dw-free/commit/1789476dd496135306d4177cef0b120aa37256f3 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/scss/components/icon-select.scss M views/entry/module-icons.tt

Log Message:

Fix issues with beta create page

Commit: 148eca222e3b60a71fc88d17c0035d31c8c915cd https://github.com/dreamwidth/dw-free/commit/148eca222e3b60a71fc88d17c0035d31c8c915cd Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm M views/journal/talkform.tt

Log Message:

Make instead of mutating directly

Commit: e917ea9ce3e820d62e3edd734cc905abec176ddd https://github.com/dreamwidth/dw-free/commit/e917ea9ce3e820d62e3edd734cc905abec176ddd Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

Fix bareword error

Commit: 221eb6464d48c910630e57a94b34e0e98a3f547c https://github.com/dreamwidth/dw-free/commit/221eb6464d48c910630e57a94b34e0e98a3f547c Author: Kareila kareila@dreamwidth.org Date: 2020-12-10 (Thu, 10 Dec 2020)

Changed paths: M htdocs/stc/faq.css M views/support/faqsearch.tt

Log Message:

reformat converted FAQ Search page

Commit: cf36653ebbfd6878f362dd125eb1bdf14c874037 https://github.com/dreamwidth/dw-free/commit/cf36653ebbfd6878f362dd125eb1bdf14c874037 Author: Ruth momijizukamori@gmail.com Date: 2021-01-08 (Fri, 08 Jan 2021)

Changed paths: M cgi-bin/DW/Auth/Helpers.pm M cgi-bin/DW/Auth/TOTP.pm M cgi-bin/LJ/Auth.pm M cgi-bin/ljlib.pl M doc/dependencies-cpanm

Log Message:

Use Math::Random::Secure for auth generation

Commit: 96da547d6a930b2eed27cf3970c319221a4ab297 https://github.com/dreamwidth/dw-free/commit/96da547d6a930b2eed27cf3970c319221a4ab297 Author: Mark Smith mark@dreamwidth.org Date: 2021-01-29 (Fri, 29 Jan 2021)

Changed paths: M htdocs/manage/settings/index.bml

Log Message:

This...is broken in prod?

Commit: ab049dcf8e56ad6bd3c950bfefcbe086fbdddf16 https://github.com/dreamwidth/dw-free/commit/ab049dcf8e56ad6bd3c950bfefcbe086fbdddf16 Author: Jen kareila@dreamwidth.org Date: 2021-01-29 (Fri, 29 Jan 2021)

Changed paths: M bin/upgrading/make_system.pl

Log Message:

make sure the initial system user is associated with a journal style (#2858)

Add a call to set_default_style after creating the user object.

Compare: https://github.com/dreamwidth/dw-free/compare/140ffda28a92...ab049dcf8e56