github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2021-02-05 03:37 pm
  • Add Memory
  • Share This Entry

[dreamwidth/dw-free] b4be9b: Remove unused click handler

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: b4be9b0f666ac266c2b8c1ed8589d6bded8ec88f https://github.com/dreamwidth/dw-free/commit/b4be9b0f666ac266c2b8c1ed8589d6bded8ec88f Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js

Log Message:

Remove unused click handler

Now that it's a one-click interaction, the select button is gone.

Commit: 210d5dc9b4708ec2d717a801696170fc8d926240 https://github.com/dreamwidth/dw-free/commit/210d5dc9b4708ec2d717a801696170fc8d926240 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js

Log Message:

Remove redundant click trigger on enter key

This was an accessibility workaround for when we were misusing <a> elements instead of using proper <button>s. Now that we get the default accessible button behavior, this is cruft.

Commit: cdb5842f57f1bf547bd888144abfce3fb4e2e9cb https://github.com/dreamwidth/dw-free/commit/cdb5842f57f1bf547bd888144abfce3fb4e2e9cb Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M htdocs/js/components/jquery.icon-browser.js M htdocs/scss/components/icon-browser.scss M views/components/icon-browser.tt

Log Message:

Add show/hide button for icon browser options on mobile

The display options take up way too much space on mobile, and presumably you like what you like and aren't changing them every time!

So at small viewport sizes, this commit hides the options behind a toggle button.

  • It goes right above+before the search field. If you summon the browser without an icon already selected, the search field is the first thing focused, so you don't have to tab through the options toggle before reaching the icons if you're keyboard-navvin.

  • For sighted users: The button is styled to look like a cut tag or a <details> element (with the little open/close disclosure triangle), which DW users should be intimately familiar with. Its text includes a summary of the currently selected options.

  • For screen readers: I'm using an aria-label instead of the current options summary, because they won't have the visual cue of the disclosure triangle.

    Commit: ca17b1420222b10563ca82367a955a0ccff89f9f https://github.com/dreamwidth/dw-free/commit/ca17b1420222b10563ca82367a955a0ccff89f9f Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

    Changed paths: M htdocs/js/components/jquery.icon-browser.js M htdocs/js/components/jquery.icon-select.js M views/components/icon-select-dropdown.tt M views/components/icon-select-icon.tt M views/journal/quickreply.tt M views/journal/talkform.tt

    Log Message:

Restore missing behavior: focus comment body on dismissal

This went missing after #2840.

Commit: de017f8fb389a476ab309d957cd7c4a7c8dc25bd https://github.com/dreamwidth/dw-free/commit/de017f8fb389a476ab309d957cd7c4a7c8dc25bd Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-05 (Fri, 05 Feb 2021)

Changed paths: M views/components/icon-browser.tt

Log Message:

Use same inline styles for disclosure triangle that we use in cut tags

Compare: https://github.com/dreamwidth/dw-free/compare/2b83bc55f687...de017f8fb389