changelog | Dec. 6th, 2020

Dec. 6th, 2020

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: f41dcc472c352a3509dc7c2cf4aa033687139e6c https://github.com/dreamwidth/dw-free/commit/f41dcc472c352a3509dc7c2cf4aa033687139e6c Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/mobile/post.bml

Log Message:

[#2833] fix postevent error in mobile/post

This follows the structure of do_request as used elsewhere on the site, bypassing the obsolete password lookup by telling the protocol layer that the user's authentication was already checked earlier on the page.

Commit: 052fd74074f3198333280c678b85eb7cb48ed6f3 https://github.com/dreamwidth/dw-free/commit/052fd74074f3198333280c678b85eb7cb48ed6f3 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/mobile/index.bml M htdocs/mobile/login.bml

Log Message:

other minor mobile page fixes

If the user is logged in, the index link to /mobile/login says "log out" but clicking it did not actually log the user out. Now it does.
Fixes a missing space in the "logged in as [username]" text.

Compare: https://github.com/dreamwidth/dw-free/compare/caf70f3ff5fc...052fd74074f3

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 13febca73dee4aaa872994ac7efab708720f2418 https://github.com/dreamwidth/dw-free/commit/13febca73dee4aaa872994ac7efab708720f2418 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

[#2832] Don't drop edit reason when previewing a comment edit

This is a relative of #2724 -- old preview would propagate unrecognized fields as hidden values, so while the preview form wouldn't show you the edit reason, it would retain it. The new preview actually includes an edit reason field, but blanks out whatever value you entered before previewing (or resets it to the saved edit reason, if this is the second+ edit).

Easy enough fix; it's just the talkform wasn't expecting to receive that field in a partial form submission.

Commit: 759c0a7e7774575c05fa02118c10887f1b23f79a https://github.com/dreamwidth/dw-free/commit/759c0a7e7774575c05fa02118c10887f1b23f79a Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

Honor a blank edit reason on preview

...instead of bringing back the previously saved edit reason if you preview with an empty one.

Commit: 5cfbbb0b0d8b4fac33cb65285cc7f3aa5ca73f22 https://github.com/dreamwidth/dw-free/commit/5cfbbb0b0d8b4fac33cb65285cc7f3aa5ca73f22 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

tidy

Compare: https://github.com/dreamwidth/dw-free/compare/052fd74074f3...5cfbbb0b0d8b

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 45da65a77ae2df1682170b6901fd59148fcbca45 https://github.com/dreamwidth/dw-free/commit/45da65a77ae2df1682170b6901fd59148fcbca45 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Global/Defaults.pm

Log Message:

Remove unused config variable %LJ::VALID_PAGE_NOTICES

No idea what this ever did.

Commit: d257d72bcc370fcba689c6944405b1b3e7cae279 https://github.com/dreamwidth/dw-free/commit/d257d72bcc370fcba689c6944405b1b3e7cae279 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M views/dev/style-guide.tt

Log Message:

Fix uninitialized value warnings in dev/style-guide.tt

Each missing id value generated the following warning:

Use of uninitialized value in concatenation (.) or string at cgi-bin/DW/Template/Plugin/FormHTML.pm line 438.

Each missing name value generated a different warning:

Use of uninitialized value $key in string eq at /usr/share/perl5/Hash/MultiValue.pm line 80.

Commit: 6a7b4067108c7adf28f3278df2fd1457eb0a81f4 https://github.com/dreamwidth/dw-free/commit/6a7b4067108c7adf28f3278df2fd1457eb0a81f4 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M etc/config.pl.example M etc/kubernetes/web/secrets/config.pl

Log Message:

Remove unused config variables $MSG_DB_UNAVAILABLE and $MSG_NO_COMMENT

One was commented out, but neither was ever used anywhere in any case.

Commit: 938682cf0e70b5ef70023d38b3582917d9b777c3 https://github.com/dreamwidth/dw-free/commit/938682cf0e70b5ef70023d38b3582917d9b777c3 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Request.pm M cgi-bin/DW/Request/Apache2.pm M cgi-bin/DW/Request/Standard.pm

Log Message:

Remove call_bml method from DW::Request modules

We never used this anywhere and I don't think we're about to start.

Commit: 3da4059f41b91c93259dfdb3e8df4c08dd41cf47 https://github.com/dreamwidth/dw-free/commit/3da4059f41b91c93259dfdb3e8df4c08dd41cf47 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Admin/Props.pm

Log Message:

Fix two small glitches in /admin/entryprops

I discovered that if the pasted URL had trailing whitespace, the form would silently fail. So two fixes:

Use LJ::trim to remove any trailing whitespace from the input.
Pass errors back to the template to show what went wrong.

Compare: https://github.com/dreamwidth/dw-free/compare/5cfbbb0b0d8b...3da4059f41b9

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 6332020bb5061e4ae6b53598dbef13aaafcc96f7 https://github.com/dreamwidth/dw-free/commit/6332020bb5061e4ae6b53598dbef13aaafcc96f7 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:

cleanup spamreports & userlog

These two tables already had widened the ip column, but needed cleanup in the declarations. The spamreports table was still being created with the smaller column size, and the userlog table was calling do_alter with the wrong table name in the first argument of the function call.

Commit: 06db0e4ff9e74f6decfbfc1d2c4776ececf670cd https://github.com/dreamwidth/dw-free/commit/06db0e4ff9e74f6decfbfc1d2c4776ececf670cd Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:

widen ip column for tempanonips

Same as for spamreports and userlog, except for the additional NOT NULL value constraint on the column.

Commit: c156e856e062d64090137491fa00c21954c236f8 https://github.com/dreamwidth/dw-free/commit/c156e856e062d64090137491fa00c21954c236f8 Author: Kareila kareila@dreamwidth.org Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:

widen ip column for loginlog

Compare: https://github.com/dreamwidth/dw-free/compare/3da4059f41b9...c156e856e062

github

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: cc56dbf6837e910538ea7d727f762b0074ca2454 https://github.com/dreamwidth/dw-free/commit/cc56dbf6837e910538ea7d727f762b0074ca2454 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm A cgi-bin/DW/Controller/Inbox.pm M cgi-bin/LJ/User/Icons.pm M cgi-bin/LJ/Web.pm M htdocs/js/components/jquery.icon-browser.js A htdocs/js/components/jquery.icon-select.js M htdocs/js/foundation/foundation/foundation.reveal.js A htdocs/js/jquery.inbox.js A htdocs/scss/components/icon-select.scss A views/components/icon-select-dropdown.tt A views/components/icon-select-icon.tt A views/inbox/compose.tt

Log Message:

Initial refactor of icon components

Commit: 3f9227e800824be59db67413874ab7f7003f4327 https://github.com/dreamwidth/dw-free/commit/3f9227e800824be59db67413874ab7f7003f4327 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm R cgi-bin/DW/Controller/Inbox.pm M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/User/Icons.pm M cgi-bin/LJ/Web.pm M htdocs/js/pages/entry/new.js M t/userpic-keyword-select.t M views/components/icon-select-icon.tt M views/entry/form.tt M views/entry/module-icons.tt R views/inbox/compose.tt

Log Message:

Cleanup for icon components

Commit: 0ce41f835cbab0e0ec404f85af19ad0ccf3539df https://github.com/dreamwidth/dw-free/commit/0ce41f835cbab0e0ec404f85af19ad0ccf3539df Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/js/components/jquery.icon-select.js M htdocs/js/foundation/foundation/foundation.reveal.js R htdocs/js/jquery.inbox.js

Log Message:

remove debug prints

Commit: b14b08b86766d23e3b0156a0c905a6528b492196 https://github.com/dreamwidth/dw-free/commit/b14b08b86766d23e3b0156a0c905a6528b492196 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/Web.pm M htdocs/js/components/jquery.icon-browser.js M htdocs/js/jquery.replyforms.js M htdocs/scss/components/icon-select.scss M htdocs/scss/components/quick-reply.scss M htdocs/scss/pages/entry/new.scss M views/components/icon-select-icon.tt M views/entry/module-icons.tt M views/journal/quickreply.tt M views/journal/talkform.tt

Log Message:

working icon components everywhere but replypage

Commit: 99c856a51013ef32ea0ef7985d2cb38c595cdccf https://github.com/dreamwidth/dw-free/commit/99c856a51013ef32ea0ef7985d2cb38c595cdccf Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/Web.pm M views/journal/talkform.tt

Log Message:

Fix replypage, run tidy

Commit: 2878e9a2172af8627d41c70cf2d2f3b95c8cd29f https://github.com/dreamwidth/dw-free/commit/2878e9a2172af8627d41c70cf2d2f3b95c8cd29f Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/js/components/jquery.icon-select.js M htdocs/js/pages/entry/new.js M htdocs/scss/components/icon-select.scss M htdocs/scss/pages/entry/new.scss M views/components/icon-browser.tt M views/components/icon-select-icon.tt M views/entry/module-icons.tt M views/journal/talkform.tt

Log Message:

clean up non-foundation icon views

Commit: 1b08cdd180ca28abc76f413b21cb1333baa9d5bc https://github.com/dreamwidth/dw-free/commit/1b08cdd180ca28abc76f413b21cb1333baa9d5bc Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M views/entry/module-icons.tt

Log Message:

Don't show dropdown when there are no icons

Commit: 1789476dd496135306d4177cef0b120aa37256f3 https://github.com/dreamwidth/dw-free/commit/1789476dd496135306d4177cef0b120aa37256f3 Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M htdocs/scss/components/icon-select.scss M views/entry/module-icons.tt

Log Message:

Fix issues with beta create page

Commit: 148eca222e3b60a71fc88d17c0035d31c8c915cd https://github.com/dreamwidth/dw-free/commit/148eca222e3b60a71fc88d17c0035d31c8c915cd Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm M views/journal/talkform.tt

Log Message:

Make instead of mutating directly

Commit: e917ea9ce3e820d62e3edd734cc905abec176ddd https://github.com/dreamwidth/dw-free/commit/e917ea9ce3e820d62e3edd734cc905abec176ddd Author: Ruth momijizukamori@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:

Fix bareword error

Compare: https://github.com/dreamwidth/dw-free/compare/c156e856e062...e917ea9ce3e8