github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2020-12-06 09:55 pm

[dreamwidth/dw-free] 13febc: [#2832] Don't drop edit reason when previewing a c...

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 13febca73dee4aaa872994ac7efab708720f2418 https://github.com/dreamwidth/dw-free/commit/13febca73dee4aaa872994ac7efab708720f2418 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:


[#2832] Don't drop edit reason when previewing a comment edit

This is a relative of #2724 -- old preview would propagate unrecognized fields as hidden values, so while the preview form wouldn't show you the edit reason, it would retain it. The new preview actually includes an edit reason field, but blanks out whatever value you entered before previewing (or resets it to the saved edit reason, if this is the second+ edit).

Easy enough fix; it's just the talkform wasn't expecting to receive that field in a partial form submission.

Commit: 759c0a7e7774575c05fa02118c10887f1b23f79a https://github.com/dreamwidth/dw-free/commit/759c0a7e7774575c05fa02118c10887f1b23f79a Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:


Honor a blank edit reason on preview

...instead of bringing back the previously saved edit reason if you preview with an empty one.

Commit: 5cfbbb0b0d8b4fac33cb65285cc7f3aa5ca73f22 https://github.com/dreamwidth/dw-free/commit/5cfbbb0b0d8b4fac33cb65285cc7f3aa5ca73f22 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-12-06 (Sun, 06 Dec 2020)

Changed paths: M cgi-bin/LJ/Talk.pm

Log Message:


tidy

Compare: https://github.com/dreamwidth/dw-free/compare/052fd74074f3...5cfbbb0b0d8b


Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org