![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
githubBranch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 94d0e083afd9c3c7c0e30c1cc752a6888ad89a2c
https://github.com/dreamwidth/dw-free/commit/94d0e083afd9c3c7c0e30c1cc752a6888ad89a2c
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
R htdocs/js/jquery.radioreveal.js
Log Message:
-----------
Delete jquery.radioreveal.js, which isn't used anywhere
Afuna confirms this was part of early work on the beta new entry page, and was
abandoned when some controls were switched to dropdowns/fancyselects.
Commit: f114538c031f4e3168205a1a1b5ddfaba6914a5b
https://github.com/dreamwidth/dw-free/commit/f114538c031f4e3168205a1a1b5ddfaba6914a5b
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/jquery.quickreply.js
R htdocs/js/jquery.quotebutton.js
A htdocs/js/jquery.replyforms.js
A htdocs/js/jquery.talkform.js
R htdocs/js/talkpost.js
M htdocs/scss/components/quick-reply.scss
A htdocs/scss/components/talkform.scss
M htdocs/talkpost_do.bml
M styles/venture/layout.s2
M views/journal/quickreply.tt
M views/journal/talkform.tt
Log Message:
-----------
Rewrite talkform javascript
- Deduplicate some shared reply form logic into jquery.replyforms.js.
- Add the max comment length constant to the Site object.
- Change how the quote button is added -- now it's a real button in the
markup that gets unhidden, instead of a span that gets a button appended
to it.
- Change some quickreply JS logic.
- Move custom form submit logic into a submit handler instead of button
click handlers.
- Fix bug where QR from reading page wouldn't let you proceed if there was
a captcha. Now it goes to talkform, like QR from comment page does.
- Replace finely minced talkform JS with a small amount of jQuery.
- Use constant for max username length.
- Stop doing the MD5 password hash thing to avoid sending password over the
wire, since it goes over TLS now.
- Delete globally inlined function to do same (but don't worry, it's only
one of at least three functionally identical implementations).
- Instead of complaining about incoherent combination of form fields, just
prevent it.
- Match behavior of "From" radio buttons to apparent intended behavior:
- Instead of magic "`[other]`" link, just always show the other site
user option.
- When unselecting an option that has associated auth fields (other
openid user, other site user), hide those fields and also reset them
to their initial values. (Old JS did the one but not the other.)
- Simplify markup of "From" radio buttons in talkform.
- Use disabled radio inputs instead of ascii art `()`.
- Instead of jumping through outrageous hoops to split the label in half and
put the radio button in the middle, just include the image in the label.
- Basic divs instead of unnecessary sub-table of unnecessary table.
Commit: 9da06a76fe1383b294fa123bd3fd3226aae308ea
https://github.com/dreamwidth/dw-free/commit/9da06a76fe1383b294fa123bd3fd3226aae308ea
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M views/journal/talkform.tt
Log Message:
-----------
Add class='disabled' to labels of disabled 'from' options
Compare: https://github.com/dreamwidth/dw-free/compare/eee1a232996f...9da06a76fe13
Home: https://github.com/dreamwidth/dw-free
Commit: 94d0e083afd9c3c7c0e30c1cc752a6888ad89a2c
https://github.com/dreamwidth/dw-free/commit/94d0e083afd9c3c7c0e30c1cc752a6888ad89a2c
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
R htdocs/js/jquery.radioreveal.js
Log Message:
-----------
Delete jquery.radioreveal.js, which isn't used anywhere
Afuna confirms this was part of early work on the beta new entry page, and was
abandoned when some controls were switched to dropdowns/fancyselects.
Commit: f114538c031f4e3168205a1a1b5ddfaba6914a5b
https://github.com/dreamwidth/dw-free/commit/f114538c031f4e3168205a1a1b5ddfaba6914a5b
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/jquery.quickreply.js
R htdocs/js/jquery.quotebutton.js
A htdocs/js/jquery.replyforms.js
A htdocs/js/jquery.talkform.js
R htdocs/js/talkpost.js
M htdocs/scss/components/quick-reply.scss
A htdocs/scss/components/talkform.scss
M htdocs/talkpost_do.bml
M styles/venture/layout.s2
M views/journal/quickreply.tt
M views/journal/talkform.tt
Log Message:
-----------
Rewrite talkform javascript
- Deduplicate some shared reply form logic into jquery.replyforms.js.
- Add the max comment length constant to the Site object.
- Change how the quote button is added -- now it's a real button in the
markup that gets unhidden, instead of a span that gets a button appended
to it.
- Change some quickreply JS logic.
- Move custom form submit logic into a submit handler instead of button
click handlers.
- Fix bug where QR from reading page wouldn't let you proceed if there was
a captcha. Now it goes to talkform, like QR from comment page does.
- Replace finely minced talkform JS with a small amount of jQuery.
- Use constant for max username length.
- Stop doing the MD5 password hash thing to avoid sending password over the
wire, since it goes over TLS now.
- Delete globally inlined function to do same (but don't worry, it's only
one of at least three functionally identical implementations).
- Instead of complaining about incoherent combination of form fields, just
prevent it.
- Match behavior of "From" radio buttons to apparent intended behavior:
- Instead of magic "`[other]`" link, just always show the other site
user option.
- When unselecting an option that has associated auth fields (other
openid user, other site user), hide those fields and also reset them
to their initial values. (Old JS did the one but not the other.)
- Simplify markup of "From" radio buttons in talkform.
- Use disabled radio inputs instead of ascii art `()`.
- Instead of jumping through outrageous hoops to split the label in half and
put the radio button in the middle, just include the image in the label.
- Basic divs instead of unnecessary sub-table of unnecessary table.
Commit: 9da06a76fe1383b294fa123bd3fd3226aae308ea
https://github.com/dreamwidth/dw-free/commit/9da06a76fe1383b294fa123bd3fd3226aae308ea
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M views/journal/talkform.tt
Log Message:
-----------
Add class='disabled' to labels of disabled 'from' options
Compare: https://github.com/dreamwidth/dw-free/compare/eee1a232996f...9da06a76fe13