![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
[dreamwidth/dw-free] 16410b: Delete jquery.radioreveal.js, which isn't used any...
Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 16410b6467677bbb8ea6927458953a06f7051a43
https://github.com/dreamwidth/dw-free/commit/16410b6467677bbb8ea6927458953a06f7051a43
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
R htdocs/js/jquery.radioreveal.js
Log Message:
-----------
Delete jquery.radioreveal.js, which isn't used anywhere
Afuna confirms this was part of early work on the beta new entry page, and was
abandoned when some controls were switched to dropdowns/fancyselects.
Commit: 1c0214881db4ba52131aac343c29a7ec9fc95810
https://github.com/dreamwidth/dw-free/commit/1c0214881db4ba52131aac343c29a7ec9fc95810
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/jquery.quickreply.js
R htdocs/js/jquery.quotebutton.js
A htdocs/js/jquery.replyforms.js
A htdocs/js/jquery.talkform.js
R htdocs/js/talkpost.js
M htdocs/scss/components/quick-reply.scss
A htdocs/scss/components/talkform.scss
M htdocs/talkpost_do.bml
M styles/venture/layout.s2
M views/journal/quickreply.tt
M views/journal/talkform.tt
Log Message:
-----------
Rewrite talkform javascript
- Deduplicate some shared reply form logic into jquery.replyforms.js.
- Add the max comment length constant to the Site object.
- Change how the quote button is added -- now it's a real button in the
markup that gets unhidden, instead of a span that gets a button appended
to it.
- Change some quickreply JS logic.
- Move custom form submit logic into a submit handler instead of button
click handlers.
- Fix bug where QR from reading page wouldn't let you proceed if there was
a captcha. Now it goes to talkform, like QR from comment page does.
- Replace finely minced talkform JS with a small amount of jQuery.
- Use constant for max username length.
- Stop doing the MD5 password hash thing to avoid sending password over the
wire, since it goes over TLS now.
- Delete globally inlined function to do same (but don't worry, it's only
one of at least three functionally identical implementations).
- Instead of complaining about incoherent combination of form fields, just
prevent it.
- Match behavior of "From" radio buttons to apparent intended behavior:
- Instead of magic "`[other]`" link, just always show the other site
user option.
- When unselecting an option that has associated auth fields (other
openid user, other site user), hide those fields and also reset them
to their initial values. (Old JS did the one but not the other.)
- Simplify markup of "From" radio buttons in talkform.
- Use disabled radio inputs instead of ascii art `()`.
- Instead of jumping through outrageous hoops to split the label in half and
put the radio button in the middle, just include the image in the label.
- Basic divs instead of unnecessary sub-table of unnecessary table.
Commit: 2c3a2897801d52a60aa06477ed3287dd931ba8f9
https://github.com/dreamwidth/dw-free/commit/2c3a2897801d52a60aa06477ed3287dd931ba8f9
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M views/journal/talkform.tt
Log Message:
-----------
Add class='disabled' to labels of disabled 'from' options
Commit: 7150aba3932fa7d6fb2a73efe1908d51588179f3
https://github.com/dreamwidth/dw-free/commit/7150aba3932fa7d6fb2a73efe1908d51588179f3
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M styles/motion/layout.s2
Log Message:
-----------
Styles: Purify "Motion" layout of the taint of Zalgo
- No one with their reason still intact needs THAT many `float`s.
- Those `overflow: hidden`s are some kind of awful float containment hack.
- It looks like you THOUGHT you were using border-box sizing, so maybe let's
actually use it.
Commit: 3128dd2492a9987eb930a56e5066ce2074378427
https://github.com/dreamwidth/dw-free/commit/3128dd2492a9987eb930a56e5066ce2074378427
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M styles/motion/layout.s2
Log Message:
-----------
Styles: Motion: Match intended object layout without exploding
Also:
- I can't believe no one's complained about paragraphs being broken yet. :|
- The borderless buttons weren't even a legitimate style choice; the CSS reset
did that, and then the designer never actually went back and styled them. :|
Compare: https://github.com/dreamwidth/dw-free/compare/a8d0cebfde10...3128dd2492a9
Home: https://github.com/dreamwidth/dw-free
Commit: 16410b6467677bbb8ea6927458953a06f7051a43
https://github.com/dreamwidth/dw-free/commit/16410b6467677bbb8ea6927458953a06f7051a43
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
R htdocs/js/jquery.radioreveal.js
Log Message:
-----------
Delete jquery.radioreveal.js, which isn't used anywhere
Afuna confirms this was part of early work on the beta new entry page, and was
abandoned when some controls were switched to dropdowns/fancyselects.
Commit: 1c0214881db4ba52131aac343c29a7ec9fc95810
https://github.com/dreamwidth/dw-free/commit/1c0214881db4ba52131aac343c29a7ec9fc95810
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/jquery.quickreply.js
R htdocs/js/jquery.quotebutton.js
A htdocs/js/jquery.replyforms.js
A htdocs/js/jquery.talkform.js
R htdocs/js/talkpost.js
M htdocs/scss/components/quick-reply.scss
A htdocs/scss/components/talkform.scss
M htdocs/talkpost_do.bml
M styles/venture/layout.s2
M views/journal/quickreply.tt
M views/journal/talkform.tt
Log Message:
-----------
Rewrite talkform javascript
- Deduplicate some shared reply form logic into jquery.replyforms.js.
- Add the max comment length constant to the Site object.
- Change how the quote button is added -- now it's a real button in the
markup that gets unhidden, instead of a span that gets a button appended
to it.
- Change some quickreply JS logic.
- Move custom form submit logic into a submit handler instead of button
click handlers.
- Fix bug where QR from reading page wouldn't let you proceed if there was
a captcha. Now it goes to talkform, like QR from comment page does.
- Replace finely minced talkform JS with a small amount of jQuery.
- Use constant for max username length.
- Stop doing the MD5 password hash thing to avoid sending password over the
wire, since it goes over TLS now.
- Delete globally inlined function to do same (but don't worry, it's only
one of at least three functionally identical implementations).
- Instead of complaining about incoherent combination of form fields, just
prevent it.
- Match behavior of "From" radio buttons to apparent intended behavior:
- Instead of magic "`[other]`" link, just always show the other site
user option.
- When unselecting an option that has associated auth fields (other
openid user, other site user), hide those fields and also reset them
to their initial values. (Old JS did the one but not the other.)
- Simplify markup of "From" radio buttons in talkform.
- Use disabled radio inputs instead of ascii art `()`.
- Instead of jumping through outrageous hoops to split the label in half and
put the radio button in the middle, just include the image in the label.
- Basic divs instead of unnecessary sub-table of unnecessary table.
Commit: 2c3a2897801d52a60aa06477ed3287dd931ba8f9
https://github.com/dreamwidth/dw-free/commit/2c3a2897801d52a60aa06477ed3287dd931ba8f9
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M views/journal/talkform.tt
Log Message:
-----------
Add class='disabled' to labels of disabled 'from' options
Commit: 7150aba3932fa7d6fb2a73efe1908d51588179f3
https://github.com/dreamwidth/dw-free/commit/7150aba3932fa7d6fb2a73efe1908d51588179f3
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M styles/motion/layout.s2
Log Message:
-----------
Styles: Purify "Motion" layout of the taint of Zalgo
- No one with their reason still intact needs THAT many `float`s.
- Those `overflow: hidden`s are some kind of awful float containment hack.
- It looks like you THOUGHT you were using border-box sizing, so maybe let's
actually use it.
Commit: 3128dd2492a9987eb930a56e5066ce2074378427
https://github.com/dreamwidth/dw-free/commit/3128dd2492a9987eb930a56e5066ce2074378427
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-01 (Mon, 01 Jul 2019)
Changed paths:
M styles/motion/layout.s2
Log Message:
-----------
Styles: Motion: Match intended object layout without exploding
Also:
- I can't believe no one's complained about paragraphs being broken yet. :|
- The borderless buttons weren't even a legitimate style choice; the CSS reset
did that, and then the designer never actually went back and styled them. :|
Compare: https://github.com/dreamwidth/dw-free/compare/a8d0cebfde10...3128dd2492a9