fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-06-18 08:20 am

[dw-free] Contextual hover for communities broken

[commit: http://hg.dwscoalition.org/dw-free/rev/1588b888ce48]

http://bugs.dwscoalition.org/show_bug.cgi?id=3750

Fix variable name, add a line break after the link to join/leave a
community.

Patch by [personal profile] fu.

Files modified:
  • htdocs/js/jquery.contextualhover.js
--------------------------------------------------------------------------------
diff -r a165d0911c25 -r 1588b888ce48 htdocs/js/jquery.contextualhover.js
--- a/htdocs/js/jquery.contextualhover.js	Fri Jun 17 16:14:24 2011 +0800
+++ b/htdocs/js/jquery.contextualhover.js	Sat Jun 18 16:20:17 2011 +0800
@@ -182,7 +182,7 @@
         var $membership = $("<span></span>");
         if ( ! data.is_closed_membership || data.is_member ) {
             var $membershiplink = $("<a></a>");
-            var $membershipaction = data.is_member ? "leave" : "join";
+            var membership_action = data.is_member ? "leave" : "join";
 
             if ( data.is_member )
                 $membershiplink.attr("href" , data.url_leavecomm ).html("Leave");
@@ -200,7 +200,7 @@
         } else {
             $membership.html("Community closed");
         }
-        $content.append($membership);
+        $content.append($membership, "<br />"   );
     }
 
     var links = [];
--------------------------------------------------------------------------------
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2011-06-18 10:33 am (UTC)(link)
I am so not grinning at that $ :)