[dw-free] http://bugs.dwscoalition.org/show_bug.cgi?id=3084

[fu]

[commit: http://hg.dwscoalition.org/dw-free/rev/5f58d69f09f4]

http://bugs.dwscoalition.org/show_bug.cgi?id=3084

Double-check sysban priv just to be sure.

Patch by denise.

Files modified:

• htdocs/admin/spamreports.bml

--------------------------------------------------------------------------------
diff -r 5bbc58fb6f45 -r 5f58d69f09f4 htdocs/admin/spamreports.bml
--- a/htdocs/admin/spamreports.bml	Tue Mar 29 10:50:28 2011 +0800
+++ b/htdocs/admin/spamreports.bml	Tue Mar 29 10:50:33 2011 +0800
@@ -233,7 +233,7 @@ _c?>
                 if ( $remote->has_priv( 'sysban' ) ) {
                     $extra .= "<br/><textarea name='sysban_note' rows='3' cols='60' readonly='1'>" . LJ::ehtml( $reason->{talk_ip_test}->{note} || "(no note)" ) . "</textarea>";
                 }
-            } else {
+            } elsif ( $remote && $remote->has_priv( 'sysban', 'talk_ip_test' ) ) {
                 $extra = LJ::html_check({name => "sysban_ip", value => $what, label => "Also Sysban IP?"});
                 $extra .= "<br/><textarea name='sysban_note' rows='3' cols='60'> ~" . LJ::ehtml( $remote->username . " @ " . LJ::mysql_time() ) . "</textarea>";
             }
@@ -251,7 +251,7 @@ _c?>
         my $in = join("','", map { $_+0 } @srids);
         $in = "'$in'";
 
-        if ($POST{sysban_ip} && !LJ::sysban_validate("talk_ip_test", $POST{sysban_ip})) {
+        if ($POST{sysban_ip} && $remote && $remote->has_priv( 'sysban', "talk_ip_test" ) && !LJ::sysban_validate("talk_ip_test", $POST{sysban_ip})) {
             LJ::sysban_create(what => 'talk_ip_test', value => $POST{sysban_ip}, bandays => 0, note => ( $POST{sysban_note} || 'anonymous spamreports' ) );
         }
 
--------------------------------------------------------------------------------