fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-02-21 08:24 am

[dw-free] Styles: remove the H3 heading for subject icons

[commit: http://hg.dwscoalition.org/dw-free/rev/29b9efda8308]

http://bugs.dwscoalition.org/show_bug.cgi?id=3463

Use div, rather than an h3 tag for comment subject icons. Fix CSS that
expects this to be an h3.

Patch by [personal profile] ninetydegrees.

Files modified:
  • bin/upgrading/s2layers/core2.s2
  • bin/upgrading/s2layers/drifting/layout.s2
--------------------------------------------------------------------------------
diff -r c91c75c581b8 -r 29b9efda8308 bin/upgrading/s2layers/core2.s2
--- a/bin/upgrading/s2layers/core2.s2	Mon Feb 21 01:51:12 2011 +0000
+++ b/bin/upgrading/s2layers/core2.s2	Mon Feb 21 16:23:57 2011 +0800
@@ -4754,7 +4754,7 @@ function Entry::print_metatypes() {
 
 function Comment::print_metatypes() {
     if (defined $this.subject_icon) {
-        """<h3 class="comment-subjecticon">$this.subject_icon</h3>""";
+        """<div class="comment-subjecticon">$this.subject_icon</div>""";
     }
 }
 
diff -r c91c75c581b8 -r 29b9efda8308 bin/upgrading/s2layers/drifting/layout.s2
--- a/bin/upgrading/s2layers/drifting/layout.s2	Mon Feb 21 01:51:12 2011 +0000
+++ b/bin/upgrading/s2layers/drifting/layout.s2	Mon Feb 21 16:23:57 2011 +0800
@@ -756,7 +756,7 @@ function Page::print_default_stylesheet(
         text-decoration: none;
     }
 
-    h3.comment-subjecticon { margin: 0; }
+    .comment-subjecticon { margin: 0; }
 
     .comment-content {
         padding-left: 10px;
--------------------------------------------------------------------------------