fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-01-31 04:44 am

[dw-free] Digest authorization popup uses "lj" as the realm

[commit: http://hg.dwscoalition.org/dw-free/rev/062181b1afde]

http://bugs.dwscoalition.org/show_bug.cgi?id=3414

Oops, left in debug code.

Patch by [personal profile] fu.

Files modified:
  • bin/checkconfig.pl
  • cgi-bin/ljlib.pl
--------------------------------------------------------------------------------
diff -r f4cfb7827690 -r 062181b1afde bin/checkconfig.pl
--- a/bin/checkconfig.pl	Mon Jan 31 11:41:29 2011 +0800
+++ b/bin/checkconfig.pl	Mon Jan 31 12:43:56 2011 +0800
@@ -184,7 +184,16 @@ my %modules = (
                    'opt' => "Required for country lookup with IP address.",
                },
                "GTop" => {},
+               "Apache2::RequestRec"   => {
+                   'deb' => "libapache2-mod-perl2",
+                   'opt' => "Required for modperl2",
+               },
+               "Apache2::Request"      => {
+                   'deb' => "libapache2-request-perl",
+                   'opt' => "Required for Apache2",
+               },
                );
+
 
 sub check_modules {
     print "[Checking for Perl Modules....]\n"
diff -r f4cfb7827690 -r 062181b1afde cgi-bin/ljlib.pl
--- a/cgi-bin/ljlib.pl	Mon Jan 31 11:41:29 2011 +0800
+++ b/cgi-bin/ljlib.pl	Mon Jan 31 12:43:56 2011 +0800
@@ -916,7 +916,6 @@ sub auth_digest {
     # sanity checks
     unless ($authname eq 'Digest' && ( !defined $attrs{'qop'} || $attrs{'qop'} eq 'auth' ) &&
             $attrs{'realm'} eq $LJ::SITENAMESHORT && (!defined $attrs{'algorithm'} || $attrs{'algorithm'} eq 'MD5')) {
-warn "did not pass sanity checks";
         return $decline->(0);
     }
 
--------------------------------------------------------------------------------