fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-12-28 12:58 pm

[dw-free] directory search results: short/missing userpics misaligned

[commit: http://hg.dwscoalition.org/dw-free/rev/7474d8f1cc7e]

http://bugs.dwscoalition.org/show_bug.cgi?id=1109

Make the text-only results a list rather than a table. Makes more sense that
way (also tweaks styling slightly

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/LJ/Directory/Results.pm
--------------------------------------------------------------------------------
diff -r ac7055e44342 -r 7474d8f1cc7e cgi-bin/LJ/Directory/Results.pm
--- a/cgi-bin/LJ/Directory/Results.pm	Tue Dec 28 20:56:53 2010 +0800
+++ b/cgi-bin/LJ/Directory/Results.pm	Tue Dec 28 20:58:23 2010 +0800
@@ -91,15 +91,15 @@ sub render_simple {
 
     my $updated = LJ::get_timeupdate_multi($self->userids);
 
-    my $ret = "<table summary='' id='SearchResults' cellspacing='1'>";
+    my $ret = "<ul>";
     foreach my $u (@users) {
-        $ret .= "<tr><td class='SearchResult'>";
+        $ret .= "<li>";
         $ret .= $u->ljuser_display . " - " . $u->name_html;
         # FIXME: consider replacing this with $u->last_updated
         $ret .= " <small>(Last updated: ". LJ::diff_ago_text( $updated->{$u->id} ) . ")</small>";
-        $ret .= "</td></tr>";
+        $ret .= "</li>";
     }
-    $ret .= "</table>";
+    $ret .= "</ul>";
     return $ret;
 }
 
--------------------------------------------------------------------------------