fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-11-09 07:34 am

[dw-free] Breaking out of Quickreply breaks style arguments

[commit: http://hg.dwscoalition.org/dw-free/rev/c254ef705e15]

http://bugs.dwscoalition.org/show_bug.cgi?id=3214

Append a "&" in case we have other URL arguments (style=*)

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/weblib.pl
--------------------------------------------------------------------------------
diff -r efb303765aaa -r c254ef705e15 cgi-bin/weblib.pl
--- a/cgi-bin/weblib.pl	Mon Nov 08 21:31:44 2010 -0600
+++ b/cgi-bin/weblib.pl	Tue Nov 09 15:33:44 2010 +0800
@@ -656,7 +656,7 @@ sub create_qr_div {
     $qrhtml .= "<div id='qrformdiv'><form id='qrform' name='qrform' method='POST' action='$LJ::SITEROOT/talkpost_do'>";
     $qrhtml .= LJ::form_auth();
 
-    my $stylemineuri = %$style_opts ? LJ::viewing_style_args( %$style_opts ) : "";
+    my $stylemineuri = %$style_opts ? LJ::viewing_style_args( %$style_opts ) . "&" : "";
     my $basepath =  $u->journal_base . "/$ditemid.html?${stylemineuri}";
     my $usertype = ($remote->openid_identity && $remote->is_validated) ? 'openid_cookie' : 'cookieuser';
     $qrhtml .= LJ::html_hidden({'name' => 'replyto', 'id' => 'replyto', 'value' => ''},
--------------------------------------------------------------------------------