[dw-free] clean up log messages that appear when global warnings are on

[fu]

[commit: http://hg.dwscoalition.org/dw-free/rev/ab6ff73650ca]

http://bugs.dwscoalition.org/show_bug.cgi?id=3040

Also go into this path when we don't provide a specific filter get argument.

Patch by fu.

Files modified:

• cgi-bin/LJ/S2/FriendsPage.pm

--------------------------------------------------------------------------------
diff -r 638a8e216b6f -r ab6ff73650ca cgi-bin/LJ/S2/FriendsPage.pm
--- a/cgi-bin/LJ/S2/FriendsPage.pm	Sat Oct 23 10:12:01 2010 +0800
+++ b/cgi-bin/LJ/S2/FriendsPage.pm	Sat Oct 23 11:06:00 2010 +0800
@@ -132,7 +132,8 @@ sub FriendsPage
             $p->{filter_name} = $opts->{securityfilter};
     } else {
     # but we can't just use a filter, we have to make sure the person is allowed to
-        if ( $get->{filter} && $get->{filter} ne "0" && $cf && ( $u->equals( $remote ) || $cf->public ) ) {
+        if ( ( ! $get->{filter} || $get->{filter} && $get->{filter} ne "0" )
+            && $cf && ( $u->equals( $remote ) || $cf->public ) ) {
             $filter = $cf;
 
         # if we couldn't use the group, then we can throw an error, but ONLY IF they specified
--------------------------------------------------------------------------------

Comments

[kareila]

Hmm, but won't that always be true? Shouldn't it be ! defined $get->{filter} instead, if the only criteria we want to reject is when filter is zero?

[fu]

oh hmm, right. Truth values! Can you write up a patch and push it?