fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-10-11 11:25 am

[dw-free] Refried Tablet: footer modules display oddly when they have a background color

[commit: http://hg.dwscoalition.org/dw-free/rev/50676e2d7759]

http://bugs.dwscoalition.org/show_bug.cgi?id=3122

Apply module background color as a border in tertiary. Some refactoring.

Patch by [personal profile] ninetydegrees.

Files modified:
  • bin/upgrading/s2layers/refriedtablet/layout.s2
--------------------------------------------------------------------------------
diff -r b14e0868a33d -r 50676e2d7759 bin/upgrading/s2layers/refriedtablet/layout.s2
--- a/bin/upgrading/s2layers/refriedtablet/layout.s2	Mon Oct 11 19:21:28 2010 +0800
+++ b/bin/upgrading/s2layers/refriedtablet/layout.s2	Mon Oct 11 19:25:14 2010 +0800
@@ -114,6 +114,8 @@ function print_stylesheet () {
                 }
             """;
         }
+
+    var string tertiary_border = $*color_module_background ? "border-top: 2em solid $*color_module_background" : "";
 
 """
 /* Refried Tablet CSS */
@@ -471,22 +473,20 @@ div h2.module-header {
     margin-left: 0em;
 }
 
+.two-columns-left #tertiary, .two-columns-right #tertiary {
+    $tertiary_border
+    }
+
 /* don't make tertiary modules in two column into 15px boxes, the data doesn't fit!*/
-.two-columns-left #tertiary .module, .two-columns-right #tertiary .module {
-    clear: both;
-    width: auto;
-    margin: 0em auto;
-    padding: 0em;
-    border-width: 0px;
-
-}
-
-/* color match the tertiary modules in two column styles to the page, but give it a module-y top border */
-
+/* color match the tertiary modules in two column styles to the page */
 .two-columns-left #tertiary .module, .two-columns-right #tertiary .module {
     $page_background
     $page_colors
-    border-width: 0px;
+    border: none;
+    clear: both;
+    margin: 0 auto;
+    padding: 0;
+    width: auto;
 }
 
 .two-columns-left #tertiary .module a, .two-columns-right #tertiary .module a {
@@ -503,10 +503,6 @@ div h2.module-header {
 
 .two-columns-left #tertiary .module a:visited, .two-columns-right #tertiary .module a:visited {
     $page_link_visited_colors
-}
-
-.two-columns-left #tertiary, .two-columns-right #tertiary {
-    $module_background
 }
 
 /* add room to breathe on one-column implementations */
--------------------------------------------------------------------------------