fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-10-05 03:57 am

[dw-free] clean up error logs

[commit: http://hg.dwscoalition.org/dw-free/rev/4625af29e22c]

http://bugs.dwscoalition.org/show_bug.cgi?id=2812

Check whether these are equal first; if not, then try to unescape the
incoming URL and check again.

Patch by [personal profile] kareila.

Files modified:
  • htdocs/misc/hubbub.bml
--------------------------------------------------------------------------------
diff -r 188c1afc510d -r 4625af29e22c htdocs/misc/hubbub.bml
--- a/htdocs/misc/hubbub.bml	Tue Oct 05 11:51:43 2010 +0800
+++ b/htdocs/misc/hubbub.bml	Tue Oct 05 11:56:27 2010 +0800
@@ -85,7 +85,8 @@ _c?><?_code
     # if the topic url doesn't match, then that's a terrible thing and we're not sure
     # why, so log extra information
     return $err->( 'topic_url mismatch: db=' . $topicurldb . ', hub=' . $topicurl )
-        unless lc unescape( $topicurl ) eq lc $topicurldb;
+        unless lc $topicurl eq lc $topicurldb ||
+               lc unescape( $topicurl ) eq lc $topicurldb;
 
     # validate the user is still valid (didn't get suspended or anything)
     my $u = LJ::load_userid( $uid ) or return $fail->( 'failed to load user' );
--------------------------------------------------------------------------------