fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-10-01 03:31 pm

[bml] Modification of a read-only value when loading admin/healthy.bml

[commit: http://hg.dwscoalition.org/bml/rev/563a883a2830]

http://bugs.dwscoalition.org/show_bug.cgi?id=3090

Stop hiding unmodifiable errors (if they show up again, we can track them
down and fix)

Patch by [personal profile] fu.

Files modified:
  • lib/Apache/BML.pm
--------------------------------------------------------------------------------
diff -r 15b46611f71c -r 563a883a2830 lib/Apache/BML.pm
--- a/lib/Apache/BML.pm	Tue Sep 14 13:33:49 2010 +0800
+++ b/lib/Apache/BML.pm	Fri Oct 01 23:30:51 2010 +0800
@@ -640,10 +640,7 @@ sub deleteglob
     my $fileno;
     if ($key !~ /^_</ and defined $entry)
     {
-        eval { undef $entry };  # trap read-only value error
-        # FIXME: temporary; let's see if we can track down whether any particular
-        # read-only values are at fault
-        warn "$@: $file - $key " if $@;
+        undef $entry;
     }
     if ($key !~ /^_</ and defined @entry)
     {
--------------------------------------------------------------------------------