fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-07-12 09:50 am

[dw-nonfree] Investigate using cgi-bin/imageconf.pl instead of scattering image URLs all over the pl

[commit: http://hg.dwscoalition.org/dw-nonfree/rev/9ff94c4274b0]

http://bugs.dwscoalition.org/show_bug.cgi?id=1207

The nouserpic image on SSL and non-SSL pages in dw-nonfree site scheme.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/bml/scheme/tropo-purple.look
  • cgi-bin/bml/scheme/tropo-red.look
--------------------------------------------------------------------------------
diff -r f4867786bd43 -r 9ff94c4274b0 cgi-bin/bml/scheme/tropo-purple.look
--- a/cgi-bin/bml/scheme/tropo-purple.look	Mon Jul 12 16:30:00 2010 +0800
+++ b/cgi-bin/bml/scheme/tropo-purple.look	Mon Jul 12 17:56:14 2010 +0800
@@ -67,7 +67,6 @@ accountlinks<=
 accountlinks<=
 <?_code
 {
-    my $imgprefix = $LJ::IS_SSL ? $LJ::SSLIMGPREFIX : $LJ::IMGPREFIX;
     my $remote = LJ::get_remote();
     my $ret;
 
@@ -82,7 +81,7 @@ accountlinks<=
             my $wh = $userpic->img_fixedsize( width => 80, height => 80 );
             $ret .= "<img src='" . $userpic->url . "' $wh alt=\"$ML{'sitescheme.accountlinks.userpic.alt'}\" />";
         } else {
-            $ret .= "<img src='$imgprefix/nouserpic.png' width='80' height='80' alt=\"$ML{'sitescheme.accountlinks.userpic.alt'}\" />";
+            $ret .= LJ::img( "nouserpic_sitescheme", "", { ssl => 1 } );
         }
         $ret .= "</a></div>";
         $ret .= "<div id='account-links-text'>";
diff -r f4867786bd43 -r 9ff94c4274b0 cgi-bin/bml/scheme/tropo-red.look
--- a/cgi-bin/bml/scheme/tropo-red.look	Mon Jul 12 16:30:00 2010 +0800
+++ b/cgi-bin/bml/scheme/tropo-red.look	Mon Jul 12 17:56:14 2010 +0800
@@ -67,7 +67,6 @@ accountlinks<=
 accountlinks<=
 <?_code
 {
-    my $imgprefix = $LJ::IS_SSL ? $LJ::SSLIMGPREFIX : $LJ::IMGPREFIX;
     my $remote = LJ::get_remote();
     my $ret;
 
@@ -82,7 +81,7 @@ accountlinks<=
             my $wh = $userpic->img_fixedsize( width => 80, height => 80 );
             $ret .= "<img src='" . $userpic->url . "' $wh alt=\"$ML{'sitescheme.accountlinks.userpic.alt'}\" />";
         } else {
-            $ret .= "<img src='$imgprefix/nouserpic.png' width='80' height='80' alt=\"$ML{'sitescheme.accountlinks.userpic.alt'}\" />";
+            $ret .= LJ::img( "nouserpic_sitescheme", "", { ssl => 1 } );
         }
         $ret .= "</a></div>";
         $ret .= "<div id='account-links-text'>";
--------------------------------------------------------------------------------