fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-04-05 03:13 pm

[dw-free] Prohibit Conditional Declarations (backend cleanup)

[commit: http://hg.dwscoalition.org/dw-free/rev/4717d7c1494e]

http://bugs.dwscoalition.org/show_bug.cgi?id=2270

Cleanup/future-proofing.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/DW/Shop/Engine/GoogleCheckout.pm
--------------------------------------------------------------------------------
diff -r 697554d09cd1 -r 4717d7c1494e cgi-bin/DW/Shop/Engine/GoogleCheckout.pm
--- a/cgi-bin/DW/Shop/Engine/GoogleCheckout.pm	Mon Apr 05 07:45:39 2010 -0700
+++ b/cgi-bin/DW/Shop/Engine/GoogleCheckout.pm	Mon Apr 05 08:17:58 2010 -0700
@@ -213,7 +213,8 @@ sub process_notification {
 
     # now that it's logged, we can do some processing depending on what type it is
     if ( $form->{_type} eq 'new-order-notification' ) {
-        my $cart = DW::Shop::Cart->get_from_cartid( $1 )
+        my $cart;
+        $cart = DW::Shop::Cart->get_from_cartid( $1 )
             if $form->{'shopping-cart.merchant-private-data'} =~ m!note>(\d+)</merch!;
 
         # now ensure the cart is good ...
--------------------------------------------------------------------------------