mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2010-03-08 10:58 pm

[dw-nonfree] "Don't email comments" setting for suggestions

[commit: http://hg.dwscoalition.org/dw-nonfree/rev/56db56f04d9f]

http://bugs.dwscoalition.org/show_bug.cgi?id=2328

Allow suggestion contributors to opt out of getting emailed about comments.

Patch by [personal profile] yvi.

Files modified:
  • htdocs/site/suggest.bml
--------------------------------------------------------------------------------
diff -r d044e6fc7ba4 -r 56db56f04d9f htdocs/site/suggest.bml
--- a/htdocs/site/suggest.bml	Mon Mar 08 22:25:52 2010 +0000
+++ b/htdocs/site/suggest.bml	Mon Mar 08 22:58:54 2010 +0000
@@ -36,6 +36,7 @@ body<=
     return "<?needlogin?>" unless $remote;
 
     my ( $ret, $suggestion, $response, $response2 );
+    my $emailselected = 1;
 
     # the community to post to:
     my $destination = LJ::load_user( 'dw_suggestions' );
@@ -84,7 +85,7 @@ body<=
             'usejournal'      => $destination->user,
             'security'        => 'public',
             'usejournal_okay' => 1,
-            'props'           => { 'taglist' => 'untagged' },
+            'props'           => { 'taglist' => 'untagged' , 'opt_noemail' => !$POST{email} },
             'tz'              => 'guess',
             }, \$response, {
             'nopassword'      => 1,
@@ -183,6 +184,8 @@ body<=
             $ret .= $spellcheck_html . "<br />";
         }
 
+        $emailselected = $POST{email};
+
         $ret .= "<hr>";
     }
 
@@ -236,6 +239,17 @@ body<=
                                 value => $POST{description}
                               } );
 
+    # does the user want to be notified of comments?
+    $ret .= "<p><label for='email' class='left options'>" . "Notify me of comments" . "</label>";
+    $ret .= LJ::html_check( {
+                        type     => 'checkbox',
+                        name     => "email",
+                        id       => 'email',
+                        class    => 'check',
+                        value    => 1,
+                        selected => $emailselected
+                            } );
+
     # and, the submit button:
     $ret .= "<p>" . LJ::html_submit( 'post', "Post Suggestion" );
 
--------------------------------------------------------------------------------