afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2010-01-30 10:15 am

[dw-free] completely redo OpenID grant identity validation page

[commit: http://hg.dwscoalition.org/dw-free/rev/91742a7ca440]

http://bugs.dwscoalition.org/show_bug.cgi?id=2285

Clarify what happens when you use your Dreamwidth openid login on other
sites.

Patch by [staff profile] denise.

Files modified:
  • htdocs/openid/approve.bml
  • htdocs/openid/approve.bml.text
--------------------------------------------------------------------------------
diff -r 4d557293d4db -r 91742a7ca440 htdocs/openid/approve.bml
--- a/htdocs/openid/approve.bml	Sat Jan 30 10:02:36 2010 +0000
+++ b/htdocs/openid/approve.bml	Sat Jan 30 10:14:49 2010 +0000
@@ -64,13 +64,14 @@
         return $err->($ML{'.error.failed_sign_url'});
     }
 
-    $title = $ML{'.form.title'};
-    $body = "<?p " . BML::ml( ".form.request", { sitename => $LJ::SITENAMESHORT } ) . " p?>";
+    $title = $ML{'.form.title2'};
+    my $dis_site = LJ::ehtml($site);
+    $dis_site =~ s!\*\.!<span style='color: red'><i>&lt;anything&gt;</i></span>.!;
+
+    $body = "<?p " . BML::ml( ".form.request2", { sitename => $LJ::SITENAMESHORT, refurl => $dis_site, url => LJ::ehtml( $GET{'identity'} ) } ) . " p?>";
     $body .= "<?p " . $ML{'.form.address'} . " p?>";
     $body .= "<form method='post'>";
     $body .= LJ::form_auth();
-    my $dis_site = LJ::ehtml($site);
-    $dis_site =~ s!\*\.!<span style='color: red'><i>&lt;anything&gt;</i></span>.!;
 
     $body .= "<div style='overflow: auto; background: #DDD; word-wrap: break-word; color: black; border: 2px solid black; padding: 0.5em; font-size: 13pt'><tt>$dis_site</tt></div>";
     $body .= "<?p " . $ML{'.form.passid'} . " p?>";
diff -r 4d557293d4db -r 91742a7ca440 htdocs/openid/approve.bml.text
--- a/htdocs/openid/approve.bml.text	Sat Jan 30 10:02:36 2010 +0000
+++ b/htdocs/openid/approve.bml.text	Sat Jan 30 10:14:49 2010 +0000
@@ -26,6 +26,6 @@
 
 .form.passid=Do you want to pass your identity to them?
 
-.form.request=Another site on the web wants to validate your [[sitename]] identity.  No information will be shared with them that isn't already public in your profile, only that you're who you've already told them you are (if you told them).
+.form.request2=The site you just came from has asked [[sitename]] to prove that you own this [[sitename]] account. If you allow this, we will <b>not</b> give them access to your [[sitename]] account or password, or any information that isn't already public in your account. All we'll do is tell [[refurl]] that you control the account [[url]].
 
-.form.title=Grant identity validation?
\ No newline at end of file
+.form.title2=Pass identity along?
\ No newline at end of file
--------------------------------------------------------------------------------