mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2010-01-07 10:10 am

[dw-free] Read page skiplinks not behaving correctly

[commit: http://hg.dwscoalition.org/dw-free/rev/a175f22fc3b4]

http://bugs.dwscoalition.org/show_bug.cgi?id=2245

Fix forward skip links. This was a bug I introduced in yvi's patch when I
committed it the first time around, then she had to fix it. Sorry about
that\!

Patch by [personal profile] yvi.

Files modified:
  • cgi-bin/LJ/S2/FriendsPage.pm
--------------------------------------------------------------------------------
diff -r c9f2e6d93ab8 -r a175f22fc3b4 cgi-bin/LJ/S2/FriendsPage.pm
--- a/cgi-bin/LJ/S2/FriendsPage.pm	Thu Jan 07 10:08:51 2010 +0000
+++ b/cgi-bin/LJ/S2/FriendsPage.pm	Thu Jan 07 10:10:39 2010 +0000
@@ -243,10 +243,10 @@ sub FriendsPage
         $linkvars{'show'} = $get->{'show'} if $get->{'show'} =~ /^\w+$/;
         $linkvars{'date'} = $get->{date} if $get->{date};
         $linkvars{filter} = $get->{filter}+0 if defined $get->{filter};
-        $nav->{'forward_url'} = LJ::make_link($base, \%linkvars);
         my $newskip = $skip - $itemshow;
         if ($newskip > 0) { $linkvars{'skip'} = $newskip; }
         else { $newskip = 0; }
+        $nav->{'forward_url'} = LJ::make_link($base, \%linkvars);
         $nav->{'forward_skip'} = $newskip;
         $nav->{'forward_count'} = $itemshow;
         $p->{head_content} .= qq#<link rel="next" href="$nav->{forward_url}" />\n#;
--------------------------------------------------------------------------------