mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2010-01-07 05:46 am

[dw-free] Preview of embedded content in entry does not detect width and height

[commit: http://hg.dwscoalition.org/dw-free/rev/db6144ecb314]

http://bugs.dwscoalition.org/show_bug.cgi?id=2259

Fix width/height issue with previewing entries with embedded content.

Patch by [personal profile] afuna.

Files modified:
  • cgi-bin/LJ/EmbedModule.pm
--------------------------------------------------------------------------------
diff -r 3e9319ca0b5b -r db6144ecb314 cgi-bin/LJ/EmbedModule.pm
--- a/cgi-bin/LJ/EmbedModule.pm	Thu Jan 07 05:36:58 2010 +0000
+++ b/cgi-bin/LJ/EmbedModule.pm	Thu Jan 07 05:46:47 2010 +0000
@@ -235,10 +235,10 @@ sub module_iframe_tag {
 
     my $journalid = $u->userid;
     $moduleid += 0;
+    my $preview = $opts{preview};
 
     # parse the contents of the module and try to come up with a guess at the width and height of the content
-    my $content = $class->module_content(moduleid => $moduleid, journalid => $journalid);
-    my $preview = $opts{preview};
+    my $content = $class->module_content( moduleid => $moduleid, journalid => $journalid, preview => $preview );
     my $width = 0;
     my $height = 0;
     my $p = HTML::TokeParser->new(\$content);
--------------------------------------------------------------------------------