afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-08-22 06:20 pm

[dw-free] /manage/tags doesn't respect sort order of security groups

[commit: http://hg.dwscoalition.org/dw-free/rev/0c18f326ab15]

http://bugs.dwscoalition.org/show_bug.cgi?id=1615

Use sortorder, not alphabetical order.

Patch by [personal profile] kareila.

Files modified:
  • htdocs/manage/tags.bml
--------------------------------------------------------------------------------
diff -r df63728737a5 -r 0c18f326ab15 htdocs/manage/tags.bml
--- a/htdocs/manage/tags.bml	Sat Aug 22 18:15:12 2009 +0000
+++ b/htdocs/manage/tags.bml	Sat Aug 22 18:20:19 2009 +0000
@@ -303,7 +303,7 @@ HEAD
 
     my $grouplist = $u->trust_groups;
     push @groups,  map  { "group:" . $_, $grouplist->{$_}->{groupname} }
-    sort { $grouplist->{$a}->{groupname} cmp $grouplist->{$b}->{groupname} }
+    sort { $grouplist->{$a}->{sortorder} <=> $grouplist->{$b}->{sortorder} }
     keys %$grouplist;
 
     my $security = LJ::Tags::get_permission_levels($u);
--------------------------------------------------------------------------------