[dw-free] Fix annoying error in logs:

[mark]

[commit: http://hg.dwscoalition.org/dw-free/rev/3d6682ab6adc]

Fix annoying error in logs:

Use of uninitialized value in int at /home/dw/current/cgi-
bin/Cache/Memcached.pm line 577.

This was caused by the get_timeupdate_multi function having bad support for
the case where it is called with no arguments. Now, if you pass nothing,
you get nothing. (Instead of hitting up Memcache and warning.)

Patch by mark.

Files modified:

• cgi-bin/ljlib.pl

--------------------------------------------------------------------------------
diff -r 658c278b78f5 -r 3d6682ab6adc cgi-bin/ljlib.pl
--- a/cgi-bin/ljlib.pl	Fri Aug 07 01:53:44 2009 -0500
+++ b/cgi-bin/ljlib.pl	Fri Aug 07 06:59:04 2009 +0000
@@ -370,7 +370,7 @@ sub get_timeupdate_multi {
     my ($opt, @uids) = @_;
 
     # allow optional opt hashref as first argument
-    unless (ref $opt eq 'HASH') {
+    if ( $opt && ref $opt ne 'HASH' ) {
         push @uids, $opt;
         $opt = {};
     }
--------------------------------------------------------------------------------

Comments

[kareila]

I think this fix closes http://bugs.dwscoalition.org/show_bug.cgi?id=548. :)

[mark]

I never know whether to just keep using a bug or open new bugs or what.

But there are more errors that have shown up over time. And some of them are frequent offenders. (But they come in bursts, which makes me think they're tired to key expiry times...)