afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-06-11 02:16 pm

[dw-free] email field name in "Invite a friend" page interferes with form autocompletion.

[commit: http://hg.dwscoalition.org/dw-free/rev/7e8014745b7d]

http://bugs.dwscoalition.org/show_bug.cgi?id=1191

Rename the form field, reenable autocomplete.

Patch by [personal profile] kareila.

Files modified:
  • htdocs/manage/circle/invite.bml
--------------------------------------------------------------------------------
diff -r 6607f002c944 -r 7e8014745b7d htdocs/manage/circle/invite.bml
--- a/htdocs/manage/circle/invite.bml	Thu Jun 11 00:04:06 2009 +0000
+++ b/htdocs/manage/circle/invite.bml	Thu Jun 11 14:15:26 2009 +0000
@@ -21,7 +21,7 @@
     }
 
     my %ierr;
-    my $email = $POST{email} || '';
+    my $email = $POST{invite_email} || '';
     my $create_link = ($LJ::USE_SSL ? $LJ::SSLROOT : $LJ::SITEROOT) . "/create.bml?from=$u->{user}";
 
     
@@ -159,22 +159,22 @@
                 extra => $email,
             });
 
-            # Blank email so the form is redisplayed for a new
-            # recipient, but with the same message
-            $email = '';
-
             if ( $LJ::USE_ACCT_CODES ) {
                 # mark an invite code as sent
                 my $invite_obj = DW::InviteCodes->new( code => $code );
                 $invite_obj->send_code;
 
-                $body .= "<?standout " . BML::ml('.success.code', { email  => $POST{email}, invitecode => $code }) . " standout?>";
+                $body .= "<?standout " . BML::ml('.success.code', { email  => $email, invitecode => $code }) . " standout?>";
 
                 $code_sent = 1;
 
             } else {
-                $body .= "<?standout " . BML::ml('.success', { email => $POST{email}}) . " standout?>";
+                $body .= "<?standout " . BML::ml('.success', { email => $email }) . " standout?>";
             }
+
+            # Blank email so the form is redisplayed for a new
+            # recipient, but with the same message
+            $email = '';
 
        # Over rate limit
        } else {
@@ -197,7 +197,7 @@
 
     $body .= "<div style='margin: 20px 0 20px 20px;'>";
     $body .= "<label for='email'>$ML{'.form.input.email'}</label> ";
-    $body .= LJ::html_text({ name => "email", id => "email", class => 'text', autocomplete => 'off', value => $email }) . " ";
+    $body .= LJ::html_text({ name => "invite_email", id => "email", class => 'text', value => $email }) . " ";
     $body .= LJ::html_submit($ML{'.btn.invite2'});
     if ($inerr->("email")) {
         $body .= "<br />" . $inerr->("email");
--------------------------------------------------------------------------------