Mar. 6th, 2023

github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github

Branch: refs/heads/code-tour Home: https://github.com/dreamwidth/dreamwidth Commit: 8d76dd83a3527bd875552e8f66a6c7981f459b9d https://github.com/dreamwidth/dreamwidth/commit/8d76dd83a3527bd875552e8f66a6c7981f459b9d Author: chebegeek 95310836+chebegeek@users.noreply.github.com Date: 2022-10-25 (Tue, 25 Oct 2022)

Changed paths: M cgi-bin/LJ/EmbedModule.pm M t/cleaner-embed.t

Log Message:


Enable full screen video in embeds (#2998)

  • Enable full screen video in embeds

  • Undo whitespace changes

    Commit: 32cab3d6ab5d0429f8d68fae67bd5724b708f31c https://github.com/dreamwidth/dreamwidth/commit/32cab3d6ab5d0429f8d68fae67bd5724b708f31c Author: Robby Griffin alierak@gmail.com Date: 2022-11-04 (Fri, 04 Nov 2022)

    Changed paths: M doc/dependencies-system

    Log Message:


Need libgd-text-perl for text in stats bar graphs

Commit: 0b27704cc9a6514fd2684a8eb4b7002fc8c16a43 https://github.com/dreamwidth/dreamwidth/commit/0b27704cc9a6514fd2684a8eb4b7002fc8c16a43 Author: Robby Griffin alierak@gmail.com Date: 2022-11-04 (Fri, 04 Nov 2022)

Changed paths: M cgi-bin/DW/Controller/Stats.pm

Log Message:


Don't check whether stats graphs exist on this particular webserver

Commit: 8f160e3657d66aaa318da2189198c9ce7dde807b https://github.com/dreamwidth/dreamwidth/commit/8f160e3657d66aaa318da2189198c9ce7dde807b Author: Kareila kareila@dreamwidth.org Date: 2022-11-05 (Sat, 05 Nov 2022)

Changed paths: M etc/config.pl.example

Log Message:


[#2897] update boilerplate text for config.pl.example

Commit: 9099c0ac8ba8ea7e125bab27d45fd4c28a3774dc https://github.com/dreamwidth/dreamwidth/commit/9099c0ac8ba8ea7e125bab27d45fd4c28a3774dc Author: Kareila kareila@dreamwidth.org Date: 2022-11-05 (Sat, 05 Nov 2022)

Changed paths: M cgi-bin/DW/Controller/Support/Faq.pm

Log Message:


[#2925] display edit link when viewer has faqedit priv

Another minor bit of admin functionality that went walkabout when the page was converted away from BML.

Fixes #2925.

Commit: d6c4c1c9cf795d23661e99c3a35e638cc01978d2 https://github.com/dreamwidth/dreamwidth/commit/d6c4c1c9cf795d23661e99c3a35e638cc01978d2 Author: Mark Smith mark@qq.is Date: 2022-11-08 (Tue, 08 Nov 2022)

Changed paths: M cgi-bin/DW/Task/ESN/FilterSubs.pm M cgi-bin/DW/Task/ESN/ProcessSub.pm

Log Message:


Make error messages actually print

Commit: 1df2e7cd2fdae4493d15281ce5942f280a1cee70 https://github.com/dreamwidth/dreamwidth/commit/1df2e7cd2fdae4493d15281ce5942f280a1cee70 Author: Mark Smith mark@qq.is Date: 2022-11-08 (Tue, 08 Nov 2022)

Changed paths: M cgi-bin/DW/Task/ESN/FilterSubs.pm M cgi-bin/DW/Task/ESN/ProcessSub.pm

Log Message:


Tidy + add more debugging

Commit: c7a0b846f53de2fa4ff4858da569763a798f48f7 https://github.com/dreamwidth/dreamwidth/commit/c7a0b846f53de2fa4ff4858da569763a798f48f7 Author: Cocoa momijizukamori@gmail.com Date: 2022-11-08 (Tue, 08 Nov 2022)

Changed paths: M htdocs/js/jquery.inbox.js M htdocs/scss/components/foundation-custom/_pagination.scss M htdocs/scss/pages/inbox.scss

Log Message:


Fourth round of inbox tweaks!

  • Restores a confirmation check in JS for 'delete all'
  • Adds some spacing above the Compose button
  • Fixes current page link color in pagination

    Commit: 88648423dae66f0b2942dc423d9956ea7ace3f7b https://github.com/dreamwidth/dreamwidth/commit/88648423dae66f0b2942dc423d9956ea7ace3f7b Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2022-11-08 (Tue, 08 Nov 2022)

    Changed paths: M htdocs/js/jquery.inbox.js M htdocs/scss/components/foundation-custom/_pagination.scss M htdocs/scss/pages/inbox.scss

    Log Message:


Merge pull request #3006 from momijizukamori/inbox-tweaks-11-6

Fourth round of inbox tweaks!

Commit: b305905dfcfdf3740931ece628612062b5076d29 https://github.com/dreamwidth/dreamwidth/commit/b305905dfcfdf3740931ece628612062b5076d29 Author: Mark Smith mark@qq.is Date: 2022-11-08 (Tue, 08 Nov 2022)

Changed paths: M .github/workflows/tasks/worker-birthday-notify-service.json M .github/workflows/tasks/worker-change-poster-id-service.json M .github/workflows/tasks/worker-codebuild-notifier-service.json M .github/workflows/tasks/worker-content-importer-lite-service.json M .github/workflows/tasks/worker-content-importer-service.json M .github/workflows/tasks/worker-content-importer-verify-service.json M .github/workflows/tasks/worker-directory-meta-service.json M .github/workflows/tasks/worker-distribute-invites-service.json M .github/workflows/tasks/worker-dw-esn-cluster-subs-service.json M .github/workflows/tasks/worker-dw-esn-filter-subs-service.json M .github/workflows/tasks/worker-dw-esn-fired-event-service.json M .github/workflows/tasks/worker-dw-esn-process-sub-service.json M .github/workflows/tasks/worker-dw-send-email-service.json M .github/workflows/tasks/worker-dw-sphinx-copier-service.json M .github/workflows/tasks/worker-embeds-service.json M .github/workflows/tasks/worker-esn-cluster-subs-service.json M .github/workflows/tasks/worker-esn-filter-subs-service.json M .github/workflows/tasks/worker-esn-fired-event-service.json M .github/workflows/tasks/worker-esn-process-sub-service.json M .github/workflows/tasks/worker-resolve-extacct-service.json M .github/workflows/tasks/worker-send-email-ses-service.json M .github/workflows/tasks/worker-service.tt M .github/workflows/tasks/worker-spellcheck-gm-service.json M .github/workflows/tasks/worker-sphinx-copier-service.json M .github/workflows/tasks/worker-sphinx-search-gm-service.json M .github/workflows/tasks/worker-synsuck-service.json

Log Message:


Workers should use etc-stable directory

Commit: b4f9730cd15a44d7b029a0ba6b97358a98d81160 https://github.com/dreamwidth/dreamwidth/commit/b4f9730cd15a44d7b029a0ba6b97358a98d81160 Author: Mark Smith mark@qq.is Date: 2022-11-08 (Tue, 08 Nov 2022)

Changed paths: M .github/workflows/tasks/worker-birthday-notify-service.json M .github/workflows/tasks/worker-change-poster-id-service.json M .github/workflows/tasks/worker-codebuild-notifier-service.json M .github/workflows/tasks/worker-content-importer-lite-service.json M .github/workflows/tasks/worker-content-importer-service.json M .github/workflows/tasks/worker-content-importer-verify-service.json M .github/workflows/tasks/worker-directory-meta-service.json M .github/workflows/tasks/worker-distribute-invites-service.json M .github/workflows/tasks/worker-dw-esn-cluster-subs-service.json M .github/workflows/tasks/worker-dw-esn-filter-subs-service.json M .github/workflows/tasks/worker-dw-esn-fired-event-service.json M .github/workflows/tasks/worker-dw-esn-process-sub-service.json M .github/workflows/tasks/worker-dw-send-email-service.json M .github/workflows/tasks/worker-dw-sphinx-copier-service.json M .github/workflows/tasks/worker-embeds-service.json M .github/workflows/tasks/worker-esn-cluster-subs-service.json M .github/workflows/tasks/worker-esn-filter-subs-service.json M .github/workflows/tasks/worker-esn-fired-event-service.json M .github/workflows/tasks/worker-esn-process-sub-service.json M .github/workflows/tasks/worker-resolve-extacct-service.json M .github/workflows/tasks/worker-send-email-ses-service.json M .github/workflows/tasks/worker-service.tt M .github/workflows/tasks/worker-spellcheck-gm-service.json M .github/workflows/tasks/worker-sphinx-copier-service.json M .github/workflows/tasks/worker-sphinx-search-gm-service.json M .github/workflows/tasks/worker-synsuck-service.json

Log Message:


Use workers etc dir, so our configs match our unit of deployments

Commit: 029cd6de1934c3b9d1701c2caafb82d185fecd98 https://github.com/dreamwidth/dreamwidth/commit/029cd6de1934c3b9d1701c2caafb82d185fecd98 Author: Mark Smith mark@qq.is Date: 2022-11-08 (Tue, 08 Nov 2022)

Changed paths: M cgi-bin/DW/Task/ESN/FilterSubs.pm

Log Message:


Fix filtering subs from old clusters

Commit: bfe9820342c34fbda5658d20ae0f22bb4c631e8f https://github.com/dreamwidth/dreamwidth/commit/bfe9820342c34fbda5658d20ae0f22bb4c631e8f Author: Jen kareila@dreamwidth.org Date: 2022-11-09 (Wed, 09 Nov 2022)

Changed paths: M bin/upgrading/en.dat M cgi-bin/DW/Controller.pm M cgi-bin/DW/Controller/Shop.pm M cgi-bin/DW/Shop/Engine/CheckMoneyOrder.pm M cgi-bin/LJ/Widget/ShopCart.pm M etc/config-local.pl.example M etc/config.pl.example M htdocs/shop/renames.bml M views/shop/index.tt M views/shop/index.tt.text

Log Message:


shop til you drop (#3007)

  • site configuration misbehavior: turning off shop components

It is easily possible to disable the individual sections of the shop that sell icons, points, and rename tokens, but the storefront was not designed to gracefully handle that configuration.

In the case of points or icons, the cart would throw a generic error when submitting the form. In the case of rename tokens, the "Add To Order" button would just silently fail.

Although it is unlikely DW will ever disable these shop items, let's update the code to be better behaved on general principle.

(Unavailable account levels are already handled in a reasonable manner.)

This also adds the missing 'icons' key to the example %LJ::SHOP hash.

  • site configuration misbehavior: turning off the shop entirely

Visiting any shop page with the 'payments' config option turned off results in a completely blank page and an error in the logs that says: Argument "The shop is currently disabled." isn't numeric.

Looks like this happened because of a misunderstanding about the intended return value of DW::Controller::controller. The relevant code comment says to return "error text" if there was an error, but the error message can't be just a string, it has to be a server response. Perhaps the behavior was later updated in order to allow other possible responses such as redirects.

At any rate, the fix is to use error_ml here. The subsequent sysban check obviously has the same problem, so this fixes that as well.

  • [#2974] enforce minimum amount for check/money order payments

Defines a new config parameter $LJ::SHOP_CMO_MINIMUM. If set to a value greater than zero, that value will be the minimum "cash" value required to accept check/money order payments.

Fixes #2974.

  • [#2328] print the currency to 2 decimal places in receipt email

As reported some time ago, the "Amount Due" was being shown as e.g. $20.2 instead of $20.20. Future emails will print the amount with the standard number of decimal places.

Fixes #2328.

  • new 'payments_cmo' option for LJ::is_enabled

As mentioned in #2974, it's possible that we may need to entirely disable paying by check or money order in the future due to increasing costs. This adds a 'payments_cmo' test to LJ::is_enabled that will make the switch easy to flip if that day comes.

Commit: afa02c2b13dd3a5bb7205d4c985f9b159b6845cd https://github.com/dreamwidth/dreamwidth/commit/afa02c2b13dd3a5bb7205d4c985f9b159b6845cd Author: Jen kareila@dreamwidth.org Date: 2022-11-09 (Wed, 09 Nov 2022)

Changed paths: M cgi-bin/DW/Controller/Tools.pm M views/tools/tellafriend.tt M views/tools/tellafriend.tt.text

Log Message:


final (for now) round of tellafriend fixes (#3005)

  • hush uninitialized value warnings related to empty message body

  • send from dw_null, reply-to user's own email

Currently, the header of the generated email looks like:

From: "[[username]] via [[sitename]]" <[[user's email]]>

This updates it to come from $LJ::BOGUS_EMAIL, with the user's email as a reply-to:

From: "[[username]] via [[sitename]]" <[[dw_null@site]]> Reply-To: "[[username]]" <[[user's email]]>

This change also makes it more likely that the message will actually be delivered by SES.

Fixes #1866.

  • fix problem with $default_formdata being ignored

Since $r->post_args is never empty (it's a Hash::MultiValue object), let's use the value of $r->did_post instead.

  • update the form display to better reflect the actual email header

also displays the message subject, which was hidden before

Commit: c6c12929c7f7cf2b3504a838b0658b3880bb7e21 https://github.com/dreamwidth/dreamwidth/commit/c6c12929c7f7cf2b3504a838b0658b3880bb7e21 Author: Mark Smith mark@qq.is Date: 2022-11-10 (Thu, 10 Nov 2022)

Changed paths: M .tidyallrc M bin/worker/paidstatus

Log Message:


Delete carts open/closed for >30 days

These carts have been abandoned for one reason or another, so let's remove them from the database -- they can't be used.

Commit: dcb2154aff7b457a92a14adab6a6ffb81a2944da https://github.com/dreamwidth/dreamwidth/commit/dcb2154aff7b457a92a14adab6a6ffb81a2944da Author: Jen kareila@dreamwidth.org Date: 2022-11-10 (Thu, 10 Nov 2022)

Changed paths: M bin/upgrading/en.dat M cgi-bin/DW/Shop/Item/Account.pm M cgi-bin/LJ/Widget/ShopItemOptions.pm M htdocs/shop/account.bml M htdocs/shop/account.bml.text M htdocs/shop/gifts.bml M views/shop/icons.tt M views/shop/icons.tt.text M views/shop/points.tt M views/shop/points.tt.text

Log Message:


shop til you drop part 2 (#3008)

  • not all CAP entries are created equal

This was generating "Use of uninitialized value in string eq at cgi-bin/DW/Shop/Item/Account.pm line 480."

  • don't include staff accounts in "gift paid time" suggestion list

It just looks wrong, especially if you follow a LOT of official comms.

  • add backlinks to shop pages for icons and points

The pages for accounts and rename tokens had these, but the others did not.

  • allow for=self paid time buyers to future date purchases

We were hiding all of the "gift" options on this version of the form, but there are legit reasons for someone to want to future-date a purchase for themselves. You could work around it by visiting the for=gift version of the page and entering your own username, but that's pointlessly annoying.

  • [#1339] warn when purchasing regular paid time for premium account

You can override the warning by resubmitting the form with the new checkbox checked, if you don't want to adjust the delivery date or the type of account time.

Fixes #1339.

  • warning should only include date if the logged-in user owns the account

  • [#2917] include expiration date in paid time notification email

    Commit: 5fb77ecf6d796ee03fa3f9a45122d77bf9564fe1 https://github.com/dreamwidth/dreamwidth/commit/5fb77ecf6d796ee03fa3f9a45122d77bf9564fe1 Author: Mark Smith mark@qq.is Date: 2022-11-10 (Thu, 10 Nov 2022)

    Changed paths: M etc/docker/base/Dockerfile

    Log Message:


Build static in base

This will make web builds faster, at the cost of including static content in the workers. (Oh well.)

Commit: b81325aefd6d4a033add1205e16bd34c0d080dfa https://github.com/dreamwidth/dreamwidth/commit/b81325aefd6d4a033add1205e16bd34c0d080dfa Author: Jen kareila@dreamwidth.org Date: 2022-11-10 (Thu, 10 Nov 2022)

Changed paths: M cgi-bin/DW/Hooks/Display.pm M cgi-bin/LJ/Console/Command/Finduser.pm M cgi-bin/LJ/Console/Response.pm M htdocs/scss/pages/admin/console.scss

Log Message:


new "finduser delve" console command (#3010)

  • [#1184] don't enforce black text for console output

This changes the color value to "inherit" which should use whatever the CSS has specified for body text.

  • [#2921] tweaks to console command table styling

  • [#2945] new 'finduser delve' command per request

Uses the finduser:infohistory priv, since it includes data from the infohistory table.

Fixes #2945.

Commit: 4f9b969f14848c5d741fd982aaebd67a5f153e71 https://github.com/dreamwidth/dreamwidth/commit/4f9b969f14848c5d741fd982aaebd67a5f153e71 Author: Mark Smith mark@qq.is Date: 2022-11-10 (Thu, 10 Nov 2022)

Changed paths: M cgi-bin/Apache/LiveJournal.pm

Log Message:


Serve from minified or max dir

Static content sometimes fails to compile, such as fckeditor, so this allows us to fall back to the max/ directory (which contains the source files) if we can't find the minified version.

Commit: 8b066009e3927b1c878a92e5f55a047354168247 https://github.com/dreamwidth/dreamwidth/commit/8b066009e3927b1c878a92e5f55a047354168247 Author: Mark Smith mark@qq.is Date: 2022-11-10 (Thu, 10 Nov 2022)

Changed paths: M cgi-bin/Apache/LiveJournal.pm

Log Message:


Sigh, what I get for not testing

Commit: f3229ec660f63f0704ff8a98964bf79afa1dbb2e https://github.com/dreamwidth/dreamwidth/commit/f3229ec660f63f0704ff8a98964bf79afa1dbb2e Author: Mark Smith mark@qq.is Date: 2022-11-10 (Thu, 10 Nov 2022)

Changed paths: M cgi-bin/Apache/LiveJournal.pm

Log Message:


Sigh, what I get for not testing x2

Commit: 4e286435cd8bc30b305f55ccff02b91ad835cf88 https://github.com/dreamwidth/dreamwidth/commit/4e286435cd8bc30b305f55ccff02b91ad835cf88 Author: Mark Smith mark@dreamwidth.org Date: 2022-11-11 (Fri, 11 Nov 2022)

Changed paths: M cgi-bin/Apache/LiveJournal.pm

Log Message:


Fixed, and tested

Commit: 7067577abb44fff9c279463d019eff6aa3011355 https://github.com/dreamwidth/dreamwidth/commit/7067577abb44fff9c279463d019eff6aa3011355 Author: Kareila kareila@dreamwidth.org Date: 2022-11-11 (Fri, 11 Nov 2022)

Changed paths: M cgi-bin/LJ/Widget/ShopItemOptions.pm M htdocs/shop/account.bml M htdocs/shop/account.bml.text

Log Message:


temporarily revert fix for #1339

Reports that this is interfering with the ability to purchase paid time. Needs further investigation.

Commit: 0c61e229b49aa14e7091186f789ed6ceeb8e9c03 https://github.com/dreamwidth/dreamwidth/commit/0c61e229b49aa14e7091186f789ed6ceeb8e9c03 Author: Mark Smith mark@qq.is Date: 2022-11-11 (Fri, 11 Nov 2022)

Changed paths: M bin/upgrading/proplists.dat M htdocs/manage/profile/index.bml.text M views/profile/main.tt.text

Log Message:


Rename hangouts to chat

Googly things. This probably works.

Commit: 264b1a602ce58a36a0dda81a7a1859d61ba2a491 https://github.com/dreamwidth/dreamwidth/commit/264b1a602ce58a36a0dda81a7a1859d61ba2a491 Author: Mark Smith mark@dreamwidth.org Date: 2022-11-11 (Fri, 11 Nov 2022)

Changed paths: M cgi-bin/DW/LatestFeed.pm

Log Message:


Don't show adult journals/entries in Latest Things

As it says on the tin.

Commit: d86d239482c9f579bdb6741f3a48de0524eeb024 https://github.com/dreamwidth/dreamwidth/commit/d86d239482c9f579bdb6741f3a48de0524eeb024 Author: Mark Smith mark@qq.is Date: 2022-11-11 (Fri, 11 Nov 2022)

Changed paths: M .github/workflows/web-build.yml M .github/workflows/worker-build.yml

Log Message:


Only run workflows on main

Commit: dc370990f6a1f335cd0e093da92f73afa7ed8c42 https://github.com/dreamwidth/dreamwidth/commit/dc370990f6a1f335cd0e093da92f73afa7ed8c42 Author: Robby Griffin alierak@gmail.com Date: 2022-11-11 (Fri, 11 Nov 2022)

Changed paths: M src/jbackup/jbackup.pl

Log Message:


support https, note password must be an API key

Commit: 72326a5b4e8ccaddcb8732eaf28c02fa57b0a43e https://github.com/dreamwidth/dreamwidth/commit/72326a5b4e8ccaddcb8732eaf28c02fa57b0a43e Author: Kareila kareila@dreamwidth.org Date: 2022-11-15 (Tue, 15 Nov 2022)

Changed paths: M cgi-bin/LJ/Directory/Constraint/Location.pm

Log Message:


limit directory search by location results to visible users

I took my cue from ContactInfo.pm, which mentions a desire to avoid using load_userids on a large data set for filtering purposes. Instead this expresses the visibility requirement as an additional WHERE clause in the SELECT statement, acting only on users that have rows in both the user and userprop tables.

Obviously my ability to test this locally is extremely limited, but this should fix the problem with location results being sparsely populated due to a large number of suspended SEO accounts.

Commit: cdfdaec518b92817b8c0442c7f92c903d3a48782 https://github.com/dreamwidth/dreamwidth/commit/cdfdaec518b92817b8c0442c7f92c903d3a48782 Author: Cocoa momijizukamori@gmail.com Date: 2022-11-18 (Fri, 18 Nov 2022)

Changed paths: M cgi-bin/CSS/Cleaner.pm

Log Message:


Remove high-byte check from CSS cleaner (it messes with utf8)

Commit: 81fb6c4da98616aa66f8694d9025c2bb9393c55e https://github.com/dreamwidth/dreamwidth/commit/81fb6c4da98616aa66f8694d9025c2bb9393c55e Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2022-11-18 (Fri, 18 Nov 2022)

Changed paths: M cgi-bin/CSS/Cleaner.pm

Log Message:


Merge pull request #3028 from momijizukamori/utf8css

Remove high-byte check from CSS cleaner (it messes with utf8)

Commit: 206fa43c9c462442adb67c5c1abdc26b7af048da https://github.com/dreamwidth/dreamwidth/commit/206fa43c9c462442adb67c5c1abdc26b7af048da Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2022-11-18 (Fri, 18 Nov 2022)

Changed paths: M src/jbackup/jbackup.pl

Log Message:


Merge pull request #3020 from alierak/jbackup-https

support https, note password must be an API key

Commit: 37986a727b09b6e12c0a08285eea937c90726b2c https://github.com/dreamwidth/dreamwidth/commit/37986a727b09b6e12c0a08285eea937c90726b2c Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2022-11-18 (Fri, 18 Nov 2022)

Changed paths: M cgi-bin/DW/LatestFeed.pm

Log Message:


Merge pull request #3017 from dreamwidth/mark/issue-2968

Don't show adult journals/entries in Latest Things

Commit: 2547f60cfc8d99148c234ba6126782bdd1f5b2bb https://github.com/dreamwidth/dreamwidth/commit/2547f60cfc8d99148c234ba6126782bdd1f5b2bb Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2022-11-18 (Fri, 18 Nov 2022)

Changed paths: M bin/upgrading/proplists.dat M htdocs/manage/profile/index.bml.text M views/profile/main.tt.text

Log Message:


Merge pull request #3014 from dreamwidth/mark/issue-3002

Rename hangouts to chat

Commit: 3390d019706aacbe797f3b21d1a38e55d236b11d https://github.com/dreamwidth/dreamwidth/commit/3390d019706aacbe797f3b21d1a38e55d236b11d Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2022-11-18 (Fri, 18 Nov 2022)

Changed paths: M cgi-bin/LJ/Directory/Constraint/Location.pm

Log Message:


Merge pull request #3024 from kareila/location-results

limit directory search by location results to visible users

Commit: fa97da7f08574f1e9ee6445b31c8c46d0e12ddd1 https://github.com/dreamwidth/dreamwidth/commit/fa97da7f08574f1e9ee6445b31c8c46d0e12ddd1 Author: Alan Sill alan.sill@ttu.edu Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M ext/dw-nonfree/views/legal/dmca.tt

Log Message:


Update comments to match license stated, add link

Although the license stated in the text is CC-by-SA-2.5, the comments in the header incorrectly stated contradictory information apparently left over from use of that header in a code file. This pull request updaes the comments to be consistent with the license stated, and adds a link to the license as required for its use. I would like to fix these issues before making a copy to use on our own site with appropriate alterations and credit as per the license.

Commit: 3b9fbac192d2fb5d40051bc182b324ad41f6f157 https://github.com/dreamwidth/dreamwidth/commit/3b9fbac192d2fb5d40051bc182b324ad41f6f157 Author: Alan Sill alan.sill@ttu.edu Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M views/legal/privacy.tt

Log Message:


Update comments to match license stated, add link

Although the license stated in the text is CC-by-SA-2.5, the comments in the header stated inconsistent information apparently left over from use of that header in a code file. This pull request updates the comments to be consistent with the license stated, and adds a link to the license as required by the license terms for its use. I would like to fix these issues before making a copy to use on our own site with appropriate alterations and credit as per the license.

CODE TOUR: no-impact

Commit: b6cdf59812e69f7d65063c4cd28bccee64da4e9b https://github.com/dreamwidth/dreamwidth/commit/b6cdf59812e69f7d65063c4cd28bccee64da4e9b Author: Mark Smith mark@qq.is Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M cgi-bin/DW/Controller/Manage/Logins.pm M cgi-bin/LJ/User/Login.pm M views/manage/logins.tt

Log Message:


Allow logging out multiple sessions/all sessions (#3016)

  • Fix loginlog with long ua's

This trims useragents so they fit into the VARCHAR(100) that is the db column. This also fixes so that we will log errors when we fail to record logins, so this won't show up silently in production.

  • Add multi-select and logout all

This adds the ability to log out multiple sessions at the same time as well as to log out all sessions in one click, including the one you're actively using.

Commit: 5b46f4df94133aad359e20aeb3a7729fd965ed88 https://github.com/dreamwidth/dreamwidth/commit/5b46f4df94133aad359e20aeb3a7729fd965ed88 Author: alierak alierak@gmail.com Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M cgi-bin/LJ/Entry.pm

Log Message:


uncompress comment subject after retrieving from db (#3019)

Commit: d71f904220f91cfbbb497d29cb885b691290bd67 https://github.com/dreamwidth/dreamwidth/commit/d71f904220f91cfbbb497d29cb885b691290bd67 Author: Jen kareila@dreamwidth.org Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M cgi-bin/DW/Controller/Shop/CreditCard.pm M cgi-bin/DW/Controller/Stats.pm M cgi-bin/DW/Countries.pm M cgi-bin/DW/Logic/ProfilePage.pm M cgi-bin/LJ/Widget/Location.pm

Log Message:


more generic fix for legacy country codes (#3031)

Years ago, we changed our source of country code data to use a standard CPAN module. This has largely worked well except for a couple of odd corner cases where the previous country code stored in user data didn't match up with the new source. The obvious one was the change from UK to GB, so we kludged in recognition for both codes, and then deleted the older one anywhere it showed up as a duplicate in a drop down menu.

Subsequently it was noted that there was a legacy code for Scotland (LJSC) which needed the same treatment. Instead of continuing to expand the kludge, this adds a second class method, load_legacy, to use when requesting the version of the data that includes the older codes. That way we can go back to calling the basic load method without having to then delete the extra codes in the caller. And if we stumble across any other missing codes, they'll be maintained in one place.

Fixes #2197.

Commit: 62037b77fa4fa549f1e967f731cbc0cfffdbcf84 https://github.com/dreamwidth/dreamwidth/commit/62037b77fa4fa549f1e967f731cbc0cfffdbcf84 Author: Mark Smith mark@qq.is Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M bin/upgrading/update-db-general.pl

Log Message:


Remove timecheck column (#3015)

This column is unused, let's drop it.

Commit: 28f8ed239d0c2f7507339629549484f519edd6b5 https://github.com/dreamwidth/dreamwidth/commit/28f8ed239d0c2f7507339629549484f519edd6b5 Author: Denise Paolucci alanna@kekkai.org Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M ext/dw-nonfree/views/legal/dmca.tt

Log Message:


Merge pull request #3039 from alansill/patch-1

Update comments to match license stated, add link

Commit: b9ddeb84fe8817e7ce5248c50e07a3111dc9b675 https://github.com/dreamwidth/dreamwidth/commit/b9ddeb84fe8817e7ce5248c50e07a3111dc9b675 Author: Denise Paolucci alanna@kekkai.org Date: 2022-11-22 (Tue, 22 Nov 2022)

Changed paths: M views/legal/privacy.tt

Log Message:


Merge pull request #3040 from alansill/patch-2

Update comments to match license stated, add link

Commit: a0ca65ee1b7a9cba644d6554ee6c1d7deb3b331a https://github.com/dreamwidth/dreamwidth/commit/a0ca65ee1b7a9cba644d6554ee6c1d7deb3b331a Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2023-01-03 (Tue, 03 Jan 2023)

Changed paths: M .gitignore A api/README.md A api/build.js R api/comments/screening.yaml A api/dist/comments/screening.yaml A api/dist/components/error.yaml A api/dist/components/errors/400.yaml A api/dist/components/errors/404-user.yaml A api/dist/components/schemas/icon.yaml A api/dist/components/schemas/username.yaml A api/dist/icons.yaml A api/dist/icons_all.yaml A api/dist/spec.yaml R api/icons.yaml R api/icons_all.yaml A api/package-lock.json A api/package.json R api/spec.yaml A api/src/comments/screening.yaml A api/src/components/error.yaml A api/src/components/errors/400.yaml A api/src/components/errors/404-user.yaml A api/src/components/schemas/icon.yaml A api/src/components/schemas/username.yaml A api/src/icons.yaml A api/src/icons_all.yaml A api/src/spec.yaml M cgi-bin/Apache/LiveJournal.pm M cgi-bin/DW/API/Key.pm M cgi-bin/DW/API/Method.pm M cgi-bin/DW/API/Parameter.pm M cgi-bin/DW/Controller/API/REST.pm M cgi-bin/DW/Controller/API/REST/Icons.pm M cgi-bin/DW/Controller/API/REST/Spec.pm M cgi-bin/DW/Routing.pm M cgi-bin/LJ/JSON.pm A htdocs/js/vendor/rapidoc-min.js A views/api.tt

Log Message:


API tooling (#3033)

  • Updates to API generation and tooling

  • Added build script and build instructions for API files

  • Updated .gitignore to keep node_module folders out, wherever they occur
  • Rewrite existing YAML files to use new component system
  • Compile rewritten YAML files
  • Add more validation checks to the route builders and dispatchers
  • Add a user-facing documentation page with interactive view using RapiDoc
  • Add a generic 404 handler for missing routes under /api, which returns JSON instead of HTML
  • Clean up spec output route slightly to make it valid OpenAPI 3.0.0

  • Auto-fill API Key in docs

Co-authored-by: Cocoa momijizukamori@gmail.com

Commit: a229a620d2cbf6131fbaf5990f91f4852ccc155b https://github.com/dreamwidth/dreamwidth/commit/a229a620d2cbf6131fbaf5990f91f4852ccc155b Author: Mark Smith mark@dreamwidth.org Date: 2023-01-04 (Wed, 04 Jan 2023)

Changed paths: M api/build.js M api/dist/icons.yaml M api/src/icons.yaml M cgi-bin/Apache/LiveJournal.pm M cgi-bin/DW/API/Method.pm M cgi-bin/DW/API/Parameter.pm M cgi-bin/DW/Controller/API/REST.pm M cgi-bin/DW/Controller/API/REST/Spec.pm M views/api.tt

Log Message:


Fix some build steps

Also some tweaks so that the documentation and such works on my test hack.

Commit: 7df3589f235e894ecab505efba6187416e488b23 https://github.com/dreamwidth/dreamwidth/commit/7df3589f235e894ecab505efba6187416e488b23 Author: Jen kareila@dreamwidth.org Date: 2023-01-04 (Wed, 04 Jan 2023)

Changed paths: M htdocs/scss/skins/_page-layout-hacks.scss

Log Message:


[#2921] fix table header background color on Foundation pages (#3026)

I found where the table header link colors were specified and dropped in a rule for a background color so that the links would be legible again.

It was very obvious on the admin/statushistory page, but this should affect any Foundation pages with similarly defined table header elements.

I don't know if this is the best solution, but it seems like an improvement. I did check legibility in all the different site schemes.

Commit: e1a6869015e53471ffe3a531dab6573e7fa56c9b https://github.com/dreamwidth/dreamwidth/commit/e1a6869015e53471ffe3a531dab6573e7fa56c9b Author: Jen kareila@dreamwidth.org Date: 2023-01-04 (Wed, 04 Jan 2023)

Changed paths: M cgi-bin/LJ/Widget/ShopItemOptions.pm M htdocs/shop/account.bml M htdocs/shop/account.bml.text

Log Message:


try again with warning users off buying regular paid time for premium accounts (#3022)

  • revert the reversion

  • tweaks pt 1

  • better error checking on arguments to DW::Pay functions. they don't behave nicely when given bogus inputs, causing the widget to quietly bomb out from under us.

  • also check additional logic in allow_account_conversion for permitting paid time to be applied to a premium account.

  • note that the 0.7 is expressed as a constant elsewhere. possibly this whole code block should be redefined as a hook since it assumes dw-nonfree business logic.

  • tweaks pt 2

This isn't pretty, but it prevents the scenario where widget errors disappear into a BML block that was being ignored. That's why we were seeing the problem with purchase attempts disappearing instead of telling us what went wrong.

One day, someone will rewrite LJ::Widget not to use BML.

Commit: 4374b5b002f6f07f0530e27413a3503f63db4075 https://github.com/dreamwidth/dreamwidth/commit/4374b5b002f6f07f0530e27413a3503f63db4075 Author: Michael michael@vivtek.com Date: 2023-02-13 (Mon, 13 Feb 2023)

Changed paths: M etc/config-local.pl.example

Log Message:


Restored close-bracket in config-local.pl.example (#3068)

Compare: https://github.com/dreamwidth/dreamwidth/compare/7bf9564b9c0f...4374b5b002f6

Page generated Sep. 14th, 2025 10:03 am
Powered by Dreamwidth Studios