[dreamwidth/dw-free] 7ad114: Fix email sending duplication logic

[github]

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 7ad114dd754c23accc69d4628ac3f74d11cc52b2 https://github.com/dreamwidth/dw-free/commit/7ad114dd754c23accc69d4628ac3f74d11cc52b2 Author: Mark Smith mark@dreamwidth.org Date: 2022-01-07 (Fri, 07 Jan 2022)

Changed paths: M cgi-bin/DW/Task/SendEmail.pm

Log Message:

---

Fix email sending duplication logic

The 'don't duplicate emails' logic was too conservative. If we hit a transient error later sending the email (which happens all the time), then we would never actually retry because we set the key too early.

This fixes it to move setting the MemCache bit until the very end of the email flow. This means there's a tiny risk of us duplicating an email, but this does make it more of an at-least-once system (rather than an at-most-once system, which is not great for email.)

[dreamwidth/dw-free] 813f94: Tidy

[github]

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 813f94bae22dde49822f65344ab5b11db28fe42a https://github.com/dreamwidth/dw-free/commit/813f94bae22dde49822f65344ab5b11db28fe42a Author: Mark Smith mark@dreamwidth.org Date: 2022-01-07 (Fri, 07 Jan 2022)

Changed paths: M cgi-bin/DW/Controller/Support/Request.pm M cgi-bin/LJ/Global/Defaults.pm

Log Message:

---

Tidy

Fix some "mark was in prod again and forgot to tidy" issues...

[dreamwidth/dw-free] 09813d: Fix (hopefully) Travis error

[github]

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 09813dfcaf5e8283a65595038917a29c2ecc9f3f https://github.com/dreamwidth/dw-free/commit/09813dfcaf5e8283a65595038917a29c2ecc9f3f Author: Mark Smith mark@dreamwidth.org Date: 2022-01-07 (Fri, 07 Jan 2022)

Changed paths: M cgi-bin/LJ/Config.pm

Log Message:

---

Fix (hopefully) Travis error

This file has require-time logic that depends on LJ::Directories being around, so let's use it.

[dreamwidth/dw-free] c5f17a: Remove two missed log areas

[github]

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: c5f17af0cbc0bea488d82ed1e9b377c0ba6dfcb1 https://github.com/dreamwidth/dw-free/commit/c5f17af0cbc0bea488d82ed1e9b377c0ba6dfcb1 Author: Mark Smith mark@dreamwidth.org Date: 2022-01-07 (Fri, 07 Jan 2022)

Changed paths: M cgi-bin/LJ/Web.pm

Log Message:

---

Remove two missed log areas