![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
githubBranch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 307224364eebb7596324b0b7dc4c6bd379607615 https://github.com/dreamwidth/dw-free/commit/307224364eebb7596324b0b7dc4c6bd379607615 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-15 (Mon, 15 Feb 2021)
Changed paths: M htdocs/scss/components/foundation-custom/_tables.scss M htdocs/scss/foundation/foundation.scss
Log Message:
Knock it off with the Foundation table styles
Disable Foundation table styles by default, but enable them for tables that opt in by setting class="table". Restore old padding for all other tables, but leave everything else relatively blank.
The Foundation site skins got away with these garish table styles as long as they weren't being used anywhere visible. But now that we're using those skins for real journal content, they're not an acceptable default. Based on the userbase's tendency to use tables for decorative markup, the default styles should do as little as possible, only adding a small amount of padding for readability.
Due to how CSS works, it's impractical to opt journal content out of global styles. So instead, any page that wants site skin styles for tabular data can opt in.
Commit: e9cc2baa04f0961de6d96a7b0d1a6b4f5410857c https://github.com/dreamwidth/dw-free/commit/e9cc2baa04f0961de6d96a7b0d1a6b4f5410857c Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-15 (Mon, 15 Feb 2021)
Changed paths: M views/admin/faq/faqcat.tt M views/admin/feeds/duplicate.tt M views/admin/feeds/merge.tt M views/admin/importer.tt M views/admin/importer/detail.tt M views/admin/importer/history.tt M views/admin/invites/codetrace.tt M views/admin/invites/promo.tt M views/admin/invites/requests.tt M views/admin/invites/review.tt M views/admin/pay/viewuser.tt M views/admin/rename.tt M views/admin/sendmail/lookup.tt M views/admin/sendmail/message.tt M views/admin/sysban/index.tt M views/admin/sysban/query.tt M views/admin/themes/category.tt M views/admin/themes/theme.tt M views/admin/translate/searchform.tt M views/communities/list.tt M views/communities/members/edit.tt M views/communities/queue/members.tt M views/customize/advanced/styles.tt M views/dev/style-guide.tt M views/dev/tests/libfunctions.html M views/directory/index.tt M views/feeds/list.tt M views/interests/int.tt M views/interests/popular.tt M views/invite/index.tt M views/oauth/admin/index.tt M views/oauth/index.tt M views/profile/main.tt M views/shop/cc/entercc.tt M views/shop/icons.tt M views/shop/points.tt M views/shop/transferpoints.tt M views/stats/main.tt M views/stats/site.tt M views/support/highscores.tt M views/support/history.tt
Log Message:
Add class="table" to a bunch of tables in views/ (but not all of em)
If it has any deprecated pre-CSS styling attributes like cellpadding or cellspacing, it obviously wasn't written with the expectation of being inserted into a modern website with global table styles, so it's in the same bucket as everyone's copy-pasted character sheet markup and does not want any schmancy default table styles.
If it has a style attribute that affects the interior content at all, it also probably predates the foundation site skins and I don't want to bother with it. But if it's just messing with the margins, that's probably fine.
Commit: 6be5c6679da60421c1d2f7134b846e533ceb1920 https://github.com/dreamwidth/dw-free/commit/6be5c6679da60421c1d2f7134b846e533ceb1920 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2021-02-15 (Mon, 15 Feb 2021)
Changed paths: M htdocs/scss/components/foundation-custom/_tables.scss
Log Message:
Remove styles for .data-table
AFAICT nothing anywhere within the entire site ever used this.
Compare: https://github.com/dreamwidth/dw-free/compare/926f5a5efac9...6be5c6679da6