Branch: refs/heads/master
Home:
https://github.com/dreamwidth/dw-free Commit: 6c6dee344b458e9f2c02c4b615daeabeb1d73310
https://github.com/dreamwidth/dw-free/commit/6c6dee344b458e9f2c02c4b615daeabeb1d73310 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M cgi-bin/LJ/Talk.pm
M htdocs/talkpost.bml.text
M views/journal/quickreply.tt
M views/journal/talkform.tt
Log Message:
-----------
Keyboard: remove invisible tabbable link in reply forms
Inserting an invisible control with destructive effects into a form's tab order:
not even once™.
Commit: 34e13fd62872de2e087184139db588230c2d1a59
https://github.com/dreamwidth/dw-free/commit/34e13fd62872de2e087184139db588230c2d1a59 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/scss/components/icon-browser.scss
Log Message:
-----------
Jank: stop animating thickness changes in icon browser
An interesting idea, but it always looked gross. My bad!
Commit: b9e8a41e9d5bb545beeac1716803c249bafd6885
https://github.com/dreamwidth/dw-free/commit/b9e8a41e9d5bb545beeac1716803c249bafd6885 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/scss/components/icon-browser.scss
M views/components/icon-browser.tt
Log Message:
-----------
Keyboard: Improve icon browser top controls
- Shift the logical order around so that you can tab directly from "search" to
the icon chooser controls, without having to tab through the display controls
first. (Although at the moment, tabbing into the icons doesn't work.) The
display controls are used more rarely than the icons themselves, so they
shouldn't act as a roadblock for keyboard likers.
Keeps current visual layout on modern browsers, but shifts things around a bit
on obsolete ones.
- Mark display controls as buttons (for accessibility), style them like the
icon keywords (for coherency), tighten up their labels (for concision).
Commit: adda4a817e3c3f7d7199beaee7cd8bb1bf5e1561
https://github.com/dreamwidth/dw-free/commit/adda4a817e3c3f7d7199beaee7cd8bb1bf5e1561 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
Log Message:
-----------
Remove something weird in icon browser JS
This looks like it was detritus from a wild debugging spree. I'll stipulate that
that issue might still be relevant (who knows), but the hack isn't necessary in
this spot, and it interferes with some other stuff that needs doing.
Commit: 7bb6f2d2db6b43c2768145b49e938156f2ed8939
https://github.com/dreamwidth/dw-free/commit/7bb6f2d2db6b43c2768145b49e938156f2ed8939 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
Log Message:
-----------
Keyboard: Restore reply form tab position when icon browser exits
The icon browser's div lives at the bottom of the body element, so when its
controls lose focus, the tab position lands miles away from the reply form
you're trying to type in. This puts it back somewhere useful -- specifically,
on the icon menu, which is the control right after the browse button you just
finished using.
Commit: 502b64a46b73cdbf7092887fd19ba5169a8a86a9
https://github.com/dreamwidth/dw-free/commit/502b64a46b73cdbf7092887fd19ba5169a8a86a9 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
Log Message:
-----------
Keyboard: Mark icon browser controls as buttons
This enables tab-navigating through the icons and keywords, and provides useful
semantic information to assistive tools. Mind, you can't yet DO anything
interesting once you've tabbed to an icon, since enter-to-select is busted.
Commit: d6037cea22bae82f406e01507c3eb12b8d79ab17
https://github.com/dreamwidth/dw-free/commit/d6037cea22bae82f406e01507c3eb12b8d79ab17 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
Log Message:
-----------
Simplify and improve icon browser's filter function
Previous implementation stashed a backup of the main element and then sprayed
duplicated objects all over the place. That did weird shit with the selected
icon state, which was untenable if any other part of the component cared about
said state. Anyway:
- Keep the set of elements stable; just hide and reveal stuff.
- De-select the selected item if it becomes excluded from the current search.
(Otherwise the browser could have an invisible item selected. 👻)
- Stop spamming the console with forgotten debug info on every keystroke.
Commit: bd3e6795d62568fbdb1464534964ca51183c8804
https://github.com/dreamwidth/dw-free/commit/bd3e6795d62568fbdb1464534964ca51183c8804 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
Log Message:
-----------
Keyboard: Reliably focus search field when summoning icon browser
It looks like this was the intended behavior, but it was only being invoked the
first time the browser was summoned, not subsequent times. (And sometimes not
even then, because the `open` handler maybe has some kind of race condition for
focus.)
Commit: 5d73bd7b2222fe95874804c18023b9658d127b1a
https://github.com/dreamwidth/dw-free/commit/5d73bd7b2222fe95874804c18023b9658d127b1a Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
Log Message:
-----------
Keyboard: Fix icon browser's enter-to-select
This was somewhat broken, for several reasons. Now you can keyboard navigate the
whole browser.
- When tabbed to an icon or keyword, enter clicks it.
- In the search field, enter confirms the currently selected icon, for going
fastfast when you know the exact string that will filter to one icon.
- Add slash-to-search for all u PoWeR uSeRs out there. 🛹
- Guts: ignore deprecated KeyboardEvent.keyCode prop if you're not retrocomputing. 💾
Commit: 446a459f664a166a2aee5144c98095e055b40f24
https://github.com/dreamwidth/dw-free/commit/446a459f664a166a2aee5144c98095e055b40f24 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-05-04 (Mon, 04 May 2020)
Changed paths:
M htdocs/js/components/jquery.icon-browser.js
M htdocs/scss/components/icon-browser.scss
M views/components/icon-browser.tt
Log Message:
-----------
Clean up icon browser top controls, clarify interactions
A moderate redesign for the beta icon browser.
- Spawn the "select" button right next to the active icon, so "tap twice" isn't
crucial anymore. (No select button when nothing's selected.)
- On modern browsers (grid = yes), lose that clunky keywords menu in the
top controls. Instead:
- If meta text = yes, use that.
- If meta text = no, spawn a keywords menu right below the selected icon.
Sort of a just-in-time version of the meta text = yes experience, but
eating less vertical space thx to grid. Since the context is clear, the
menu doesn't need explanatory text.
Obsolete browsers get the new confirm button, but keep current keyword behavior.
Compare:
https://github.com/dreamwidth/dw-free/compare/4fa9048155e5...446a459f664a![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
github