Branch: refs/heads/master
Home:
https://github.com/dreamwidth/dw-free Commit: c540d565c7bd0419f59193708dad4f42b6db59cc
https://github.com/dreamwidth/dw-free/commit/c540d565c7bd0419f59193708dad4f42b6db59cc Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M htdocs/js/jquery.quickreply.js
M htdocs/scss/components/quick-reply.scss
Log Message:
-----------
[#2535] Let quick-reply stretch its legs if there's room on the left
Standard comment indentation can shrink comment boxes down to slivers, and the
initial version of the responsive quick-reply was constrained to the comment
box. This leaves the form feeling VERY CRAMPED. (It used to just overflow
rightwards, because tables gonna do what tables gonna do.)
But if the box shrank because of indentation, then by definition there's a TON
of unused room off on the left. This commit does some simple measurements
whenever we summon the quickreply into place, and if staying in the box would
make it too narrow, we expand it (and give it a shove to the left to make sure
it overflows in the correct direction). We also take a peek to see what
background color it probably has when its inside the box, and apply that
background color to the overflowed part so it looks less like glitch art. (The
adjustments to padding are to make sure this looks nice.)
What's "too narrow?" If the viewport is big and there's plenty of room, 640px
seems like a nice minimum. Once you take the padding into account, that leaves
the form wide enough for about 45 characters of 13px Courier (a common default
for textareas). If viewport is small, we're probably space-constrained in the
first place and actually never want the comment form to shrink below where it
would be in a top-level comment. So in that case, we find the first comment on
the page (which is _always_ a top-level reply to the original post, because of
how DW collapses comment threads once pagination kicks in) and measure how much
space a comment would have up there.
Commit: 1e557964a83367f970ee3b63a331df8fc3f620e2
https://github.com/dreamwidth/dw-free/commit/1e557964a83367f970ee3b63a331df8fc3f620e2 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M htdocs/scss/components/quick-reply.scss
Log Message:
-----------
[#2528] QR: Change order of footer buttons
UI convention in LTR languages sez the "OK thanks BYE" button goes on the right.
Commit: 5507b88837516e218884043ca99c12b75c1b87ab
https://github.com/dreamwidth/dw-free/commit/5507b88837516e218884043ca99c12b75c1b87ab Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M htdocs/scss/components/quick-reply.scss
M views/journal/quickreply.tt
Log Message:
-----------
QR: Move quote button up by subject
The buttons at the bottom should be things you do when you're _done_ writing
your comment. Quote is a formatting button, useful _while_ writing your comment.
So it should be up higher by the comment-writing controls, not the
comment-ending controls.
As part of this, I'm removing it from the tab index, so keyboard users don't
have to tab through it to get from subject to body. Note this pattern also on
GitHub's formatting buttons. I'm also removing the `display: none`; we don't
need to hide it for no-js users, because the quick-reply form can only be
summoned with JavaScript enabled anyway.
A future design will likely include a row of formatting controls between the
subject and body, like you can see here on GitHub when commenting or opening an
issue. When that happens, quote will join those. In the meantime, putting it
beside subject keeps it nicely out of the way.
TBH I already wanted to do this during the initial redesign, but I couldn't
stomach what happened when the qrform got squished down below like 200px. But
now it's kicking out to the left to preserve its size when it's deep in a
comment thread, so we're free!
Commit: fe17ac39a88c9a62e511519c6f25fd0556f5adb9
https://github.com/dreamwidth/dw-free/commit/fe17ac39a88c9a62e511519c6f25fd0556f5adb9 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M htdocs/scss/components/quick-reply.scss
Log Message:
-----------
QR: Don't make icon menu too long in old browsers
The width: 100% is just to massage the flexbox behavior; it's not
necessary if you don't know how to flex.
Commit: 2a4344be8ad10c5c5a761287418b0c548913c56b
https://github.com/dreamwidth/dw-free/commit/2a4344be8ad10c5c5a761287418b0c548913c56b Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M htdocs/scss/components/quick-reply.scss
Log Message:
-----------
QR: If there's no flexbox, float the 'post' button to the right
Flexbox is still the right tool for this job, but this will keep usability
steady in old browsers.
Commit: 47cd716a748c98912f7819a3276bb76acdd90f19
https://github.com/dreamwidth/dw-free/commit/47cd716a748c98912f7819a3276bb76acdd90f19 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M cgi-bin/LJ/Web.pm
Log Message:
-----------
[#2545] QR: Use `nouserpic_sitescheme` as data-url when there's no default icon
For users with no icons, we display the faded-out DW logo in place of the icon
preview in the quickreply. We also do that for users with no default icon, but
if they switch to a real icon and then switch _back_ to default, we replace it
with an empty glitched img tag, because the `data-url` attribute for `(default)`
is an empty string.
This commit checks whether the user's `defaultpicurl` is empty, and if so, it
falls back to the URL of the same `nouserpic_sitescheme` placeholder icon.
Commit: 353b92fa477b6deb7269170c037a8d522e4e58b1
https://github.com/dreamwidth/dw-free/commit/353b92fa477b6deb7269170c037a8d522e4e58b1 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M views/journal/quickreply.tt
Log Message:
-----------
[#2545] QR: Disable in-icon browse button for paid users with zero icons
We already omit the random button, the menu, and the redundant browse button if
there's no icons to pick from, but we were leaving a glitchy null button around
the icon preview.
Commit: 2eef84c3669d2de8bdf326f77b3824b705feee10
https://github.com/dreamwidth/dw-free/commit/2eef84c3669d2de8bdf326f77b3824b705feee10 Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-07-10 (Wed, 10 Jul 2019)
Changed paths:
M cgi-bin/LJ/Web.pm
Log Message:
-----------
Simplify the defaultpicurl fallback
Compare:
https://github.com/dreamwidth/dw-free/compare/abb8bca6c08a...2eef84c3669d![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
github