[dreamwidth/dw-free] 662793: [#2437] Extract talkform into template (#2479)

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 6627936f56d7ea226af0e4fce77d85323a79540b
https://github.com/dreamwidth/dw-free/commit/6627936f56d7ea226af0e4fce77d85323a79540b
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-10 (Mon, 10 Jun 2019)

Changed paths:
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/S2/EntryPage.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/LJ/Web.pm
M htdocs/js/talkpost.js
M htdocs/talkpost.bml.text
M views/journal/controlstrip.tt
A views/journal/talkform.tt

Log Message:
-----------
[#2437] Extract talkform into template (#2479)

* Cleanup: add missing copyright/author header to controlstrip.tt

* Web.pm: Extract userpic lister into a function

* Improve subjecticon implementation (breaks talkform, fixing in next commit)

- Use more comprehensible function names.
- Don't require callers to constantly pass around that hashref.
- Abstract the print functions enough that we could easily replace the
implementation with big emoji or something.
- Add 'none' as an option in the index, so you don't need a special function to
print the "none image".
- Cache the (hardcoded) results of get_subjecticons in a closed-over var,
instead of re-calculating every time.
- Actually document it.

* [#2437] Extract talkform into template

This commit is intended as a no-op, and it specifically **doesn't** address the
fact that the talkform is awful garbage. That comes later. The only changes in
behavior are a few fixed bugs where the intended behavior was reasonably clear
but the implementation just didn't _do_ it. (Hiding the "otheruser" row but not
hiding lj_more, hiding the openID login fields for a case that was exactly
equivalent to another case where it showed them, blatantly un-closed or
over-closed HTML tags, etc.)

* [#2437] OpenID is always enabled

Changed upstream while the branch was in progress.

* Talkform: Fix bug when posting as a different user than the logged-in one

* Run tidy

* Style adjustments from PR review

* Simplify handling of subjecticons in talkform

Whenever practical, pass around IDs instead of hashrefs.

* Re-tidy Talk.pm

[dreamwidth/dw-free] 3bd77b: Styles: Modernize image constraints (#2486)

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 3bd77b455880a12ceff605ce2b87a52dddc134db
https://github.com/dreamwidth/dw-free/commit/3bd77b455880a12ceff605ce2b87a52dddc134db
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-10 (Mon, 10 Jun 2019)

Changed paths:
M styles/abstractia/layout.s2
M styles/bases/layout.s2
M styles/blanket/layout.s2
M styles/brittle/layout.s2
M styles/core2base/layout.s2
M styles/drifting/layout.s2
M styles/easyread/layout.s2
M styles/goldleaf/layout.s2
M styles/mobility/layout.s2
M styles/negatives/layout.s2
M styles/skittlishdreams/layout.s2
M styles/snakesandboxes/layout.s2
M styles/summertime/layout.s2
M styles/trifecta/layout.s2
M styles/venture/layout.s2

Log Message:
-----------
Styles: Modernize image constraints (#2486)

* [#2485] Modernize image size constraints on Tabula Rasa (and descendents)

I bring you tidings of liberation: we don't have to choose between overflowing
the container, botching the aspect ratio when width/height attributes are
present, or disrespecting the user's effort to set w/h smaller than native.
Newer CSS stuff can take care of it.

* [#2485] Modernize image size constraints in some straggler layouts