[dreamwidth/dw-free] 188786: fix undefined string warnings

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 188786a92f5f72891f7854098bd20e20d13eb241
https://github.com/dreamwidth/dw-free/commit/188786a92f5f72891f7854098bd20e20d13eb241
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
fix undefined string warnings

Use of uninitialized value in pattern match (m//) .. cgi-bin/LJ/CleanHTML.pm line 1419.

Use of uninitialized value in concatenation (.) or string .. cgi-bin/DW/Controller/Entry.pm line 1496.


Commit: 378067bd62597abf5fb6d2c87c2025a544c7dda9
https://github.com/dreamwidth/dw-free/commit/378067bd62597abf5fb6d2c87c2025a544c7dda9
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
[#1948] add wbr tag to list of void elements

Should be treated the same as the br tag.

This fixes the reported problem where if someone
used in an entry, it would get autoclosed
with , which is invalid markup. Now it
will get changed to instead.


Commit: b57bc0fef6d34b814f51903eb7df75a13bcc8f5f
https://github.com/dreamwidth/dw-free/commit/b57bc0fef6d34b814f51903eb7df75a13bcc8f5f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1948] prefer punctuation points for word breaks

In most areas (entries, subjects, comments) the HTML cleaner will
insert a wbr tag in any "word" (text unbroken by whitespace)
longer than 40 characters, exactly at the 40th character point,
and for every 40 characters thereafter, if autoformatting is active.

This behavior could be improved, so let's try checking each
40 characters for punctuation characters, and if found, insert
the word break at that point instead.


Commit: 81580e1ce9e68dc3253db014e0b481372a374814
https://github.com/dreamwidth/dw-free/commit/81580e1ce9e68dc3253db014e0b481372a374814
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1948] tweaks for word break behavior

1. The \B match failed if the word ended with punctuation, so just check to
see if we're at the end of the word after the match succeeds.

2. Make sure the regex finds the LAST punctuation character in the string.
Unexpectedly, it was matching the first one instead.

3. Don't do a breakpoint shift if the last punctuation character in the string
is the first character in the string - a common edge case resulting in a
premature word break.

4. Refactor printing logic to remove unneeded else case from conditional.

Also: more tests! Tests are great.


Commit: 66e9cc108b775758600678ad83373e97477ca928
https://github.com/dreamwidth/dw-free/commit/66e9cc108b775758600678ad83373e97477ca928
Author: Mark Smith <mark@qq.is>
Date: 2017-01-31 (Tue, 31 Jan 2017)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
Merge pull request #1949 from kareila/1948-wbr-fix

better automatic word-break behavior


Compare: https://github.com/dreamwidth/dw-free/compare/73bb021de6ff...66e9cc108b77