[dreamwidth/dw-free] aa8afc: Remove flip-flop warnings from test suite

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: aa8afc13175d1b1153966d29f69081a030d1b647
https://github.com/dreamwidth/dw-free/commit/aa8afc13175d1b1153966d29f69081a030d1b647
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-10 (Tue, 10 Jan 2017)

Changed paths:
M t/esn-journalnewcomment.t
M t/notificationinbox.t

Log Message:
-----------
Remove flip-flop warnings from test suite

Use of uninitialized value $. in range (or flip) at t/esn-journalnewcomment.t line 170.

Use of uninitialized value $. in range (or flip) at t/esn-journalnewcomment.t line 208.

Use of uninitialized value $. in range (or flip) at t/notificationinbox.t line 28.

Use of uninitialized value $. in range (or flop) at t/notificationinbox.t line 28.

I'm not sure why these suddenly manifested while testing on
the blobstore branch, but they appear to hinge on using
questionable syntax to assign to a hash slice. Rewritten
as a postfix foreach to achieve more clarity/less shadiness.

A Google search on the error message turned up
http://www.perlmonks.org/?node_id=525392 which was
educational if not exactly enlightening.


Commit: 49b9210ad2e1999ecfbc6a992f9f7ffb26033e01
https://github.com/dreamwidth/dw-free/commit/49b9210ad2e1999ecfbc6a992f9f7ffb26033e01
Author: Mark Smith <mark@qq.is>
Date: 2017-01-11 (Wed, 11 Jan 2017)

Changed paths:
M t/esn-journalnewcomment.t
M t/notificationinbox.t

Log Message:
-----------
Merge pull request #1938 from kareila/cleanup-2017q1

Remove flip-flop warnings from test suite


Compare: https://github.com/dreamwidth/dw-free/compare/0b0c8bb369a2...49b9210ad2e1