[dreamwidth/dw-free] 346829: Fix #1528: failure to untag shouldn't fail rest of...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 346829d666d389c9e12eae7d1fa45134e0d42875
https://github.com/dreamwidth/dw-free/commit/346829d666d389c9e12eae7d1fa45134e0d42875
Author: Chris Boyle <chris@boyle.name>
Date: 2016-04-19 (Tue, 19 Apr 2016)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Tags.pm
M htdocs/editjournal.bml
M views/entry/success.tt

Log Message:
-----------
Fix #1528: failure to untag shouldn't fail rest of edit but should fail a tag-add (#1739)

* Remove use of missing string.

* Make warnings on successful edits more prominent.

This is consistent with what the beta editor does.

* On tag-edit failure, warn but allow rest of edit.

Previously it would present an error despite having applied *some of*
the rest of the edit, e.g. body but not props/slug.

The change to Tags.pm means if a tag removal is rejected, any tag
additions also don't happen. In principle you could leave out that
change, but it didn't look trivial to make edittags.bml behave
consistently without the change (if you're going to mostly-succeed you
should still end up at the entry page, which we can't easily put a
warning at the top of).

Fixes: #1528

* Be explicit about not adding tags.

* Move warnings higher up edit success page.

* Rephrase tag delete error; list all entry's tags.

* Put tags warning on multiple lines.

* Put multiple add/delete errors on multiple lines.