Apr. 5th, 2016

github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 0aca0cb4d604e8f8bc465080cde430f23174b567
https://github.com/dreamwidth/dw-free/commit/0aca0cb4d604e8f8bc465080cde430f23174b567
Author: Kareila <kareila@dreamwidth.org>
Date: 2016-04-05 (Tue, 05 Apr 2016)

Changed paths:
M cgi-bin/DW/CleanEmail.pm
M cgi-bin/DW/EmailPost/Comment.pm
M t/emailpost-comment.t

Log Message:
-----------
[#1643] remove HTML entities from default comment reply subjects

Using the subject_text method on the parent comment returns
HTML-escaped text, so the reply_subject method should remove
the HTML escaping. Otherwise the resulting text will end up
double-escaped on the site.

Custom reply subjects did not have the escaping problem, but
this adds test cases for both scenarios just to be sure.

Fixes #1643.


Commit: 14e0569cadf836400777ce296ce2f26f0ae91dbd
https://github.com/dreamwidth/dw-free/commit/14e0569cadf836400777ce296ce2f26f0ae91dbd
Author: Mark Smith <mark@qq.is>
Date: 2016-04-05 (Tue, 05 Apr 2016)

Changed paths:
M cgi-bin/DW/CleanEmail.pm
M cgi-bin/DW/EmailPost/Comment.pm
M t/emailpost-comment.t

Log Message:
-----------
Merge pull request #1736 from kareila/1643-unescape-subject

[#1643] remove HTML entities from default comment reply subjects


Compare: https://github.com/dreamwidth/dw-free/compare/494014f411f8...14e0569cadf8
Page generated Jul. 16th, 2025 05:39 am
Powered by Dreamwidth Studios