[dreamwidth/dw-free] 68d3a4: [#1570] reorder logic for control strip selection ...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 68d3a480f57e4464b41d21463b7119da56cc22bd
https://github.com/dreamwidth/dw-free/commit/68d3a480f57e4464b41d21463b7119da56cc22bd
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-09-07 (Mon, 07 Sep 2015)

Changed paths:
M cgi-bin/LJ/Web.pm

Log Message:
-----------
[#1570] reorder logic for control strip selection state

The previous conditional for implicit default filter selection would
only execute if the query string was blank. Adding *any* arguments
(for example, skip=N) would switch it to the branch that checked
for showtypes.

We can fix this by making the if statements sequential instead
of either/or, and doing the filter check before the showtype
check. However, we now also need to explicitly check for filter=0
to make sure that the "All Subscriptions" selection is still
honored in the presence of a default filter.

Fixes #1570.


Commit: 65509bb19227b53b6a334da5bd42de3e93d8d8a9
https://github.com/dreamwidth/dw-free/commit/65509bb19227b53b6a334da5bd42de3e93d8d8a9
Author: Mark Smith <mark@qq.is>
Date: 2015-09-07 (Mon, 07 Sep 2015)

Changed paths:
M cgi-bin/LJ/Web.pm

Log Message:
-----------
Merge pull request #1572 from kareila/1570-filter-select

[#1570] reorder logic for control strip selection state


Compare: https://github.com/dreamwidth/dw-free/compare/d0ba70435993...65509bb19227