[dreamwidth/dw-free] b73240: Fix failing tests in formerrors.t

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: b73240d152f6263a768234ff1051bfdfb3540288
https://github.com/dreamwidth/dw-free/commit/b73240d152f6263a768234ff1051bfdfb3540288
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-18 (Sat, 18 Apr 2015)

Changed paths:
M t/formerrors.t

Log Message:
-----------
Fix failing tests in formerrors.t

Message behavior has changed. Before, we expected an empty string when given
a bogus ml key; now it seems to print the "missing string" error instead.


Commit: 1f9ab63a4b2d9942077c48853396d2d5704c37c3
https://github.com/dreamwidth/dw-free/commit/1f9ab63a4b2d9942077c48853396d2d5704c37c3
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-18 (Sat, 18 Apr 2015)

Changed paths:
M t/console-priv.t

Log Message:
-----------
Fix failing test in console-priv.t

# Failed test at t/console-priv.t line 39.
# got: 'error: You are not permitted to grant admin:*'
# expected: 'error: You are not authorized to run this command.'
# Looks like you failed 1 test of 24.

Update expected error to match the actual error.


Commit: aa2eaf69675dfec3ca5a0c968d3d2381b199f7f4
https://github.com/dreamwidth/dw-free/commit/aa2eaf69675dfec3ca5a0c968d3d2381b199f7f4
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-18 (Sat, 18 Apr 2015)

Changed paths:
M t/config-test.pl

Log Message:
-----------
[#1219] atom-post.t breaks unless $LJ::ONLY_USER_VHOSTS is true.

Add this directive to t/config-test.pl.

Fixes #1219.


Commit: 97d4cce60e0970af59be11ac1e5539ec6c0eef56
https://github.com/dreamwidth/dw-free/commit/97d4cce60e0970af59be11ac1e5539ec6c0eef56
Author: Afuna <afuna@users.noreply.github.com>
Date: 2015-04-22 (Wed, 22 Apr 2015)

Changed paths:
M t/config-test.pl
M t/console-priv.t
M t/formerrors.t

Log Message:
-----------
Merge pull request #1352 from kareila/fix-tests

Fix more tests


Compare: https://github.com/dreamwidth/dw-free/compare/5fae46be2bdf...97d4cce60e09

[dreamwidth/dw-free] ddb526: [#1340] print correct error message when can_refun...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: ddb5269fb815b3f6848c7843bb804e98a841cf19
https://github.com/dreamwidth/dw-free/commit/ddb5269fb815b3f6848c7843bb804e98a841cf19
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-15 (Wed, 15 Apr 2015)

Changed paths:
M views/shop/refundtopoints.tt

Log Message:
-----------
[#1340] print correct error message when can_refund is false

The clauses for "NOT points" and "NOT can_refund" were being tested out of order
and needed to be swapped. Now the more specific error condition executes first.

Fixes #1340.


Commit: 2abb5f49b015f9828821148c56c414b8de7c60a4
https://github.com/dreamwidth/dw-free/commit/2abb5f49b015f9828821148c56c414b8de7c60a4
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-15 (Wed, 15 Apr 2015)

Changed paths:
M etc/config.pl

Log Message:
-----------
[#1340] default config does not contain refund rate for paid accounts

I had trouble testing the previous commit because the config values for _refund_points
were never committed anywhere. Without that information, it prints an unhelpful error
message: "Sorry, your account type is not eligible for a points conversion."

This adds the values we set in production: 30 for paid, and 41 for premium paid.


Commit: 324682928fcc9214642cc7f4b356e2d16eb43f4c
https://github.com/dreamwidth/dw-free/commit/324682928fcc9214642cc7f4b356e2d16eb43f4c
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-18 (Sat, 18 Apr 2015)

Changed paths:
M cgi-bin/DW/Controller/Shop.pm
M views/shop/refundtopoints.tt
M views/shop/refundtopoints.tt.text

Log Message:
-----------
[#1340] print the date after which refundtopoints may be used again

In addition to the current error message of "Sorry, you can only refund
paid time once every thirty days," add clarifying text: "You won't be
able to convert paid time to points again until after [[date]]."


Commit: d89ec421ec18323c200aca2f15184041a145bcc6
https://github.com/dreamwidth/dw-free/commit/d89ec421ec18323c200aca2f15184041a145bcc6
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-18 (Sat, 18 Apr 2015)

Changed paths:
M views/shop/refundtopoints.tt.text

Log Message:
-----------
[#1340] tweak wording of toosoon error message

Change "refund" to "convert" for consistency with nextrefund phrasing.

Renaming the translation key is unneeded because the string was never
displayed on the live site.


Commit: 4bbfa2547464beb29847415282b1c8eb05d63417
https://github.com/dreamwidth/dw-free/commit/4bbfa2547464beb29847415282b1c8eb05d63417
Author: Afuna <afuna@users.noreply.github.com>
Date: 2015-04-22 (Wed, 22 Apr 2015)

Changed paths:
M cgi-bin/DW/Controller/Shop.pm
M etc/config.pl
M views/shop/refundtopoints.tt
M views/shop/refundtopoints.tt.text

Log Message:
-----------
Merge pull request #1348 from kareila/1340-shop-points

fix refundtopoints error message for case where use attempted twice within 30 days


Compare: https://github.com/dreamwidth/dw-free/compare/97d4cce60e09...4bbfa2547464