[dreamwidth/dw-free] bdb9f2: Add t/config-test-private.pl to the skip list in u...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: bdb9f2a2fdd075d6ea339a5eeeaf5d7a707db02d
https://github.com/dreamwidth/dw-free/commit/bdb9f2a2fdd075d6ea339a5eeeaf5d7a707db02d
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-16 (Thu, 16 Apr 2015)

Changed paths:
M t/use-strict.t

Log Message:
-----------
Add t/config-test-private.pl to the skip list in use-strict.t.

Avoid failed test in use-strict.t for t/config-test-private.pl - config-test.pl was already skipped.


Commit: 2c26fbc18f41224a25df03197f1f94eadaa9fe96
https://github.com/dreamwidth/dw-free/commit/2c26fbc18f41224a25df03197f1f94eadaa9fe96
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-16 (Thu, 16 Apr 2015)

Changed paths:
M t/create-url.t

Log Message:
-----------
Update user domain tests in t/create-url.t

# Failed test 'invalid ssl'
# at t/create-url.t line 314.
# got: '1'
# expected: '0'
# Looks like you failed 1 test of 5.

This was the test case with input options: ssl unspecified, host => "foo.example.com"

I assume that the behavior changed when we enabled HTTPS for user domains.

For better coverage, I made the tests for foo.example.com the same as the preceding tests
for www.example.com, which means there are now four tests instead of two:

- https, input ssl unspecified, output ssl = 1
- https, input ssl = 1, output ssl = 1
- https, input ssl = 0, output ssl = 0
- http, input ssl = 1, output ssl = 1

With this configuration the tests all pass.


Commit: 012062dc534b007647faf870f8770930e6e3084c
https://github.com/dreamwidth/dw-free/commit/012062dc534b007647faf870f8770930e6e3084c
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-17 (Fri, 17 Apr 2015)

Changed paths:
M t/post.t

Log Message:
-----------
[#1220] t/post.t: skip default moodtheme check if we haven't defined one

Use of uninitialized value in numeric eq (==) at t/post.t line 129.
# Failed test 'Default mood theme.'
# at t/post.t line 129.

There is no %USER_INIT hash in config-test.pl, so we should skip the relevant test in that case.


Commit: c39b3b3ae56811c96683e60b74ff47c37c6efc21
https://github.com/dreamwidth/dw-free/commit/c39b3b3ae56811c96683e60b74ff47c37c6efc21
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-17 (Fri, 17 Apr 2015)

Changed paths:
M t/post.t

Log Message:
-----------
[#1220] t/post.t: update expected values for security group labels

One example of many:

# Failed test 'Public security'
# at t/post.t line 171.
# got: '.select.security.public.label'
# expected: 'Everyone (Public)'

I just updated these to match the current output.


Commit: 60cfe8e90ae487c24848070e112d82d12c74ce47
https://github.com/dreamwidth/dw-free/commit/60cfe8e90ae487c24848070e112d82d12c74ce47
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-17 (Fri, 17 Apr 2015)

Changed paths:
M t/post.t

Log Message:
-----------
[#1220] t/post.t: updated calling convention for _form_to_backend function

One example of many:

Odd number of elements in hash assignment at t/post.t line 329.
# Failed test 'no errors'
# at t/post.t line 342.
# Structures begin differing at:
# $got->{1} = undef
# $expected->{1} = Does not exist

Looks like DW::Controller::Entry::_form_to_backend used to return an error hash, and now it
operates on a DW::FormErrors object passed to the function.


Commit: 949606ea68d54feeb57658697ecce06497fa9922
https://github.com/dreamwidth/dw-free/commit/949606ea68d54feeb57658697ecce06497fa9922
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-04-17 (Fri, 17 Apr 2015)

Changed paths:
M t/post.t

Log Message:
-----------
[#1220] t/post.t: add 'sticky_entry' to list of expected entry attributes

One example of many:

# Failed test 'decoded entry form with metadata'
# at t/post.t line 474.
# Structures begin differing at:
# $got->{sticky_entry} = undef
# $expected->{sticky_entry} = Does not exist

Adding a sticky_entry key to the reference data fixes the failures.


Commit: a8e582ccfe867d1ea79252a8c5df392a5989f665
https://github.com/dreamwidth/dw-free/commit/a8e582ccfe867d1ea79252a8c5df392a5989f665
Author: Afuna <afuna@users.noreply.github.com>
Date: 2015-04-16 (Thu, 16 Apr 2015)

Changed paths:
M t/create-url.t
M t/post.t
M t/use-strict.t

Log Message:
-----------
Merge pull request #1350 from kareila/fix-tests

Fix some tests


Compare: https://github.com/dreamwidth/dw-free/compare/f0a56c07dd6b...a8e582ccfe86