[dreamwidth/dw-free] 2b79de: Avoid "excessive recursion" error in S2

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 2b79deb5601a4ddc2739aedbe4498a762b26e77d
https://github.com/dreamwidth/dw-free/commit/2b79deb5601a4ddc2739aedbe4498a762b26e77d
Author: Afuna <fu@dreamwidth.org>
Date: 2014-05-19 (Mon, 19 May 2014)

Changed paths:
M styles/core1.s2
M styles/core2.s2
M styles/siteviews/layout.s2

Log Message:
-----------
Avoid "excessive recursion" error in S2

* Uses push/pop and iteration instead of recursion

* Works for all official core2 layouts, site styled comment pages.
Should also work for custom core2 layouts which haven't overridden
EntryPage::print_comments

* Updated core1.s2 reference implementation -- but there's nothing we
can do for the custom layouts here because most custom core1 layouts
reimplement this method

* Also prevents recursion error in comment count calculation for the
page summary module

Fixes #726.


Commit: 6e86fde61bdd4c9f0a4dccd811fdbe5d0dc0e5ae
https://github.com/dreamwidth/dw-free/commit/6e86fde61bdd4c9f0a4dccd811fdbe5d0dc0e5ae
Author: Afuna <fu@dreamwidth.org>
Date: 2014-05-19 (Mon, 19 May 2014)

Changed paths:
M styles/core2.s2

Log Message:
-----------
Stop nesting the .comment-thread divs when too deep

Browsers will stop applying visual styles to elements that are very
deeply nested. Our .comment-thread class wraps around each comment +
its replies (instead of each comment), but unfortunately, browsers
aren't very happy with that on long nested threads, and things look
broken.

(In firefox, links lose styling and everything becomes a pile of text at
the bottom. In chrome, the comments are spaced apart, but lose
indentation).

So since we know approximately when this happens, let's stop nesting
before we reach that point. Early in the thread, .comment-thread will
wrap around the comment and its replies. At 180 replies in,
.comment-thread will act like the .comment-wrapper (avoiding further
nesting)

For #726.


Commit: 3f812c4d70c6a748c760e1477017ba9f56c436ee
https://github.com/dreamwidth/dw-free/commit/3f812c4d70c6a748c760e1477017ba9f56c436ee
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-05-19 (Mon, 19 May 2014)

Changed paths:
M styles/core1.s2
M styles/core2.s2
M styles/siteviews/layout.s2

Log Message:
-----------
Merge pull request #727 from afuna/apply-pop-push-bug-726

Handle deeply-nested comment threads


Compare: https://github.com/dreamwidth/dw-free/compare/30304368161c...3f812c4d70c6

[dreamwidth/dw-free] a1aac8: Cleanup whitespace

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: a1aac8f3854e3e06af5a8ac872f8433590fadf58
https://github.com/dreamwidth/dw-free/commit/a1aac8f3854e3e06af5a8ac872f8433590fadf58
Author: Afuna <fu@dreamwidth.org>
Date: 2014-05-19 (Mon, 19 May 2014)

Changed paths:
M styles/core2.s2

Log Message:
-----------
Cleanup whitespace

[dreamwidth/dw-free] 24eb9f: Cleanup whitespace take 2

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 24eb9fcf23280ec3a9a8ffdc23bb4e1387714b6c
https://github.com/dreamwidth/dw-free/commit/24eb9fcf23280ec3a9a8ffdc23bb4e1387714b6c
Author: Afuna <fu@dreamwidth.org>
Date: 2014-05-19 (Mon, 19 May 2014)

Changed paths:
M styles/core2.s2

Log Message:
-----------
Cleanup whitespace take 2